Skins no longer have to clear user generated content and have redundant styling rules.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 25 2021, 6:28 PM

Description

Skins by default now clear any floated content in user-generated content. As a result, many of the Wikimedia deployed skins are adding unnecessary clear elements.

Acceptance criteria

Remove the redundant clear:both on #footer for CologneBlue
Remove the redundant div.mw_clear element inside Modern
Remove the redundant .visualClear inside Monobook

Descoped

Remove the redundant .visualClear inside Timeless (up to Isarra about this one)

Details

Subject	Repo	Branch	Lines +/-
Remove the redundant clear:both on #footer for CologneBlue	mediawiki/skins/CologneBlue	master	+1 -5
Remove the redundant .visualClear inside Timeless	mediawiki/skins/Timeless	master	+2 -5
Remove the redundant div.mw_clear inside Modern	mediawiki/skins/Modern	master	+1 -9

Customize query in gerrit

Related Objects

Mentioned In: T277218: ResourceLoaderSkinModule style should be added to ensure user generated content is cleared

Event Timeline

Jdlrobson created this task.Mar 25 2021, 6:28 PM

Jdlrobson mentioned this in T277218: ResourceLoaderSkinModule style should be added to ensure user generated content is cleared.

xSavitar subscribed.Apr 19 2021, 5:17 PM

Change 682266 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/skins/CologneBlue@master] Remove the redundant clear:both on #footer for CologneBlue

https://gerrit.wikimedia.org/r/682266

gerritbot added a project: Patch-For-Review.Apr 24 2021, 8:19 PM

Anjali_Kumari_41 subscribed.Apr 24 2021, 8:19 PM

Change 682268 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/skins/Timeless@master] Remove the redundant .visualClear inside Timeless

https://gerrit.wikimedia.org/r/682268

Change 682270 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[mediawiki/skins/Modern@master] Remove the redundant div.mw_clear inside Modern

https://gerrit.wikimedia.org/r/682270

Hey @Jdlrobson it seems that redundant .visualClear in Monobook is already removed, as i can't find it anywhere..or may be the issue is already solved before ..pls checkout once!

Jdlrobson removed projects: Modern, Timeless.Apr 30 2021, 4:57 PM

Jdlrobson updated the task description. (Show Details)

Change 682270 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Remove the redundant div.mw_clear inside Modern

https://gerrit.wikimedia.org/r/682270

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 6:00 PM

Change 682266 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Remove the redundant clear:both on #footer for CologneBlue

https://gerrit.wikimedia.org/r/682266

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.6; 2021-05-18); removed MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 14 2021, 1:00 AM

Jdlrobson updated the task description. (Show Details)May 14 2021, 1:02 AM

Jdlrobson moved this task from Backlog to Tech debt on the MonoBook board.Jul 1 2021, 11:05 PM