Page MenuHomePhabricator

Skins no longer have to clear user generated content and have redundant styling rules.
Open, Needs TriagePublic

Description

Skins by default now clear any floated content in user-generated content. As a result, many of the Wikimedia deployed skins are adding unnecessary clear elements.

Acceptance criteria

  • Remove the redundant clear:both on #footer for CologneBlue
  • Remove the redundant div.mw_clear element inside Modern
  • Remove the redundant .visualClear inside Monobook

Descoped

  • Remove the redundant .visualClear inside Timeless (up to Isarra about this one)

Event Timeline

Change 682266 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/skins/CologneBlue@master] Remove the redundant clear:both on #footer for CologneBlue

https://gerrit.wikimedia.org/r/682266

Change 682268 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/skins/Timeless@master] Remove the redundant .visualClear inside Timeless

https://gerrit.wikimedia.org/r/682268

Change 682270 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):

[mediawiki/skins/Modern@master] Remove the redundant div.mw_clear inside Modern

https://gerrit.wikimedia.org/r/682270

Hey @Jdlrobson it seems that redundant .visualClear in Monobook is already removed, as i can't find it anywhere..or may be the issue is already solved before ..pls checkout once!

Change 682270 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Remove the redundant div.mw_clear inside Modern

https://gerrit.wikimedia.org/r/682270

Change 682266 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Remove the redundant clear:both on #footer for CologneBlue

https://gerrit.wikimedia.org/r/682266