Page MenuHomePhabricator
Create Task
Maniphest T277218

ResourceLoaderSkinModule style should be added to ensure user generated content is cleared
Closed, ResolvedPublic
Actions

Description

Per https://www.mediawiki.org/wiki/Talk:Reading/Web/Desktop_Improvements#Bug?_Footer_engulfes_content historically floats inside of user generated content have been cleared by skins (see also https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/608976).

This should not be the responsibility of the skins to know, but should be a documented feature of ResourceLoaderSkinModule.

The new clear style would likely live in the existing content feature or a new content-user-generated feature and be inherited by all skins.

.mw-parser-output::after {
	content: "";
	display: block;
	clear: both;
}

Sign off

The following should be pulled out into separate tasks or fixed as part of this change

  • Remove the redundant clear:both on #footer for CologneBlue
  • Remove the redundant div.mw_clear element inside Modern
  • Remove the redundant .visualClear inside Monobook
  • Remove the redundant .visualClear inside Timeless
  • Opt-into the new feature and remove the redundant clear on #page-secondary-actions inside Minerva.

Moved into T278470: Skins no longer have to clear user generated content and have redundant styling rules.

Details

SubjectRepoBranchLines +/-
Use content-parser-output RL SkinModule featuremediawiki/skins/Vectormaster+3 -10
The new content-parser-output feature is documented and enabled by defaultmediawiki/coremaster+17 -2
Example skin no longer needs to clear contentmediawiki/skins/Examplemaster+2 -2
ResourceLoaderSkinModule: Add `content-parser-output` featuremediawiki/coremaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 11 2021, 7:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2021, 7:38 PM
Mainframe98 awarded a token.Mar 11 2021, 9:29 PM
Mainframe98 subscribed.
Tacsipacsi subscribed.Mar 11 2021, 11:39 PM
gerritbot added a comment.Mar 14 2021, 5:36 PM

Change 672051 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] mediawiki.skinning/content.less: Clear floated user contents

https://gerrit.wikimedia.org/r/672051

gerritbot added a project: Patch-For-Review.Mar 14 2021, 5:36 PM
Volker_E subscribed.Mar 15 2021, 1:49 PM

@Jdlrobson So that's the way out of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/608976?
I still think having skins taking care about user formatting basic styles is the more correct way!

What if 3rd party decides to live without floating user content and this rule is delivered on every page load?
'mediawiki.skinning/content.less' should be as empty as possible.

Jdlrobson added a comment.Mar 15 2021, 5:30 PM

What if 3rd party decides to live without floating user content and this rule is delivered on every page load?

'mediawiki.skinning/content.less' should be as empty as possible.

On the long term, ResourceLoaderSkinModule will have a sensible default for its features. One of these defaults would be floated user content.
If a skin developer doesn't want to support that, that's fine and their choice. They simply do not include the ResourceLoaderSkinModule feature that contains this rule. Note, the original goal is to split content up (see T269877)

The current status quo is that skin developers need to be aware that user-generated content can be floated but not cleared and that every skin copies and pastes this rule. They shouldn't have to do that.

Jdlrobson updated the task description. (Show Details)Mar 15 2021, 5:30 PM
Jdlrobson triaged this task as High priority.Mar 16 2021, 8:05 PM
Jdlrobson added a project: MW-1.36-release.
gerritbot added a comment.Mar 22 2021, 11:08 AM

Change 673989 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Use content-parser-output RL SkinModule feature

https://gerrit.wikimedia.org/r/673989

Jdlrobson merged a task: T264387: Links are not clickable on Hebrew Wikipedia main page for logged out desktop users - mw-footer-container covers almost entire page.Mar 22 2021, 6:32 PM
Jdlrobson added subscribers: Amire80, Apap04, RhinosF1.
gerritbot added a comment.Mar 23 2021, 10:13 PM

Change 672051 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Add content-parser-output feature

https://gerrit.wikimedia.org/r/672051

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 23 2021, 11:00 PM
gerritbot added a comment.Mar 23 2021, 11:21 PM

Change 674452 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] The new content-parser-output feature is enabled by default

https://gerrit.wikimedia.org/r/674452

Jdlrobson updated the task description. (Show Details)Mar 23 2021, 11:25 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 23 2021, 11:25 PM
gerritbot added a comment.Mar 23 2021, 11:29 PM

Change 674453 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Example@master] Example skin no longer needs to clear content

https://gerrit.wikimedia.org/r/674453

Jdlrobson updated the task description. (Show Details)Mar 23 2021, 11:29 PM
gerritbot added a comment.Mar 25 2021, 4:54 AM

Change 674453 merged by jenkins-bot:
[mediawiki/skins/Example@master] Example skin no longer needs to clear content

https://gerrit.wikimedia.org/r/674453

Jdlrobson mentioned this in rSEXAMPLE1515424fd82e: Example skin no longer needs to clear content.Mar 25 2021, 5:20 AM
Jdlrobson mentioned this in rSEXA1515424fd82e: Example skin no longer needs to clear content.Mar 25 2021, 5:23 AM
gerritbot added a comment.Mar 25 2021, 6:12 AM

Change 674452 merged by jenkins-bot:
[mediawiki/core@master] The new content-parser-output feature is documented and enabled by default

https://gerrit.wikimedia.org/r/674452

Jdlrobson updated the task description. (Show Details)Mar 25 2021, 6:00 PM
gerritbot added a comment.Mar 25 2021, 6:00 PM

Change 673989 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Use content-parser-output RL SkinModule feature

https://gerrit.wikimedia.org/r/673989

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2021, 6:11 PM
Jdlrobson closed this task as Resolved.Mar 25 2021, 6:28 PM
Jdlrobson claimed this task.

I've opened up T278470 for the remaining work.

Volker_E updated the task description. (Show Details)Mar 26 2021, 2:24 PM
matmarex mentioned this in T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Mar 31 2021, 7:56 PM
matmarex subscribed.

These changes caused T279008.

Jdlrobson edited projects, added Technical-Debt; removed Desktop Improvements (Vector 2022).Mar 31 2021, 8:16 PM
Jdlrobson mentioned this in T279388: ResourceLoaderSkinModule: Improve the content-parser-output module.Apr 5 2021, 10:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits