Page MenuHomePhabricator

Split out ResourceLoaderSkinModule content feature into toc and content-thumbnails features
Closed, ResolvedPublic5 Estimated Story Points

Description

The responsibilities of ResourceLoaderSkinModule content feature are too ambiguous and badly named.

They contain rules for table of contents that should be in the toc feature, legacy Tidy rules and thumbnails.

We will split this file/feature up.

This is going to become more important as we venture further into the desktop improvements project - particularly when we need to change table of contents.

Acceptance criteria

  • A new content-thumbnails feature is added containing only thumbnail rules
  • The tidy rules are moved to the legacy feature
  • Anything relating to table of contents is moved to the existing toc feature.

Event Timeline

Change 647333 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule: Move toc styles from content feature to toc feature

https://gerrit.wikimedia.org/r/647333

Jdlrobson triaged this task as Medium priority.Dec 10 2020, 6:49 PM
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
Jdlrobson raised the priority of this task from Medium to High.Mar 8 2021, 11:01 PM

@ovasileva this work should be prioritized IMO with strategic importance as it is going to become more important when it's time to touch the table of contents.
We have a patch ready for review (from me) and it has already been +1ed by a member outside our team. Given it involves members outside our team, probably best to get this done prior to when we need it, but when we have some downtime (e.g. post language deploy).

Can we perhaps aim to get this in for the 1.36 release?

Jdlrobson added a subscriber: ovasileva.

Change 647333 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoaderSkinModule: `content` => `toc`, `content-thumbnails`

https://gerrit.wikimedia.org/r/647333

phuedx removed phuedx as the assignee of this task.Apr 8 2021, 7:13 PM
phuedx added a subscriber: phuedx.