Split out ResourceLoaderSkinModule content feature into toc and content-thumbnails features
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 10 2020, 6:43 PM

Description

The responsibilities of ResourceLoaderSkinModule content feature are too ambiguous and badly named.

They contain rules for table of contents that should be in the toc feature, legacy Tidy rules and thumbnails.

We will split this file/feature up.

This is going to become more important as we venture further into the desktop improvements project - particularly when we need to change table of contents.

Acceptance criteria

A new content-thumbnails feature is added containing only thumbnail rules
The tidy rules are moved to the legacy feature
Anything relating to table of contents is moved to the existing toc feature.

Details

	Subject	Repo	Branch	Lines +/-
	ResourceLoaderSkinModule: `content` => `toc`, `content-thumbnails`	mediawiki/core	master	+296 -309

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	dancy	T281161 1.37.0-wmf.20 deployment blockers
Resolved		Jdlrobson	T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature
Resolved		Jdrewniak	T269877 Split out ResourceLoaderSkinModule content feature into toc and content-thumbnails features

Event Timeline

Jdlrobson created this task.Dec 10 2020, 6:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 6:43 PM

Change 647333 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule: Move toc styles from content feature to toc feature

https://gerrit.wikimedia.org/r/647333

gerritbot added a project: Patch-For-Review.Dec 10 2020, 6:43 PM

Jdlrobson triaged this task as Medium priority.Dec 10 2020, 6:49 PM

Mainframe98 awarded a token.Dec 10 2020, 6:59 PM

Jdlrobson mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.Dec 10 2020, 7:15 PM

Jdlrobson mentioned this in T150742: Modern and Cologneblue is missing styling for mw-empty-elt.Jan 22 2021, 1:42 AM

Jdlrobson assigned this task to ovasileva.Feb 24 2021, 9:33 PM

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Mar 2 2021, 10:44 AM

Jdlrobson raised the priority of this task from Medium to High.Mar 8 2021, 11:01 PM

@ovasileva this work should be prioritized IMO with strategic importance as it is going to become more important when it's time to touch the table of contents.
We have a patch ready for review (from me) and it has already been +1ed by a member outside our team. Given it involves members outside our team, probably best to get this done prior to when we need it, but when we have some downtime (e.g. post language deploy).

Jdlrobson mentioned this in T277218: ResourceLoaderSkinModule style should be added to ensure user generated content is cleared.Mar 15 2021, 5:30 PM