Page MenuHomePhabricator
Create Task
Maniphest T150742

Modern and Cologneblue is missing styling for mw-empty-elt
Closed, ResolvedPublic
Actions

Description

Vector has styling for mw-empty-elt, but it seems like this is missing for the skin Modern and Cologneblue. It should be something like

This will be fixed by adding the style to mw-empty-elt as is planned in T269877

Related Objects

Event Timeline

jeblad created this task.Nov 15 2016, 11:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2016, 11:37 AM
jeblad triaged this task as Low priority.Apr 13 2017, 11:33 PM
gerritbot added a comment.Jan 22 2021, 1:11 AM

Change 647333 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule: content => toc, content-thumbnails

https://gerrit.wikimedia.org/r/647333

gerritbot added a project: Patch-For-Review.Jan 22 2021, 1:11 AM
Jdlrobson removed a project: Patch-For-Review.Jan 22 2021, 1:12 AM
Jdlrobson subscribed.

Note: The style will soon be included as part of the legacy feature in ResourceLoaderSkinModule which will address this bug.

Jdlrobson renamed this task from Modern is missing styling for mw-empty-elt to Modern and Cologneblue is missing styling for mw-empty-elt.Jan 22 2021, 1:41 AM
Jdlrobson mentioned this in T192446: Skins render differently with templates returning an initial asterisk .
Jdlrobson merged a task: T192446: Skins render differently with templates returning an initial asterisk .
Jdlrobson moved this task from Backlog to Tracking on the Modern board.
Jdlrobson edited projects, added Modern (Tracking); removed Modern.
Jdlrobson added projects: CologneBlue (Tracking), MediaWiki-Core-Skin-Architecture.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Rotpunkt, Masumrezarock100, Evad37 and 2 others.
Jdlrobson moved this task from Backlog to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jan 29 2021, 3:54 AM
Jdlrobson moved this task from Phase 3 - standardise template data to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Feb 25 2021, 5:35 AM
Jdlrobson added a project: MW-1.36-release.Mar 29 2021, 8:34 PM
Jdlrobson closed this task as Resolved.Mar 30 2021, 10:47 PM
Jdlrobson claimed this task.

tested https://en.wikipedia.beta.wmflabs.org/wiki/Mw-empty-elt?useskin=cologneblue and https://en.wikipedia.beta.wmflabs.org/wiki/Mw-empty-elt?useskin=modern and element is hidden on both.

Od1n subscribed.Jul 25 2021, 2:34 PM

Similarly, I just noticed these mw-empty-elt elements aren't hidden in the "printable version" too (example).

Jdlrobson added a comment.Jul 27 2021, 4:30 PM

Thanks for flagging that. Should be easy to rectify (patch welcome). Probably should be tracked in a new bug though.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL