Page MenuHomePhabricator
Create Task
Maniphest T192446

Skins render differently with templates returning an initial asterisk
Closed, DuplicatePublic
Actions

Description

In itwiki we have found a special case which is rendered differently between Vector/Monobook/MinervaNeue group and CologneBlue/Modern/Timeless group.

Example in:

Output with Vector, Monobook, MinervaNeue:

Output with Cologne Blue, Modern, Timeless

As you can see, the first group of skins (Vector, Monobook, MinervaNeue) renders the list correctly.

Instead the second group of skins (Cologne Blue, Modern, Timeless) generates an empty first line (before "element 1").

Our expected behaviour is the same rendering among all skins.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Rotpunkt created this task.Apr 18 2018, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2018, 12:43 PM
ssastry subscribed.Apr 18 2018, 1:17 PM

That is because those skins are likely missing the .mw-empty-elt { display:none; } css rule for empty list items and empty list rows.

Legoktm added projects: Timeless, CologneBlue, Modern.Apr 18 2018, 3:47 PM
Izno subscribed.Aug 17 2018, 12:06 AM

Timeless is tracking this as T181186: Timeless list does not recognize empty items.

Evad37 subscribed.Mar 17 2019, 5:14 AM

The css rule hiding the empty list items is defined in mediawiki core, in mediawiki.skinning/content.css.
Vector, Monobook, and a few other skins add the css via the resource loader module mediawiki.skinning.interface.
Skins which aren't using that module will need to define the rule themselves, like how Minerva has done in its lists.less file.

Izno removed a project: Timeless.Mar 22 2019, 1:30 PM
Izno added a subtask: T181186: Timeless list does not recognize empty items.
Izno added a comment.Mar 22 2019, 1:35 PM

A significant contributor to empty bullets is T6281: Allow users to set a starting digit in ordered lists (and I think what was my duplicate, T202083). Fixing that would make it possible to setup a linter for the rest and then removal of the CSS/class emission, since I don't know of valid cases otherwise for empty bullets (or possibly we would find that there are other cases that need to be supported).

gerritbot added a comment.Apr 17 2019, 8:07 PM

Change 504670 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/HasSomeColours@master] Hide empty list items

https://gerrit.wikimedia.org/r/504670

gerritbot added a project: Patch-For-Review.Apr 17 2019, 8:07 PM

Change 504671 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Hide empty list items

https://gerrit.wikimedia.org/r/504671

gerritbot added a comment.Apr 17 2019, 8:19 PM

Change 504762 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/BlueSky@master] Hide empty list items

https://gerrit.wikimedia.org/r/504762

gerritbot added a comment.Apr 17 2019, 8:20 PM

Change 504763 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Modern@master] Hide empty list items

https://gerrit.wikimedia.org/r/504763

gerritbot added a comment.Apr 17 2019, 8:23 PM

Change 504766 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Hide empty list items

https://gerrit.wikimedia.org/r/504766

gerritbot added a comment.Apr 17 2019, 8:45 PM

Change 504775 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/CologneBlue@master] Hide empty list items

https://gerrit.wikimedia.org/r/504775

gerritbot added a comment.Apr 17 2019, 8:45 PM

Change 504771 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Splash@master] Hide empty list items

https://gerrit.wikimedia.org/r/504771

gerritbot added a comment.Apr 17 2019, 8:46 PM

Change 504772 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Mask@master] Hide empty list items

https://gerrit.wikimedia.org/r/504772

gerritbot added a comment.Apr 18 2019, 12:10 AM

Change 504821 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/webplatform@master] Hide empty list items

https://gerrit.wikimedia.org/r/504821

gerritbot added a comment.Apr 18 2019, 12:12 AM

Change 504822 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/Truglass@master] Hide empty list items

https://gerrit.wikimedia.org/r/504822

gerritbot added a comment.Apr 18 2019, 12:13 AM

Change 504823 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/Tempo@master] Hide empty list items

https://gerrit.wikimedia.org/r/504823

gerritbot added a comment.Apr 18 2019, 12:19 AM

Change 504762 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Hide empty list items

https://gerrit.wikimedia.org/r/504762

gerritbot added a comment.Apr 18 2019, 12:20 AM

Change 504775 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Hide empty list items

https://gerrit.wikimedia.org/r/504775

gerritbot added a comment.Apr 18 2019, 12:20 AM

Change 504671 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Hide empty list items

https://gerrit.wikimedia.org/r/504671

gerritbot added a comment.Apr 18 2019, 12:21 AM

Change 504670 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Hide empty list items

https://gerrit.wikimedia.org/r/504670

gerritbot added a comment.Apr 18 2019, 12:21 AM

Change 504772 merged by jenkins-bot:
[mediawiki/skins/Mask@master] Hide empty list items

https://gerrit.wikimedia.org/r/504772

gerritbot added a comment.Apr 18 2019, 12:21 AM

Change 504763 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Hide empty list items

https://gerrit.wikimedia.org/r/504763

gerritbot added a comment.Apr 18 2019, 12:21 AM

Change 504771 merged by jenkins-bot:
[mediawiki/skins/Splash@master] Hide empty list items

https://gerrit.wikimedia.org/r/504771

gerritbot added a comment.Apr 18 2019, 12:23 AM

Change 504766 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Hide empty list items

https://gerrit.wikimedia.org/r/504766

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 18 2019, 1:00 AM
gerritbot added a comment.Apr 18 2019, 8:37 PM

Change 504823 merged by jenkins-bot:
[mediawiki/skins/Tempo@master] Hide empty list items

https://gerrit.wikimedia.org/r/504823

gerritbot added a comment.Apr 18 2019, 8:37 PM

Change 504822 merged by jenkins-bot:
[mediawiki/skins/Truglass@master] Hide empty list items

https://gerrit.wikimedia.org/r/504822

gerritbot added a comment.Apr 18 2019, 8:40 PM

Change 504821 merged by jenkins-bot:
[mediawiki/skins/webplatform@master] Hide empty list items

https://gerrit.wikimedia.org/r/504821

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:51 PM
Isarra closed subtask T181186: Timeless list does not recognize empty items as Resolved.May 27 2019, 6:52 AM
Jdlrobson subscribed.Jan 22 2021, 1:41 AM

For deployed skins

  • Vector loads the content and legacy feature.
  • Monobook loads the content and legacy feature.
  • CologneBlue loads legacy
  • Modern loads legacy
  • MinervaNeue provides its own style for mw-empty-elt.
  • Timeless provides its own style for mw-empty-elt, but also loads legacy style.

As a result only Cologneblue and Modern impacted. Merging into T150742 and updating that ticket.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 22 2021, 1:41 AM
Jdlrobson closed this task as a duplicate of T150742: Modern and Cologneblue is missing styling for mw-empty-elt.Jan 22 2021, 1:41 AM
Isarra mentioned this in rSHASe08601102b87: Hide empty list items.May 25 2023, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL