Page MenuHomePhabricator
Create Task
Maniphest T279213

RawAction action=raw spends significant time in EchoSeenTime (via EchoHooks::onOutputPageCheckLastModified)
Closed, ResolvedPublic
Actions

Description

I noticed as part of T279120 research that about 30% of the response time for action=raw is EchoSeenTime. This code exists for the purpose of forcing a cache miss when a logged-in user revisits a page they have already visited recently, if they received new notifications since then.

This applies to page views and most wikipage actions, but not action=raw or action=render, where no skin output is used.

capture.png (954×2 px, 126 KB)

Details

SubjectRepoBranchLines +/-
EchoHooks: Skip onOutputPageCheckLastModified on action=rawmediawiki/extensions/Echomaster+6 -0
EchoHooks: Skip onOutputPageCheckLastModified on action=rawmediawiki/extensions/EchoREL1_35+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Apr 2 2021, 10:38 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 2 2021, 10:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 2 2021, 10:39 PM

Change 676689 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Echo@master] EchoHooks: Skip onOutputPageCheckLastModified on action=raw

https://gerrit.wikimedia.org/r/676689

gerritbot added a project: Patch-For-Review.Apr 2 2021, 10:39 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Apr 2 2021, 10:39 PM
gerritbot added a comment.Apr 3 2021, 10:29 AM

Change 676515 had a related patch set uploaded (by Reedy; author: Krinkle):

[mediawiki/extensions/Echo@REL1_35] EchoHooks: Skip onOutputPageCheckLastModified on action=raw

https://gerrit.wikimedia.org/r/676515

gerritbot added a comment.Apr 3 2021, 10:35 AM

Change 676515 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_35] EchoHooks: Skip onOutputPageCheckLastModified on action=raw

https://gerrit.wikimedia.org/r/676515

gerritbot added a comment.Apr 3 2021, 10:51 AM

Change 676689 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] EchoHooks: Skip onOutputPageCheckLastModified on action=raw

https://gerrit.wikimedia.org/r/676689

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 3 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2021, 11:10 AM
Legoktm closed this task as Resolved.Apr 6 2021, 6:18 AM
Legoktm assigned this task to Krinkle.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL