Page MenuHomePhabricator
Create Task
Maniphest T280010

WikibaseRepo: Remove inFederatedPropertyMode / Move it to service container
Closed, ResolvedPublic
Actions

Description

The inFederatedPropertyMode method on WikibaseRepo does not fully qualify as a service, however, it is used across the Wikibase codebase to obtain the state of federated properties from the settings.

This change should eight remove this method and change all callers to rely on the settings service OR Move this method to the service container, as a shortcut.

Details

SubjectRepoBranchLines +/-
repo: Remove inFederatedPropertiesMode and call it via service WikibaseRepo::Settingsmediawiki/extensions/Wikibasemaster+75 -46
Customize query in gerrit

Event Timeline

ItamarWMDE created this task.Apr 13 2021, 11:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2021, 11:33 AM
Rosalie_WMDE claimed this task.Apr 13 2021, 12:57 PM
Rosalie_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 13 2021, 4:34 PM

Change 678899 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: Remove inFederatedPropertiesMode and call it via service WikibaseRepo::Settings

https://gerrit.wikimedia.org/r/678899

gerritbot added a project: Patch-For-Review.Apr 13 2021, 4:34 PM
Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 14 2021, 7:07 AM
Rosalie_WMDE moved this task from Up for review to Doing on the Wikibase Service Migration board.Apr 14 2021, 12:37 PM
Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 14 2021, 4:23 PM
Addshore subscribed.Apr 15 2021, 9:47 AM
gerritbot added a comment.Apr 15 2021, 9:58 AM

Change 678899 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: Remove inFederatedPropertiesMode and call it via service WikibaseRepo::Settings

https://gerrit.wikimedia.org/r/678899

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 10:00 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 15 2021, 10:05 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2021, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits