Page MenuHomePhabricator
Create Task
Maniphest T280198

ContactPage sets "From" in SMTP request to user-provided email address
Closed, ResolvedPublic
Actions

Description

This causes messages to be rejected on services like Amazon SES that do not allow users to send emails from domains they do not own (see here). The proper behavior (used by Special:EmailUser) is to set "From" to an email address specified by the site administrator (e.g. PasswordSender or the SenderEmail config variable) put the user-provided email address in ReplyTo.

The extension currently evaluates $wgUserEmailUseReplyTo and sets ReplyTo if true, but does not change the sender to the site-configured email address.

Details

SubjectRepoBranchLines +/-
includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTomediawiki/extensions/ContactPageREL1_36+20 -14
includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTomediawiki/extensions/ContactPagemaster+20 -14
Customize query in gerrit

Related Objects

Event Timeline

Chrishel created this task.Apr 14 2021, 11:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2021, 11:35 PM
Chrishel added a comment.Apr 14 2021, 11:54 PM
This comment was removed by Chrishel.
gerritbot added a comment.Apr 15 2021, 12:47 AM

Change 679450 had a related patch set uploaded (by Chris Rishel; author: Chris Rishel):

[mediawiki/extensions/ContactPage@master] includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo

https://gerrit.wikimedia.org/r/679450

gerritbot added a project: Patch-For-Review.Apr 15 2021, 12:47 AM
RhinosF1 subscribed.Jul 23 2021, 10:17 PM
RhinosF1 added a project: User-RhinosF1.Jul 23 2021, 10:32 PM
RhinosF1 moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.
TheVoidwalker subscribed.Jul 23 2021, 10:32 PM
gerritbot added a comment.Jul 26 2021, 5:27 AM

Change 679450 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo

https://gerrit.wikimedia.org/r/679450

Ammarpad mentioned this in rECPA32e13c1ad3b7: includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo.Jul 26 2021, 5:44 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 26 2021, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2021, 6:10 AM
gerritbot added a comment.Jul 26 2021, 6:50 AM

Change 707442 had a related patch set uploaded (by RhinosF1; author: Chris Rishel):

[mediawiki/extensions/ContactPage@REL1_36] includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo

https://gerrit.wikimedia.org/r/707442

gerritbot added a project: Patch-For-Review.Jul 26 2021, 6:50 AM
gerritbot added a comment.Jul 27 2021, 9:49 AM

Change 707442 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@REL1_36] includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo

https://gerrit.wikimedia.org/r/707442

RhinosF1 mentioned this in rECPA000bc8b4dd88: includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo.Jul 27 2021, 9:50 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2021, 10:10 AM
Lens0021 merged a task: T235306: Sender address should be $wgPasswordSender when $wgUserEmailUseReplyTo is on.Oct 8 2021, 11:03 AM
Lens0021 added subscribers: Lens0021, DannyS712.
Aklapper edited projects, added affects-Miraheze; removed User-RhinosF1.Aug 15 2022, 1:19 PM
Wugapodes subscribed.Dec 1 2022, 12:41 AM

It looks like the patch has been merged, are there outstanding issues or can this task be closed?

Aklapper closed this task as Resolved.Dec 10 2022, 12:26 AM
Aklapper assigned this task to Chrishel.

Boldly closing

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL