Page MenuHomePhabricator

Replace hyphen with − in diff-marker
Closed, ResolvedPublic

Description

In DifferenceEngine.php (line 1175), please replace '-' with '−', as the hyphen is barely visible, and − is equal width to '+'.


Version: 1.16.x
Severity: enhancement

Details

Reference
bz26038

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:15 PM
bzimport set Reference to bz26038.
bzimport added a subscriber: Unknown Object (MLST).

I didn't catch that... Navigating SVN is a [female dog].

Are you familiar with bug 8327 and its associated revisions (r18468 and r18472)?

How is 8327 related. This minus is used to indicate removed text; not to denote a negative value.

It appears this must be patched in wikidiff2.cpp instead. I don't know if this has been done yet, therefor reopening.

Done for wikidiff.cpp in r82905 and for wikidiff2.cpp in r82906