Page MenuHomePhabricator

<title> element is "Error" for all error pages
Closed, ResolvedPublic

Description

Author: wikibugs

Description:
Page heading comes as Error for not logged in user. Better to change it to a more meaningful heading.

Please refer the attached screenshot.


Version: 1.18.x
Severity: minor
URL: http://commons.prototype.wikimedia.org/uwd/Special:UploadWizard

Details

Reference
bz26069

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport set Reference to bz26069.

wikibugs wrote:

HeadingError

Attached:

HeadingError.png (518×991 px, 67 KB)

This is the case for all MediaWiki error pages.

karun.84 wrote:

Patch to change the header for error pages

I propose that for the error pages we have a title like Error: No such special pages, rather than only Error.

the patch attached does this. please review it.

attachment 26069.patch ignored as obsolete

The second parameter to prepareErrorPage() could also simply be removed.

karun.84 wrote:

second version of patch to provide a better error page title

I have modified this patch as suggested to only have one argument for prepareErrorPage, and provide a better error title.

Attached:

sumanah wrote:

Karun, thank you for the patch. Are you interested in using developer access to directly suggest it into our Git source control system?

https://www.mediawiki.org/wiki/Developer_access

sumanah wrote:

For the record: was merged as https://gerrit.wikimedia.org/r/#/c/20530/ . Thanks, Karun & iAlex.