The map contains over 100 markers from the list. When saving the page, only an empty preview is displayed instead of the static map I expected.
I tried reducing the number of markers, changing the map coordinates and preview size,but it did not work.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make sure map html is rendered with canonical parseroptions | mediawiki/extensions/Kartographer | master | +13 -9 |
Hi @Strainu, thanks for taking the time to report this!
Please provide browser and browser version info and check your error console (see https://www.mediawiki.org/wiki/Help:Locating_broken_scripts ), and for future reference please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and include a list of steps to reproduce. Thanks.
I cannot reproduce in Chromium 90 or Firefox 88 on Linux:
What URL does your image have
Ah, different from yours (but in both browsers here it is the same URL):
I can reproduce on all major browsers on Windows 10, FF on Linux, FF and Opera on Android. I have no errors in the console.
That we have different data sha1s is already weird.. then either the input json is actually diffeerent... or the formatted version of the same data has differing output... Is Wikimedia going through a server upgrade cycle atm, where we have differing php and/or OS versions per chance ?
Anyway... Even if I paste the graph into a new page, then save, I see the problem. The image was rendered without the group present, even though the preview version, the live version and the img itself all refer to the same groupid (in my case, again _49ec1a521bf83404416e2f2874f3f9d8491af6a3) for
https://ro.wikipedia.org/w/index.php?title=Utilizator:TheDJ/teste&oldid=14171161
json blob: P15594
But the api mapdata request for the json only lists they key: _ee0f58c3a46265deb89a8f7b0444c4db0c6c933c
https://ro.wikipedia.org/w/api.php?action=query&format=jsonfm&prop=mapdata&titles=Utilizator%3ATheDJ%2Fteste
json blob: P15595
These should be the same but clearly are not and that primarily seems to be because the images have a differing thumbnail widths depending on the users' preferences because the images use the 'frameless' specified instead of a fixed width. I fixed that by setting fixed widths, but re-rendering the image seems to use cached values for the mapdata apirequest or some other kind of caching strategy, because i again got the same problem, even though the api id and the image's groupid were the same (and different from before, so it HAS to render a new image). I then copied the whole thing over to https://ro.wikipedia.org/wiki/Utilizator:TheDJ/teste2 and that seemed to fix the problem.
@TheDJ , thanks for the debugging. I think that if nobody will take on this bug in the near future, it should be mentioned in the documentation at least, to make sure others don't debug as much.
What I don't understand from your comment above is why it does it work for some users. Does their preferences regarting thumbnails match the ones from the server? Also an observation: slightly moving the center of the image fixes the caching problem even for existing pages.
Change 683055 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/Kartographer@master] Make sure map html is rendered with anonymous user parseroptions
T269984 also covers part where static map is generated and cached without JSON overlay (including markers).