Maniphest T281068

Remove Title in public interface of Parser
Open, MediumPublic
Actions

Assigned To

None

Authored By

	daniel
	Apr 25 2021, 5:28 PM

Tags

Referenced Files

None

Subscribers

Description

First step: widen types in method signatures to accept PageReference, PageIdentity or LinkTarget instead. (Done except for setTitle)
Second step: widen types in method signatures to return PageReference, PageIdentity or LinkTarget instead (BREAKING!). (Done except for getTitle)
Third step: survey callers of methods that return a Title (alone or as part of a tuple), and see of we can return a PageIdentity instead.
Hard-deprecate setTitle() and getTitle()
remove setTitle() and getTitle()
Forth step: change callback signatures so they no longer require a Title (and, while we are at it, remove the need to have a RevisionRecord)

Details

	Subject	Repo	Branch	Lines +/-
	Replace deprecated Parser::getTitle	mediawiki/extensions/GeoCrumbs	master	+6 -4
	Replace deprecated Parser::getTitle	mediawiki/extensions/Kartographer	master	+12 -6
	Parser: remove Title from method signatures	mediawiki/core	master	+236 -165

Customize query in gerrit

Related Objects

Mentioned In: T279796: Replace Title parameters in service classes

Event Timeline

daniel created this task.Apr 25 2021, 5:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2021, 5:28 PM

daniel mentioned this in T279796: Replace Title parameters in service classes.Apr 25 2021, 5:29 PM

Change 682328 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Parser: remove Title from method signatures

https://gerrit.wikimedia.org/r/682328

gerritbot added a project: Patch-For-Review.Apr 25 2021, 5:30 PM

Change 682328 merged by jenkins-bot:

[mediawiki/core@master] Parser: remove Title from method signatures

https://gerrit.wikimedia.org/r/682328

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 29 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 7:10 PM

daniel moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.Jun 8 2021, 11:40 AM

daniel moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Aug 26 2021, 5:27 PM

daniel triaged this task as Medium priority.May 24 2022, 8:09 AM

daniel updated the task description. (Show Details)

daniel moved this task from Doing to PageStore pile on the Platform Team Workboards (MW Expedition) board.

Change 872473 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Kartographer@master] Replace deprecated Parser::getTitle

https://gerrit.wikimedia.org/r/872473

gerritbot added a project: Patch-For-Review.Dec 27 2022, 4:47 PM

Change 872473 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Replace deprecated Parser::getTitle

https://gerrit.wikimedia.org/r/872473

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 28 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 28 2022, 1:30 AM

Change 872987 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GeoCrumbs@master] Replace deprecated Parser::getTitle

https://gerrit.wikimedia.org/r/872987

gerritbot added a project: Patch-For-Review.Dec 28 2022, 1:52 PM

Change 872987 merged by jenkins-bot:

[mediawiki/extensions/GeoCrumbs@master] Replace deprecated Parser::getTitle

https://gerrit.wikimedia.org/r/872987

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 7 2023, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2023, 12:30 AM