don't let people make mistakes like T281055#7032879
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Upgrade irc3 dependency, connect over TLS, auth over SASL | labs/tools/wikibugs2 | master | +16 -14 |
Related Objects
Related Objects
Event Timeline
Comment Actions
I'm not entirely convinced this should be solved by Wikibugs -- isn't this better solved at the client side by ignoring bots when it comes to alerts?
Assuming it should be solved by Wikibugs: how should the text '# page' be handled? Should there be a form of 'bad word replacements' where '# page' is replaced by some specified value? (And if so, should that be applied on all channels? That is probably the best effort/value tradeoff when implemented by Wikibugs).
This should probably also apply to gerrit messages, but that would be automatically solved if this is implemented in the IRC layer. (should probably make sure this doesn't break messaging to any channels that start with 'page')
Comment Actions
I'm not entirely convinced this should be solved by Wikibugs -- isn't this better solved at the client side by ignoring bots when it comes to alerts?
Yes...but effort ;)
I think a late message.replace('hashpage', '#_page') would be good enough. Would be nice but I'd treat it as lowest priority. I also haven't ever seen anyone use !_admin or !_ops in Phab before.
Comment Actions
Change 697161 had a related patch set uploaded (by Legoktm; author: Legoktm):
[labs/tools/wikibugs2@master] Upgrade irc3 dependency, connect over TLS, auth over SASL
Comment Actions
Change 697161 merged by jenkins-bot:
[labs/tools/wikibugs2@master] Upgrade irc3 dependency, connect over TLS, auth over SASL
Comment Actions
Rather than overthink this, how about just adding .replace("#page", "# page") to the existing transforms in IRCMessageBuilder.escape() and making sure both Phorge and Gerrit title and comment text gets passed through that function? Seems like that would catch all of the most likely causes.