Page MenuHomePhabricator

Add phan-template annotations to wikimedia/testing-access-wrapper
Open, LowestPublic

Description

When running phan on test classes it would help when the types on use of the TestingAccessWrapper are correct by phan.

This could be assist by @phan-template annotations

My suggestion would be:

TestingAccessWrapper::newFromObject:

@phan-template T
@phan-param T $object
@phan-return T

TestingAccessWrapper::newFromClass:

@phan-template T
@phan-param class-string<T> $className
@phan-return T