Page MenuHomePhabricator
Create Task
Maniphest T282268

[BUG] "Report incorrect display..." button in Visual Editor diff is truncated on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Open an article in VE for editing on mobile.
  • Make an edit and select the ">" arrow to see the edit summary.
  • Select "Review your changes" to see the diff in Visual diff mode.

What happens?:
The "Report incorrect display..." button is truncated

Screenshot_20210507-200046.png (2×969 px, 600 KB)

What should have happened instead?:
The button should not be truncated.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Screenshot from ewiki on 2021-05-07. From Android Pixel 4 / Chrome Beta.

Details

SubjectRepoBranchLines +/-
Remove the "Report incorrect…" button on visual diffs in save dialogmediawiki/extensions/VisualEditormaster+0 -39
Customize query in gerrit

Related Objects

Event Timeline

RHo created this task.May 7 2021, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2021, 6:18 PM
• Ankan_WMF subscribed.May 21 2021, 8:37 AM

The same problem is also present in Bengali Wikipedia. A screenshot from bnwiki on 2021-05-21:

IncorrectDisplay.jpg (2×1 px, 461 KB)

TheresNoTime subscribed.Mar 15 2023, 5:42 PM
matmarex claimed this task.Apr 18 2023, 8:34 PM
matmarex subscribed.

I think we should remove this button. We recently released visual diffs out of beta (T314588). We're not expecting users to commonly encounter problems worth reporting, and we're not actively looking for feedback. The page that this button links to only sees occasional comments (https://www.mediawiki.org/wiki/Talk:VisualEditor/Diffs).

gerritbot added a comment.Apr 18 2023, 8:35 PM

Change 909752 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Remove the "Report incorrect…" button on visual diffs in save dialog

https://gerrit.wikimedia.org/r/909752

gerritbot added a project: Patch-For-Review.Apr 18 2023, 8:35 PM
gerritbot added a comment.Apr 20 2023, 9:44 AM

Change 909752 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove the "Report incorrect…" button on visual diffs in save dialog

https://gerrit.wikimedia.org/r/909752

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2023, 10:15 AM
matmarex closed this task as Resolved.Apr 20 2023, 6:32 PM
matmarex added a project: Editing-team (Kanban Board).
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL