Rebaser: Text formatting options throw an error and desync users
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	WMDE-Fisch
	May 23 2021, 12:16 PM

Description

When trying to apply any text formatting option ( bold, italic, strike-though ... ) the server throws an exception with

TypeError: Cannot read property 'static' of undefined\n    at /home/chfi/projects/VisualEditor/dist/ve-rebaser.js:3348:36
    at Array.every (<anonymous>)
    at VeDmTransaction.ve.dm.Transaction.translateOffset (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:3347:14)
    at VeDmTransaction.ve.dm.Transaction.translateRangeWithAuthor (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:3424:16)
    at VeDmLinearSelection.ve.dm.LinearSelection.translateByTransactionWithAuthor (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:5980:34)
    at VeDmLinearSelection.ve.dm.Selection.translateByChange (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:5705:25)
    at Object.ve.dm.Change.static.rebaseUncommittedChange (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:4106:70)
    at VeDmRebaseServer.applyChange (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:4845:38)
    at VeDmProtocolServer.ve.dm.ProtocolServer.onSubmitChange (/home/chfi/projects/VisualEditor/dist/ve-rebaser.js:5152:36)
    at /home/chfi/projects/VisualEditor/dist/ve-rebaser.js:5257:14
    at process._tickCallback (internal/process/next_tick.js:68:7)

It's obviously due to missing dependencies not pulled in.

Note: Looked into this on a WMDE hack day and continued a bit on the Wikimedia-Hackathon-2021.

Details

Subject	Repo	Branch	Lines +/-
Check if module exists before using it	unicodejs	master	+5 -1
Remove dependency of the model registry from ve.dm.Transaction	VisualEditor/VisualEditor	master	+52 -2
Update VE core submodule to master (7ab2ebb0f)	mediawiki/extensions/VisualEditor	master	+1 -1
Rebaser: Fix broken text formatting options	VisualEditor/VisualEditor	master	+11 -3

Customize query in gerrit

Event Timeline

WMDE-Fisch created this task.May 23 2021, 12:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2021, 12:16 PM

Change 683829 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[VisualEditor/VisualEditor@master] Rebaser: Fix broken text formatting options

https://gerrit.wikimedia.org/r/683829

Change 693555 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[unicodejs@master] Check if module exists before using it

https://gerrit.wikimedia.org/r/693555

WMDE-Fisch added a project: Wikimedia-Hackathon-2021.May 23 2021, 1:37 PM

Change 692684 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Remove dependency of the model registry from ve.dm.Transaction

https://gerrit.wikimedia.org/r/692684

Change 692684 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Remove dependency of the model registry from ve.dm.Transaction

https://gerrit.wikimedia.org/r/692684

Change 683829 abandoned by WMDE-Fisch:

[VisualEditor/VisualEditor@master] Rebaser: Fix broken text formatting options

Reason:

Solved nicer in I8ebe5266d664b915eb03e6cf78191fb923daad4e

https://gerrit.wikimedia.org/r/683829

Change 698253 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7ab2ebb0f)

https://gerrit.wikimedia.org/r/698253

Change 698253 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7ab2ebb0f)

https://gerrit.wikimedia.org/r/698253

Presumably resolved

Change 693555 abandoned by WMDE-Fisch: