The parser should give a warning if a regexp matches the empty string, however it's no longer doing that. Looking at the code this is fairly obvious, since we pass an AFPData to checkRegexMatchesEmpty, but that method doesn't parse the regexp correctly (i.e. slashes are not escaped, and delimiters aren't added), so it never matches.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Pass a valid regexp to preg_match in checkRegexMatchesEmpty | mediawiki/extensions/AbuseFilter | master | +22 -15 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 697103 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Pass a valid regexp to preg_match in checkRegexMatchesEmpty
Comment Actions
Change 697103 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Pass a valid regexp to preg_match in checkRegexMatchesEmpty