Page MenuHomePhabricator

Move inference services to v1beta1 api
Closed, ResolvedPublic

Description

There is an upcoming deprecation of the v1alpha2 apis for inference services in the next release of KFServing.

See: https://github.com/kubeflow/kfserving/issues/1618

inference service v1alpha2 version should no longer be used after 0.6, we should remove v1alpha2 version support from crd and corresponding webhooks, controller and api types. Currently there is a Conversion webhook installed to automatically convert v1alpha2 inference service to v1beta1, although it is recommended rewriting all your spec with V1beta1 API as we plan to drop the support for v1alpha2 in later versions.

The biggest thing we'll need to change is the api type at the top of crd, and then the name 'custom' is just 'containers' now.

Event Timeline

ACraze raised the priority of this task from Low to Medium.
ACraze added a subscriber: elukey.

After talking with @elukey, it seems the conversion webhook is not patched by the self-signed-ca.sh (see: T280661) script in KFServing v0.5.x. When the kfserving webhook automatically converts from v1alpha2 to v1beta1, the converted service is not patched with the custom CA. The issue is cleared up when the service is deployed using the v1beta1 and bypasses the conversion webhook.

A Github issue was opened about this issue: https://github.com/kubeflow/kfserving/issues/1657 , so it seems likely that this bug will be patched, however we still should re-write our inference service specs to use v1beta1 to avoid further confusion down the road. Updating the priority and moving to the active-board.

Change 698879 had a related patch set uploaded (by Accraze; author: Accraze):

[machinelearning/liftwing/inference-services@main] migrate outlinks-topic-model to v1beta1

https://gerrit.wikimedia.org/r/698879

Change 698887 had a related patch set uploaded (by Accraze; author: Accraze):

[machinelearning/liftwing/inference-services@main] migrate enwiki-goodfaith to v1beta1

https://gerrit.wikimedia.org/r/698887

Change 698890 had a related patch set uploaded (by Accraze; author: Accraze):

[machinelearning/liftwing/inference-services@main] migrate enwiki-damaging to v1beta1

https://gerrit.wikimedia.org/r/698890

Change 698879 merged by Accraze:

[machinelearning/liftwing/inference-services@main] migrate outlink-topic-model to v1beta1

https://gerrit.wikimedia.org/r/698879

Change 698887 merged by Accraze:

[machinelearning/liftwing/inference-services@main] migrate enwiki-goodfaith to v1beta1

https://gerrit.wikimedia.org/r/698887

Change 698890 merged by Accraze:

[machinelearning/liftwing/inference-services@main] migrate enwiki-damaging to v1beta1

https://gerrit.wikimedia.org/r/698890

Alright, looks like all our current specs have been rewritten to reflect the v1beta1 api and have been confirmed to run well on KFServing 0.5.X.
All new services should use this as well.

Marking this as resolved.