Page MenuHomePhabricator
Create Task
Maniphest T284558

Pull toolviews data from Kubernetes HAProxy or ingress-nginx instead of the front nginx
Closed, ResolvedPublic
Actions

Description

Design and implement toolviews changes to support running at ingress-nginx level instead of the front dynamicproxy

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
toolforge: toolviews: Drop nginx supportoperations/puppetproduction+6 -38
P:toolforge: Move toolviews processing to HAProxyoperations/puppetproduction+7 -22
toolforge: toolviews: Fix parsing HAProxy logsoperations/puppetproduction+3 -4
toolforge: toolviews: Add initial HAProxy supportoperations/puppetproduction+24 -11
toolforge: toolviews: Move nginx-specific parts to nginx profileoperations/puppetproduction+15 -21
P:toolforge::k8s::haproxy: Include host header in access logoperations/puppetproduction+2 -0
P:toolforge::k8s::haproxy: Log all requestsoperations/puppetproduction+33 -16
haproxy: Remove separate cloud::base classoperations/puppetproduction+14 -44
toolforge:toolviews: Allow disabling toolviews in hieraoperations/puppetproduction+12 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

taavi created this task.Jun 8 2021, 12:46 PM
taavi added a comment.Jun 8 2021, 1:08 PM

I wonder if we could do this based on Prometheus metrics created by ingress-nginx, instead of having to read and parse access logs

• Bstorm subscribed.Jun 8 2021, 4:24 PM
In T284558#7142228, @Majavah wrote:

I wonder if we could do this based on Prometheus metrics created by ingress-nginx, instead of having to read and parse access logs

We likely could if the grid services are going through service objects like you are implementing.

gerritbot added a comment.Jun 12 2021, 12:07 PM

Change 699485 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] toolforge:toolviews: Allow disabling toolviews in hiera

https://gerrit.wikimedia.org/r/699485

gerritbot added a project: Patch-For-Review.Jun 12 2021, 12:07 PM
taavi added a subscriber: • bd808.Jun 20 2021, 2:15 PM
• nskaggs triaged this task as Medium priority.Aug 10 2021, 10:14 PM
• nskaggs moved this task from Backlog to In Progress on the Toolforge board.
gerritbot added a comment.Jun 28 2022, 9:19 AM

Change 699485 merged by David Caro:

[operations/puppet@production] toolforge:toolviews: Allow disabling toolviews in hiera

https://gerrit.wikimedia.org/r/699485

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2022, 9:30 AM
fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:51 PM
fnegri moved this task from Kanban to Inbox on the cloud-services-team board.
dcaro moved this task from In Progress to Ready to be worked on on the Toolforge board.Sep 26 2023, 2:33 PM
dcaro moved this task from Ready to be worked on to Workspace for triaging whenever needed on the Toolforge board.Jan 24 2024, 1:52 PM
taavi renamed this task from Add toolviews support for Kubernetes ingress-nginx to Pull toolviews data from Kubernetes HAProxy or ingress-nginx instead of the front nginx.Jan 24 2024, 1:55 PM
dcaro moved this task from Workspace for triaging whenever needed to Ready to be worked on on the Toolforge board.Feb 21 2024, 4:03 PM
Krinkle awarded a token.Oct 3 2025, 6:25 PM
gerritbot added a comment.Oct 9 2025, 9:48 AM

Change #1194895 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] haproxy: Remove separate cloud::base class

https://gerrit.wikimedia.org/r/1194895

gerritbot added a project: Patch-For-Review.Oct 9 2025, 9:48 AM
gerritbot added a comment.Oct 9 2025, 10:09 AM

Change #1194895 merged by Majavah:

[operations/puppet@production] haproxy: Remove separate cloud::base class

https://gerrit.wikimedia.org/r/1194895

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2025, 10:32 AM
taavi claimed this task.Oct 13 2025, 12:03 PM
taavi edited projects, added tools-infrastructure-team; removed cloud-services-team.
gerritbot added a comment.Oct 13 2025, 12:18 PM

Change #1195656 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:toolforge::k8s::haproxy: Log all requests

https://gerrit.wikimedia.org/r/1195656

gerritbot added a project: Patch-For-Review.Oct 13 2025, 12:18 PM

Change #1195657 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:toolforge::k8s::haproxy: Include host header in access log

https://gerrit.wikimedia.org/r/1195657

gerritbot added a comment.Oct 14 2025, 11:47 AM

Change #1195656 merged by Majavah:

[operations/puppet@production] P:toolforge::k8s::haproxy: Log all requests

https://gerrit.wikimedia.org/r/1195656

gerritbot added a comment.Oct 14 2025, 11:56 AM

Change #1195657 merged by Majavah:

[operations/puppet@production] P:toolforge::k8s::haproxy: Include host header in access log

https://gerrit.wikimedia.org/r/1195657

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2025, 12:32 PM
gerritbot added a comment.Oct 20 2025, 12:06 PM

Change #1197242 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] toolforge: toolviews: Move nginx-specific parts to nginx profile

https://gerrit.wikimedia.org/r/1197242

gerritbot added a project: Patch-For-Review.Oct 20 2025, 12:06 PM

Change #1197243 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] toolforge: toolviews: Add initial HAProxy support

https://gerrit.wikimedia.org/r/1197243

gerritbot added a comment.Oct 20 2025, 12:51 PM

Change #1197242 merged by Majavah:

[operations/puppet@production] toolforge: toolviews: Move nginx-specific parts to nginx profile

https://gerrit.wikimedia.org/r/1197242

gerritbot added a comment.Oct 20 2025, 12:52 PM

Change #1197243 merged by Majavah:

[operations/puppet@production] toolforge: toolviews: Add initial HAProxy support

https://gerrit.wikimedia.org/r/1197243

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2025, 1:32 PM
gerritbot added a comment.Oct 20 2025, 1:55 PM

Change #1197270 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] toolforge: toolviews: Fix parsing HAProxy logs

https://gerrit.wikimedia.org/r/1197270

gerritbot added a project: Patch-For-Review.Oct 20 2025, 1:55 PM
gerritbot added a comment.Oct 20 2025, 1:57 PM

Change #1197270 merged by Majavah:

[operations/puppet@production] toolforge: toolviews: Fix parsing HAProxy logs

https://gerrit.wikimedia.org/r/1197270

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2025, 2:32 PM
Stashbot added a comment.Oct 20 2025, 4:31 PM

Mentioned in SAL (#wikimedia-cloud) [2025-10-20T16:31:42Z] <taavi> make logrotate run hourly on haproxy nodes T284558

gerritbot added a comment.Oct 20 2025, 4:39 PM

Change #1197308 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:toolforge: Move toolviews processing to HAProxy

https://gerrit.wikimedia.org/r/1197308

gerritbot added a project: Patch-For-Review.Oct 20 2025, 4:39 PM
gerritbot added a comment.Oct 22 2025, 12:34 PM

Change #1197308 merged by Majavah:

[operations/puppet@production] P:toolforge: Move toolviews processing to HAProxy

https://gerrit.wikimedia.org/r/1197308

gerritbot added a comment.Oct 22 2025, 12:44 PM

Change #1198045 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] toolforge: toolviews: Drop nginx support

https://gerrit.wikimedia.org/r/1198045

gerritbot added a comment.Oct 22 2025, 2:11 PM

Change #1198045 merged by Majavah:

[operations/puppet@production] toolforge: toolviews: Drop nginx support

https://gerrit.wikimedia.org/r/1198045

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2025, 2:31 PM
taavi closed this task as Resolved.Oct 22 2025, 4:14 PM
• bd808 mentioned this in T408454: Toolviews table (s53734__toolviews_p) not updated since 2025-10-22.Oct 27 2025, 9:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits