Page MenuHomePhabricator

Code editor failing to load completely on English Wiktionary
Closed, ResolvedPublic

Description

@Justinrleung mentioned to me on Discord that the code editor fails to load properly on English Wiktionary in modules (and JavaScript and CSS pages). In the console there's an error mentioning wikiEditor in the backtrace. The issue starts showing up in wmf.9.

I looked at the prettified source code in the Firefox developer tools and did a code search, and the offending line seems to be in jquery.wikiEditor.js on line 551. The variable module is undefined. The module variable was renamed to m in this commit on May 23, but one use of module was left behind, causing the error. Looks like the solution's as simple as fixing that variable name.

Event Timeline

Aklapper triaged this task as Unbreak Now! priority.Thu, Jun 10, 8:39 AM
Zabe added a subscriber: Zabe.

Change 699149 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikiEditor@master] Fix call to renamed var

https://gerrit.wikimedia.org/r/699149

Change 699168 had a related patch set uploaded (by Urbanecm; author: Zabe):

[mediawiki/extensions/WikiEditor@wmf/1.37.0-wmf.9] Fix call to renamed var

https://gerrit.wikimedia.org/r/699168

Change 699149 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Fix call to renamed var

https://gerrit.wikimedia.org/r/699149

Change 699168 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@wmf/1.37.0-wmf.9] Fix call to renamed var

https://gerrit.wikimedia.org/r/699168

Mentioned in SAL (#wikimedia-operations) [2021-06-10T10:43:07Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/WikiEditor/modules/jquery.wikiEditor.js: 8a17c43c5470b84ba58239bb2cf947dbebf1979f: Fix call to renamed var (T284716) (duration: 01m 25s)

Urbanecm added a subscriber: Urbanecm.

This should be fixed now