1.37.0-wmf.9 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	thcipriani
	Apr 26 2021, 3:14 PM

Details

Backup Train Conductor: • mmodell
Release Version: 1.37.0-wmf.9
Release Date: Jun 7 2021, 12:00 AM

2021 week 23 1.37-wmf.9 Changes wmf/1.37.0-wmf.9

This MediaWiki Train Deployment is scheduled for the week of Monday, June 7th:

Monday June 7th	Tuesday, June 8th	Wednesday, June 9th	Thursday, June 10th	Friday
Backports only.	Branch `wmf.9` and deploy to Group 0 Wikis.	Deploy `wmf.9` to Group 1 Wikis.	Deploy `wmf.9` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.9 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.37.0-wmf.8

Next: 1.37.0-wmf.10

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	jeena	T281150 1.37.0-wmf.9 deployment blockers
Duplicate	PRODUCTION ERROR	None	T284509 Beta cluster refuses any kind of edits with session errors
Resolved		matmarex	T284567 [regression] Reply tool padding and height broken
Resolved	PRODUCTION ERROR	DannyS712	T284685 TypeError: Argument 1 passed to LanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php on line 132
Resolved		Zabe	T284716 Code editor failing to load completely on English Wiktionary
Resolved		AntiCompositeNumber	T284786 Automatic citation addition in VisualEditor has stopped working

Event Timeline

thcipriani created this task.Apr 26 2021, 3:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 3:14 PM

thcipriani assigned this task to jeena.May 28 2021, 1:42 AM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • mmodell.

thcipriani added a project: Release-Engineering-Team (Doing).

Ladsgroup subscribed.Jun 7 2021, 8:56 AM

Tarrow subscribed.Jun 7 2021, 9:00 AM

Macro whereismypopcorn:

karapayneWMDE subscribed.Jun 7 2021, 9:06 AM

Zabe subscribed.Jun 7 2021, 9:12 AM

Michael subscribed.Jun 7 2021, 9:37 AM

matmarex added a subtask: T284496: Regression: Echo new talk page message banner has lost its orange background.Jun 7 2021, 8:23 PM

In T281150#7137851, @Ladsgroup wrote:

Is there a risky patch or something we should be worried about in this train?

In T281150#7140642, @thcipriani wrote:

Is there a risky patch or something we should be worried about in this train?

The planned removal of the Revision class hasn't merged yet (waiting for Wikibase to decide if it wants to continue supporting 1.36 on master) so that risky patch will be for some future train

In T281150#7140642, @thcipriani wrote:

Is there a risky patch or something we should be worried about in this train?

No risky patch but it'll be two weeks of patches instead of one.

In T281150#7140695, @Ladsgroup wrote:

In T281150#7140642, @thcipriani wrote:

Is there a risky patch or something we should be worried about in this train?

No risky patch but it'll be two weeks of patches instead of one.

Ah, got it, had me worried :)

matmarex added a subtask: T284567: [regression] Reply tool padding and height broken.Jun 8 2021, 2:30 PM

Change 698818 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] testwikis wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/698818

Change 698818 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/698818

Mentioned in SAL (#wikimedia-operations) [2021-06-08T16:32:22Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.37.0-wmf.9 refs T281150

Jdlrobson removed a subtask: T284496: Regression: Echo new talk page message banner has lost its orange background.Jun 8 2021, 5:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-08T17:06:34Z] <jhuneidi@deploy1002> Finished scap: testwikis wikis to 1.37.0-wmf.9 refs T281150 (duration: 34m 12s)

@jeena would it be possible to merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/698680 before pushing forward with the train?

@Jdlrobson I think that would be alright. Do you need me to deploy it to testwikis?

@jeena should be fine to just merge into the branch before we deploy to mediawiki.org / test.wikipedia.org. I'd rather not see this regression go out in any form to production wikis. I am happy to verify it once that's done if helpful.

Sounds good, thanks @Jdlrobson

Change 698845 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/698845

Change 698845 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/698845

Mentioned in SAL (#wikimedia-operations) [2021-06-08T19:53:29Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.37.0-wmf.9 refs T281150

Change 699060 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/699060

Change 699060 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/699060

Mentioned in SAL (#wikimedia-operations) [2021-06-09T19:06:53Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.37.0-wmf.9 refs T281150

Mentioned in SAL (#wikimedia-operations) [2021-06-09T19:08:01Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.37.0-wmf.9 refs T281150 (duration: 01m 07s)

DannyS712 added a subtask: T284685: TypeError: Argument 1 passed to LanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php on line 132.Jun 9 2021, 7:47 PM

Ladsgroup closed subtask T284685: TypeError: Argument 1 passed to LanguageConverter::__construct() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.37.0-wmf.9/includes/language/LanguageConverterFactory.php on line 132 as Resolved.Jun 9 2021, 9:42 PM

CodeEditor is broken on group 0 and group 1 wikis.

In T281150#7147966, @Xiplus wrote:

CodeEditor is broken on group 0 and group 1 wikis.

Fix merged, and I'll backport it momentarily.

Urbanecm closed subtask T284716: Code editor failing to load completely on English Wiktionary as Resolved.Jun 10 2021, 10:43 AM

• ppelberg closed subtask T284567: [regression] Reply tool padding and height broken as Resolved.Jun 10 2021, 4:34 PM

Change 699274 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/699274

Change 699274 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.9 refs T281150

https://gerrit.wikimedia.org/r/699274

Mentioned in SAL (#wikimedia-operations) [2021-06-10T19:09:21Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.37.0-wmf.9 refs T281150

Jdforrester-WMF added a subtask: T284786: Automatic citation addition in VisualEditor has stopped working.Jun 10 2021, 11:10 PM

Jdforrester-WMF closed subtask T284786: Automatic citation addition in VisualEditor has stopped working as Resolved.Jun 10 2021, 11:29 PM

jeena closed this task as Resolved.Jun 14 2021, 6:44 PM

1.37.0-wmf.9 deployment blockersClosed, ResolvedPublicReleaseActions