Page MenuHomePhabricator
Create Task
Maniphest T284496

Regression: Echo new talk page message banner has lost its orange background
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
matmarex
Jun 7 2021, 8:22 PM
Tags
Referenced Files
F34508737: Screen Shot 2021-06-16 at 3.53.50 PM.png
Jun 16 2021, 11:02 PM
F34508739: Screen Shot 2021-06-16 at 3.54.50 PM.png
Jun 16 2021, 11:02 PM
F34508741: Screen Shot 2021-06-16 at 3.55.14 PM.png
Jun 16 2021, 11:02 PM
F34508733: Screen Shot 2021-06-16 at 3.51.40 PM.png
Jun 16 2021, 11:02 PM
F34508735: Screen Shot 2021-06-16 at 3.52.03 PM.png
Jun 16 2021, 11:02 PM
F34508743: Screen Shot 2021-06-16 at 3.57.52 PM.png
Jun 16 2021, 11:02 PM
F34489153: Screen Shot 2021-06-10 at 12.30.12 AM.png
Jun 10 2021, 7:35 AM
F34489155: Screen Shot 2021-06-10 at 12.30.52 AM.png
Jun 10 2021, 7:35 AM
View All 18 Files
Subscribers
Aklapper
Edtadros
Jdlrobson
Jdrewniak
matmarex
• nray
ovasileva

Description

Echo new talk page message banner has lost its orange background, in all skins except new Vector.

Testing on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page:

old Vectornew VectorMonobookTimelessModernCologneBlue
image.png (2×3 px, 814 KB)
image.png (2×3 px, 696 KB)
image.png (2×3 px, 920 KB)
image.png (2×3 px, 696 KB)
image.png (2×3 px, 711 KB)
image.png (2×3 px, 756 KB)

QA Results - Beta

ACStatusDetails
1✅T284496#7147799

QA Results - Prod

ACStatusDetails
1✅T284496#7160054

Details

SubjectRepoBranchLines +/-
Set `.mw-echo-alert` class on link instead of list-itemmediawiki/extensions/Echomaster+1 -1
Fix MonoBook orange banner hover stylesmediawiki/extensions/Echowmf/1.37.0-wmf.9+2 -1
Fix MonoBook orange banner hover stylesmediawiki/extensions/Echomaster+2 -1
Set `.mw-echo-alert` class on link instead of list-itemmediawiki/extensions/Echowmf/1.37.0-wmf.9+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jun 7 2021, 8:22 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 7 2021, 8:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a parent task: T281150: 1.37.0-wmf.9 deployment blockers.Jun 7 2021, 8:23 PM
matmarex added subscribers: Jdlrobson, • nray, Jdrewniak.
ovasileva triaged this task as High priority.Jun 8 2021, 11:06 AM
ovasileva added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).
gerritbot added a comment.Jun 8 2021, 11:32 AM

Change 698762 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Echo@master] Set `.mw-echo-alert` class on link instead of list-item

https://gerrit.wikimedia.org/r/698762

gerritbot added a project: Patch-For-Review.Jun 8 2021, 11:32 AM
gerritbot added a comment.Jun 8 2021, 12:37 PM

Change 698762 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Set `.mw-echo-alert` class on link instead of list-item

https://gerrit.wikimedia.org/r/698762

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 8 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 1:10 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 8 2021, 4:35 PM
Jdlrobson removed a parent task: T281150: 1.37.0-wmf.9 deployment blockers.Jun 8 2021, 5:04 PM
gerritbot added a comment.Jun 8 2021, 5:06 PM

Change 698680 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/extensions/Echo@wmf/1.37.0-wmf.9] Set `.mw-echo-alert` class on link instead of list-item

https://gerrit.wikimedia.org/r/698680

gerritbot added a project: Patch-For-Review.Jun 8 2021, 5:06 PM
ovasileva subscribed.Jun 8 2021, 5:06 PM

Can we backport this? Generally, this wouldn't be a blocker, but since there's no train next week, it would be nice to get a fix out sooner than the next train.

ovasileva renamed this task from Echo new talk page message banner has lost its orange background to Regression: Echo new talk page message banner has lost its orange background.Jun 8 2021, 5:07 PM
Jdlrobson claimed this task.Jun 8 2021, 5:07 PM
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
matmarex added a comment.Jun 8 2021, 5:46 PM
In T284496#7142981, @ovasileva wrote:

Can we backport this? Generally, this wouldn't be a blocker, but since there's no train next week, it would be nice to get a fix out sooner than the next train.

I would consider this issue a blocker, even if the impact is somewhat low, because message notifications are a hot topic right now (see https://en.wikipedia.org/wiki/WP:THEYCANTHEARYOU).

ovasileva added a comment.Jun 8 2021, 5:51 PM
In T284496#7143126, @matmarex wrote:
In T284496#7142981, @ovasileva wrote:

Can we backport this? Generally, this wouldn't be a blocker, but since there's no train next week, it would be nice to get a fix out sooner than the next train.

I would consider this issue a blocker, even if the impact is somewhat low, because message notifications are a hot topic right now (see https://en.wikipedia.org/wiki/WP:THEYCANTHEARYOU).

Discussed in standup - we'll try to backport today, tomorrow at the latest

gerritbot added a comment.Jun 8 2021, 5:54 PM

Change 698833 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Echo@master] Fix MonoBook orange banner hover styles

https://gerrit.wikimedia.org/r/698833

gerritbot added a comment.Jun 8 2021, 6:15 PM

Change 698848 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/Echo@wmf/1.37.0-wmf.9] Fix MonoBook orange banner hover styles

https://gerrit.wikimedia.org/r/698848

gerritbot added a comment.Jun 8 2021, 6:25 PM

Change 698833 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix MonoBook orange banner hover styles

https://gerrit.wikimedia.org/r/698833

gerritbot added a comment.Jun 8 2021, 6:36 PM

Change 698680 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.37.0-wmf.9] Set `.mw-echo-alert` class on link instead of list-item

https://gerrit.wikimedia.org/r/698680

gerritbot added a comment.Jun 8 2021, 6:55 PM

Change 698848 merged by jenkins-bot:

[mediawiki/extensions/Echo@wmf/1.37.0-wmf.9] Fix MonoBook orange banner hover styles

https://gerrit.wikimedia.org/r/698848

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.9; 2021-06-07); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 8 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 7:10 PM
Stashbot added a comment.Jun 8 2021, 7:32 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-08T19:32:47Z] <ladsgroup@deploy1002> Synchronized php-1.37.0-wmf.9/extensions/Echo/modules/nojs/mw.echo.alert.monobook.less: Backport: [[gerrit:698848|Fix MonoBook orange banner hover styles (T284496)]] (duration: 01m 08s)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 8 2021, 7:54 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 10 2021, 7:35 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Testing on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page:

✅ AC1: Orange background exists for new message notification.

old Vectornew VectorMonobookTimelessModernCologneBlue
Screen Shot 2021-06-10 at 12.28.39 AM.png (788×1 px, 296 KB)
Screen Shot 2021-06-10 at 12.28.57 AM.png (788×1 px, 273 KB)
Screen Shot 2021-06-10 at 12.29.23 AM.png (788×1 px, 317 KB)
Screen Shot 2021-06-10 at 12.30.12 AM.png (788×1 px, 233 KB)
Screen Shot 2021-06-10 at 12.30.52 AM.png (788×1 px, 259 KB)
Screen Shot 2021-06-10 at 12.31.10 AM.png (788×1 px, 287 KB)
Edtadros updated the task description. (Show Details)Jun 10 2021, 7:36 AM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Jun 10 2021, 8:01 AM
valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.11; 2021-06-21); removed MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 12 2021, 8:11 PM
Edtadros reassigned this task from Edtadros to ovasileva.Jun 16 2021, 11:02 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Testing on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page:

✅ AC1: Orange background exists for new message notification.

old Vectornew VectorMonobookTimelessModernCologneBlue
Screen Shot 2021-06-16 at 3.51.40 PM.png (904×1 px, 535 KB)
Screen Shot 2021-06-16 at 3.52.03 PM.png (904×1 px, 430 KB)
Screen Shot 2021-06-16 at 3.53.50 PM.png (904×1 px, 628 KB)
Screen Shot 2021-06-16 at 3.54.50 PM.png (904×1 px, 421 KB)
Screen Shot 2021-06-16 at 3.55.14 PM.png (904×1 px, 557 KB)
Screen Shot 2021-06-16 at 3.57.52 PM.png (904×1 px, 637 KB)

@ovasileva This passes as far as the orange background. However, when the notice is in a menu on Timeless and CologneBlue, it overlaps itself.

Edtadros updated the task description. (Show Details)Jun 16 2021, 11:03 PM
Jdlrobson added a comment.Jun 24 2021, 5:09 PM

@ovasileva This passes as far as the orange background. However, when the notice is in a menu on Timeless and CologneBlue, it overlaps itself.

I noticed Timeless and CologneBlue had this issue before we merged our change so I don't think this is related.

ovasileva closed this task as Resolved.Jun 24 2021, 6:02 PM
In T284496#7175607, @Jdlrobson wrote:

@ovasileva This passes as far as the orange background. However, when the notice is in a menu on Timeless and CologneBlue, it overlaps itself.

I noticed Timeless and CologneBlue had this issue before we merged our change so I don't think this is related.

Sounds good, resolving

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits