Page MenuHomePhabricator

ReleaseTaggerBot skipping some Tasks/Patches?
Open, HighPublic

Description

For some reason @ReleaseTaggerBot didn't applied the release tags on T283194: Change User and User talk namespace name in tyv.wikipedia.org, a merged MediaWiki core change. It used to do so in the past (refs.). I saw nothing in the error nor in the output logs that suggests why this might be happening. Configuration issue? Thanks.

Related Objects

Mentioned Here
T280322: Upgrade mailing lists from mailman2 to 3 in batches
T219215: Don’t suggest edits to real items in API sandbox
T247710: Argument 3 passed to ApiAuthManagerHelper::formatMessage() must be an instance of Message, null given, called in ApiAuthManagerHelper.php on line 337
T251348: Watchlist Expiry: Implement UI for VisualEditor [Large]
T253077: Convert MWGrants to a service with dependency injection
T258766: Remove IE <= 8 CSS hacks and workarounds in core, extensions and skins
T274881: Change translation variable (tvar) syntax
T274907: Change template search in TemplateWizard to use standard search API
T276562: User links, Skins: Provide generalized way to add icons to user links dropdown menu"
T277862: selenium-daily-beta-WikibaseLexeme broken since mid feb 2021
T279492: Add a link: animate icon in recommended link annotation when acceptance changes
T279557: Add lexeme language codes bfi, pwn, enm
T280051: Make mobilefrontend talk overlay disableable
T280180: TypeError: this.$overlay is undefined
T282686: Introduce PrefetchingTermsLookup to RdfBuilder->resolveMentionedEntities()
T282985: Show cached information on NewcomerTasksInfo special page
T283244: Implicit semicolon not kept during minification
T283331: Replace LBFactory with injecting new Db-Service in Client's BulkSubscriptionUpdater and UpdateSubscriptions maint script
T283340: Replace LBFactory with injecting new Db-Service in Client's EntityUsageTableBuilder
T283342: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's MatchingTermsLookupFactory and created classes: NameTableStore, DatabaseMatchingTermsLookup
T283343: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's PropertyInfoTable and places that construct it
T283348: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's TermInLangIdsResolverFactory
T283350: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's SqlSubscriptionLookup
T283418: Virtual keyboard appears after each suggestion on iPad Air 2020
T283606: Add a link: too many articles have no suggestions upon arrival
T283853: VE paste surface read by screenreader
T283867: Maintenance script for changing user settings
T283932: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's ChangePruner class and pruneChanges maint script
T283934: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Repo's WikibasePingback class
T283937: Replace ILBFactory with injecting new Db-Service in Repo's DispatchChangeDeletionNotificationJob
T283941: Replace ILBFactory with injecting new Db-Service in Repo's RebuildItemsPerSite maintenance script and associated class ItemsPerSiteBuilder
T284127: Make it possible to deploy welcomesurvey to % of users that's not divisible by 10
T284149: Deploy Growth features on Slovak Wikipedia
T284257: Align welcome survey treatment group with homepage treatment group
T284260: Add a link: desktop animations
T284312: Language variant inspector looks all messed up
T284496: Regression: Echo new talk page message banner has lost its orange background
T284560: Add message linking to project page for feedback
T284567: [regression] Reply tool padding and height broken
T284651: Replace LBFactory with injecting new Db-Service in SiteLinkTable
T284786: Automatic citation addition in VisualEditor has stopped working
T283194: Change User and User talk namespace name in tyv.wikipedia.org

Event Timeline

Hmm, that doesn't look good:

forrestbot.log.2021-06-05:2021-06-05 15:00:13,036 - forrestbot - DEBUG - <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698040>: skipping (SkipMailException('Project mediawiki/core\r is not being watched',))

Why on earth is there an \r there but not in many of the other changes?

In any case, should be relatively easy to fix. However need to figure out (a) whether other patches are affected, and (b) how to write a good test for this.

Change 699497 had a related patch set uploaded (by Merlijn van Deen; author: Merlijn van Deen):

[labs/tools/forrestbot@master] Add test & fixed for mixed CRLF/LF messages

https://gerrit.wikimedia.org/r/699497

For (b): found a source email with the same issue -- the email has mixed CRLF and LF newlines which explains why things got confused. Created test + fix (see above). Will deploy this first, and will then investigate what I can find on other situations where the \r may have caused issues.

Change 699497 merged by jenkins-bot:

[labs/tools/forrestbot@master] Add test & fixed for mixed CRLF/LF messages

https://gerrit.wikimedia.org/r/699497

Deployed and re-enabled bot. Looking into the logs now.

Quite a list -- https://forrestbot.toolforge.org/cr.txt . Let's see if we can filter this a bit.

List seems to be the following:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698513: merged in branch master, Task T219215, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SandboxLink/+/698066: merged in branch master, Task T276562, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/698250: merged in branch master, Task T284312, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/697432: merged in branch master, Task T274907, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698985: merged in branch master, Task T283937, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/697795: merged in branch master, Task T283331, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/698814: merged in branch master, Task T284567, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/699300: merged in branch master, Task T253077, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/697879: merged in branch master, Task T283606, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698503: merged in branch master, Task T283342, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698905: merged in branch master, Task T283932, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698616: merged in branch master, Task T283244, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698809: merged in branch master, Task T283941, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697673: merged in branch master, Task T253077, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/694587: merged in branch master, Task T283418, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/699158: merged in branch master, Task T284560, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698277: merged in branch master, Task T258766, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/698904: merged in branch master, Task T280051, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697840: merged in branch master, Task T283867, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/696588: merged in branch master, Task T282985, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697939: merged in branch master, Task T283348, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/697713: merged in branch master, Task T282686, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/697926: merged in branch master, Task T284149, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/689011: merged in branch master, Task T274881, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/699384: merged in branch master, Task T284786, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/698594: merged in branch master, Task T279557, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698040: merged in branch master, Task T283194, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698942: merged in branch master, Task T283343, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698810: merged in branch master, Task T283941, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/698053: merged in branch master, Task T284257, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/697922: merged in branch master, Task T284127, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/699050: merged in branch master, Task T284560, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/697835: merged in branch master, Task T283867, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/698249: merged in branch master, Task T284312, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/699041: merged in branch master, Task T284651, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/697877: merged in branch master, Task T279492, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/698752: merged in branch master, Task T274907, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698159: merged in branch master, Task T283350, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/685517: merged in branch master, Task T251348, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698516: merged in branch master, Task T258766, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/699283: merged in branch master, Task T280180, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/698059: merged in branch master, Task T284260, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/699042: merged in branch master, Task T283340, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698566: merged in branch master, Task T283342, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/698833: merged in branch master, Task T284496, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/698517: merged in branch master, Task T277862, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WebAuthn/+/692698: merged in branch master, Task T247710, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/698619: merged in branch master, Task T283853, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/698903: merged in branch master, Task T283934, needs slugs ['mw1.37.0-wmf.10']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/698681: merged in branch wmf/1.37.0-wmf.9, Task T284567, needs slugs ['mw1.37.0-wmf.9']
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/698848: merged in branch wmf/1.37.0-wmf.9, Task T284496, needs slugs ['mw1.37.0-wmf.9']

Process finished with exit code 0

which I'll fix by opening a gazillion tabs :-)

Decided to use a script after realizing the number of clicks required for the manual approach. Should all be sorted now :-)

Note that I may have missed changes before 6 jun (which is the oldest log file).

My hunch is that this was introduced either through a Gerrit upgrade or through the Mailman3 upgrade for mediawiki-commits. The latter happened before 1 jun, which suggests there's at least a week of missing release note tags :-(. @Ladsgroup may know a more specific date of the switchover for the mw-commits mailing list.

Looks like there is nothing left to do here, can this taks be resolved?

Note that I may have missed changes before 6 jun (which is the oldest log file).

My hunch is that this was introduced either through a Gerrit upgrade or through the Mailman3 upgrade for mediawiki-commits. The latter happened before 1 jun, which suggests there's at least a week of missing release note tags :-(. @Ladsgroup may know a more specific date of the switchover for the mw-commits mailing list.

I'm so sorry I missed the ping with this. According T280322: Upgrade mailing lists from mailman2 to 3 in batches the aforementioned mailing list was in group A and was migrated in May 3. HTH