Page MenuHomePhabricator
Create Task
Maniphest T258766

Remove IE <= 8 CSS hacks and workarounds in core, extensions and skins
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Jul 24 2020, 3:59 AM
Tags
Referenced Files
F32134902: Screenshot 2020-08-14 at 14.34.54.png
Aug 14 2020, 1:36 PM
F32134896: Screenshot 2020-08-14 at 14.34.29.png
Aug 14 2020, 1:36 PM
F32134072: Screen Shot 2020-08-14 at 1.51.37 PM.png
Aug 14 2020, 12:53 PM
F32134025: Screen Shot 2020-08-14 at 1.44.18 PM.png
Aug 14 2020, 12:50 PM
Subscribers
Aklapper
Ammarpad
BEANS-X2
Fomafix
Iniquity
Izno
Jdlrobson
View All 11 Subscribers
Tokens
"Like" token, awarded by Dinoguy1000."Like" token, awarded by BEANS-X2.

Description

With approval of RFC of removal of Internet Explorer 8 from basic browser support (“Grade C”) in T248061, it's time to get rid of all obsolete CSS hacks and fallbacks.

Acceptance criteria

  • The following references should be removed or updated

https://codesearch.wmcloud.org/deployed/?q=(IE%20%3F%5B5678%5D%7CInternet%20Explorer%20%5B5678%5D)&i=nope&files=(.*)%5C.(css%7Cless)%24&excludeFiles=&repos= or more generally
https://codesearch.wmcloud.org/deployed/?q=(%20IE%7CInternet%20Explorer%20%5B5678%5D)&i=nope&files=(.*)%5C.(css%7Cless)%24&excludeFiles=&repos=

Note

  • Ignore all MW core external libs, specifically jquery* ones
  • Ignore DonationInterface Adyen Gateway styles
  • Ignore Kartographer external libs
  • Ignore LiquidThreads as it's unmaintained software

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Jul 24 2020, 3:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2020, 3:59 AM
BEANS-X2 awarded a token.Jul 24 2020, 6:02 AM
BEANS-X2 subscribed.
Iniquity subscribed.Jul 24 2020, 10:05 AM
Dinoguy1000 awarded a token.Jul 24 2020, 6:27 PM
Aklapper added a subtask: T248061: RFC: Remove IE 8 from basic support.Jul 25 2020, 5:08 PM
Aklapper added projects: MediaWiki-extensions-General, MediaWiki-General.
Nirmos subscribed.Jul 26 2020, 6:05 AM
Volker_E closed subtask T248061: RFC: Remove IE 8 from basic support as Resolved.Jul 28 2020, 2:46 AM
gerritbot added a comment.Aug 13 2020, 1:24 AM

Change 619884 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Vector@master] skins.vector.styles: Remove PNG fallback and merge skins.vector.icons module

https://gerrit.wikimedia.org/r/619884

gerritbot added a project: Patch-For-Review.Aug 13 2020, 1:24 AM
Ammarpad subscribed.EditedAug 14 2020, 12:50 PM
LTRRTL (uselang=he)
Screen Shot 2020-08-14 at 1.51.37 PM.png (217×755 px, 31 KB)
Screen Shot 2020-08-14 at 1.44.18 PM.png (229×1 px, 33 KB)

See: http://patchdemo.wmflabs.org/wikis/Main_Page?useskinversion=2&uselang=he

Krinkle subscribed.EditedAug 14 2020, 1:36 PM
Chrome 84 latest stable (new patch, RTL/he)Firefox 79 latest stable (new patch, RTL/he)
Screenshot 2020-08-14 at 14.34.29.png (844×1 px, 108 KB)
Screenshot 2020-08-14 at 14.34.54.png (748×1 px, 92 KB)

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

Ammarpad added a comment.Aug 14 2020, 1:52 PM
In T258766#6385604, @Krinkle wrote:

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

Oh no, it's not working there too. I tested this on macOS with Chrome 80

Ammarpad added a comment.Aug 14 2020, 1:53 PM
In T258766#6385604, @Krinkle wrote:

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

Oh no, it's not working there too. I tested this on macOS with Chrome 80

gerritbot added a comment.Aug 18 2020, 11:51 AM

Change 619884 merged by jenkins-bot:
[mediawiki/skins/Vector@master] skins.vector.styles: Remove PNG fallback and merge skins.vector.icons module

https://gerrit.wikimedia.org/r/619884

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2020, 12:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 5:50 AM
Krinkle unsubscribed.Aug 27 2020, 8:28 PM
• nray closed subtask T261378: Remove IE8 CSS hacks and fallbacks in Vector as Resolved.Sep 15 2020, 12:45 AM
Volker_E updated the task description. (Show Details)Feb 24 2021, 10:00 PM
gerritbot added a comment.Feb 24 2021, 11:04 PM

Change 666606 had a related patch set uploaded (by VolkerE; owner: Jdrewniak):
[wikimedia/portals@master] Remove PNG fallback workflow for SVG sprites

https://gerrit.wikimedia.org/r/666606

gerritbot added a project: Patch-For-Review.Feb 24 2021, 11:04 PM
gerritbot added a comment.Feb 24 2021, 11:07 PM

Change 666606 merged by jenkins-bot:
[wikimedia/portals@master] Remove PNG fallback workflow for SVG sprites

https://gerrit.wikimedia.org/r/666606

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2021, 11:10 PM
gerritbot added a comment.Feb 24 2021, 11:34 PM

Change 666755 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] OOUIHTMLForm: Remove IE8 fallback code

https://gerrit.wikimedia.org/r/666755

gerritbot added a project: Patch-For-Review.Feb 24 2021, 11:34 PM
gerritbot added a comment.Mar 1 2021, 4:39 PM

Change 666755 merged by jenkins-bot:
[mediawiki/core@master] OOUIHTMLForm: Remove IE8 fallback code

https://gerrit.wikimedia.org/r/666755

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Mar 1 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 5:10 PM
SarthakKundra subscribed.Mar 11 2021, 1:09 PM

Are there still any work left on this issue?

gerritbot added a comment.Mar 24 2021, 10:52 AM

Change 674554 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Use localized interpunction for mediawiki.hlist

https://gerrit.wikimedia.org/r/674554

gerritbot added a project: Patch-For-Review.Mar 24 2021, 10:52 AM
Jdlrobson added projects: StructuredDiscussions, Maps (Kartographer), ContentTranslation, Notifications, Vector (legacy skin) (Tracking), MediaWiki-extensions-GuidedTour, JsonConfig, MachineVision, WikibaseMediaInfo, Timeless.Mar 24 2021, 6:48 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added projects: Growth-Team, Structured-Data-Backlog. · View Herald TranscriptMar 24 2021, 6:48 PM
Jdlrobson subscribed.Mar 24 2021, 6:49 PM

Per @SarthakKundra question I've updated the description and tagged some projects which still refer to IE8.

gerritbot added a comment.Mar 24 2021, 7:13 PM

Change 674554 merged by jenkins-bot:
[mediawiki/core@master] Use localized interpunction for mediawiki.hlist

https://gerrit.wikimedia.org/r/674554

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 24 2021, 8:00 PM
Izno subscribed.EditedMar 25 2021, 2:13 AM

There are some interesting mentions of older versions that should maybe also be trimmed in what versions they reference or the associated CSS removed so that naive searches like the one added to the description catch what you want to catch (notably, several "IE (N<9) - 9" types).

Jdlrobson renamed this task from Remove IE8 CSS hacks and workarounds in core, extensions and skins to Remove IE <= 8 CSS hacks and workarounds in core, extensions and skins.Mar 25 2021, 5:35 PM
Jdlrobson updated the task description. (Show Details)
CBogen moved this task from Triage to Tracking on the Structured-Data-Backlog board.Mar 30 2021, 3:11 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
• Nikerabbit moved this task from Needs Triage to Enhancements on the ContentTranslation board.Jun 7 2021, 11:37 AM
• Nikerabbit added a project: Language-Team (Language-2021-April-June).
gerritbot added a comment.Jun 7 2021, 2:04 PM

Change 698516 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/698516

gerritbot added a comment.Jun 7 2021, 2:16 PM

Change 698520 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Remove IE8 workaround hack

https://gerrit.wikimedia.org/r/698520

gerritbot added a comment.Jun 7 2021, 6:29 PM

Change 698277 had a related patch set uploaded (by Bartosz Dziewoński; author: Fomafix):

[mediawiki/core@master] Remove workarounds for IE8 from TOC style

https://gerrit.wikimedia.org/r/698277

gerritbot added a comment.Jun 7 2021, 6:50 PM

Change 698277 merged by jenkins-bot:

[mediawiki/core@master] Remove workarounds for IE8 from TOC style

https://gerrit.wikimedia.org/r/698277

gerritbot added a comment.Jun 7 2021, 6:54 PM

Change 698520 abandoned by VolkerE:

[mediawiki/core@master] Remove IE8 workaround hack

Reason:

Ie68e9dae441fe1dab57026c451d198c4ba332702 was already available before and got preference.

https://gerrit.wikimedia.org/r/698520

gerritbot added a comment.Jun 7 2021, 7:18 PM

Change 698516 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/698516

Fomafix subscribed.Jun 7 2021, 7:37 PM
valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM
gerritbot added a comment.Jun 21 2021, 12:21 PM

Change 700594 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GuidedTour@master] Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/700594

gerritbot added a comment.Jun 21 2021, 2:20 PM

Change 700594 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/700594

phuedx mentioned this in rEGTObaa4bfa2a448: Remove IE8 workaround code fragments.Jun 21 2021, 2:20 PM
Volker_E updated the task description. (Show Details)Jun 21 2021, 7:04 PM
gerritbot added a comment.Jun 21 2021, 8:29 PM

Change 700693 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Restructure enabled and :disabled styles & remove IE specific comments

https://gerrit.wikimedia.org/r/700693

ReaperDawn subscribed.Jun 23 2021, 5:13 PM
gerritbot added a comment.Jun 28 2021, 4:22 PM

Change 700693 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Restructure enabled and :disabled styles & remove IE specific comments

https://gerrit.wikimedia.org/r/700693

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 28 2021, 5:00 PM
Volker_E added a subtask: T286296: Update 'normalize.css' dependency to latest (v8.0.1).Jul 7 2021, 5:17 PM
Volker_E closed subtask T286296: Update 'normalize.css' dependency to latest (v8.0.1) as Resolved.Jul 8 2021, 12:06 PM
Pginer-WMF edited projects, added Language-Team (Language-2021-July-September); removed Language-Team (Language-2021-April-June).Jul 12 2021, 3:27 PM
gerritbot added a comment.Jul 18 2021, 6:03 PM

Change 705190 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] content.media/content.thumbnails: Remove obsolete PNG fallbacks

https://gerrit.wikimedia.org/r/705190

gerritbot added a comment.Jul 20 2021, 7:22 PM

Change 705190 merged by jenkins-bot:

[mediawiki/core@master] content.media/content.thumbnails: Remove obsolete PNG fallbacks

https://gerrit.wikimedia.org/r/705190

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.16; 2021-07-26); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 20 2021, 8:00 PM
Volker_E updated the task description. (Show Details)Aug 3 2021, 4:17 AM
gerritbot added a comment.Sep 11 2021, 8:04 AM

Change 720422 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Flow@master] Remove obsolete IE specific code & comments

https://gerrit.wikimedia.org/r/720422

gerritbot added a comment.Sep 13 2021, 8:34 PM

Change 720422 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove obsolete IE specific code & comments

https://gerrit.wikimedia.org/r/720422

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Sep 13 2021, 9:00 PM
gerritbot added a comment.Sep 13 2021, 10:13 PM

Change 720821 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] Remove obsolete code for non-supported browsers

https://gerrit.wikimedia.org/r/720821

gerritbot added a comment.Sep 13 2021, 10:46 PM

Change 720821 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove obsolete code for non-supported browsers

https://gerrit.wikimedia.org/r/720821

Volker_E updated the task description. (Show Details)Sep 13 2021, 11:44 PM
Volker_E closed this task as Resolved.Sep 13 2021, 11:47 PM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.

Alright, all code that was directly aiming for IE 8 and lower has been removed from Wikimedia deployed products (with the exceptions stated in task description). 🎉

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits