Page MenuHomePhabricator

Remove IE <= 8 CSS hacks and workarounds in core, extensions and skins
Closed, ResolvedPublic

Description

With approval of RFC of removal of Internet Explorer 8 from basic browser support (“Grade C”) in T248061, it's time to get rid of all obsolete CSS hacks and fallbacks.

Acceptance criteria

  • The following references should be removed or updated

https://codesearch.wmcloud.org/deployed/?q=(IE%20%3F%5B5678%5D%7CInternet%20Explorer%20%5B5678%5D)&i=nope&files=(.*)%5C.(css%7Cless)%24&excludeFiles=&repos= or more generally
https://codesearch.wmcloud.org/deployed/?q=(%20IE%7CInternet%20Explorer%20%5B5678%5D)&i=nope&files=(.*)%5C.(css%7Cless)%24&excludeFiles=&repos=

Note

  • Ignore all MW core external libs, specifically jquery* ones
  • Ignore DonationInterface Adyen Gateway styles
  • Ignore Kartographer external libs
  • Ignore LiquidThreads as it's unmaintained software

Event Timeline

Change 619884 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Vector@master] skins.vector.styles: Remove PNG fallback and merge skins.vector.icons module

https://gerrit.wikimedia.org/r/619884

Chrome 84 latest stable (new patch, RTL/he)Firefox 79 latest stable (new patch, RTL/he)
Screenshot 2020-08-14 at 14.34.29.png (844×1 px, 108 KB)
Screenshot 2020-08-14 at 14.34.54.png (748×1 px, 92 KB)

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

Oh no, it's not working there too. I tested this on macOS with Chrome 80

@Ammarpad Is this working fine for you before this patch? e.g. at https://fr.wikipedia.org/?uselang=he&useskinversion=2

Which operating system and version?

Oh no, it's not working there too. I tested this on macOS with Chrome 80

Change 619884 merged by jenkins-bot:
[mediawiki/skins/Vector@master] skins.vector.styles: Remove PNG fallback and merge skins.vector.icons module

https://gerrit.wikimedia.org/r/619884

Change 666606 had a related patch set uploaded (by VolkerE; owner: Jdrewniak):
[wikimedia/portals@master] Remove PNG fallback workflow for SVG sprites

https://gerrit.wikimedia.org/r/666606

Change 666606 merged by jenkins-bot:
[wikimedia/portals@master] Remove PNG fallback workflow for SVG sprites

https://gerrit.wikimedia.org/r/666606

Change 666755 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] OOUIHTMLForm: Remove IE8 fallback code

https://gerrit.wikimedia.org/r/666755

Change 666755 merged by jenkins-bot:
[mediawiki/core@master] OOUIHTMLForm: Remove IE8 fallback code

https://gerrit.wikimedia.org/r/666755

Are there still any work left on this issue?

Change 674554 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Use localized interpunction for mediawiki.hlist

https://gerrit.wikimedia.org/r/674554

Per @SarthakKundra question I've updated the description and tagged some projects which still refer to IE8.

Change 674554 merged by jenkins-bot:
[mediawiki/core@master] Use localized interpunction for mediawiki.hlist

https://gerrit.wikimedia.org/r/674554

There are some interesting mentions of older versions that should maybe also be trimmed in what versions they reference or the associated CSS removed so that naive searches like the one added to the description catch what you want to catch (notably, several "IE (N<9) - 9" types).

Jdlrobson renamed this task from Remove IE8 CSS hacks and workarounds in core, extensions and skins to Remove IE <= 8 CSS hacks and workarounds in core, extensions and skins.Mar 25 2021, 5:35 PM
Jdlrobson updated the task description. (Show Details)

Change 698516 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/698516

Change 698520 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Remove IE8 workaround hack

https://gerrit.wikimedia.org/r/698520

Change 698277 had a related patch set uploaded (by Bartosz Dziewoński; author: Fomafix):

[mediawiki/core@master] Remove workarounds for IE8 from TOC style

https://gerrit.wikimedia.org/r/698277

Change 698277 merged by jenkins-bot:

[mediawiki/core@master] Remove workarounds for IE8 from TOC style

https://gerrit.wikimedia.org/r/698277

Change 698520 abandoned by VolkerE:

[mediawiki/core@master] Remove IE8 workaround hack

Reason:

Ie68e9dae441fe1dab57026c451d198c4ba332702 was already available before and got preference.

https://gerrit.wikimedia.org/r/698520

Change 698516 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/698516

Change 700594 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GuidedTour@master] Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/700594

Change 700594 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Remove IE8 workaround code fragments

https://gerrit.wikimedia.org/r/700594

Change 700693 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Restructure enabled and :disabled styles & remove IE specific comments

https://gerrit.wikimedia.org/r/700693

Change 700693 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Restructure enabled and :disabled styles & remove IE specific comments

https://gerrit.wikimedia.org/r/700693

Change 705190 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] content.media/content.thumbnails: Remove obsolete PNG fallbacks

https://gerrit.wikimedia.org/r/705190

Change 705190 merged by jenkins-bot:

[mediawiki/core@master] content.media/content.thumbnails: Remove obsolete PNG fallbacks

https://gerrit.wikimedia.org/r/705190

Change 720422 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Flow@master] Remove obsolete IE specific code & comments

https://gerrit.wikimedia.org/r/720422

Change 720422 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Remove obsolete IE specific code & comments

https://gerrit.wikimedia.org/r/720422

Change 720821 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] Remove obsolete code for non-supported browsers

https://gerrit.wikimedia.org/r/720821

Change 720821 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove obsolete code for non-supported browsers

https://gerrit.wikimedia.org/r/720821

Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.

Alright, all code that was directly aiming for IE 8 and lower has been removed from Wikimedia deployed products (with the exceptions stated in task description). 🎉