Page MenuHomePhabricator
Create Task
Maniphest T274907

Change template search in TemplateWizard to use standard search API
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Same as T274903, but for the MediaWiki-extensions-TemplateWizard.

Note this would need a separate feature flag in case we want to hide it.

Implementation:

  • take over search adjustments from 667641
  • adapt variables according to 686436
  • create a new config variable for this extension (e.g. TemplateWizardTemplateSearchImprovements)
  • add * to template search term like in 689070
  • show redirects as part of description in template search 692930 in a separate patch
  • add the "exact match" feature in a separate patch, just as in 693157
  • add tests (like in 667641 )

[WIP] Patch: 697432

Details

SubjectRepoBranchLines +/-
Fix TemplateData API not properly working with a generatormediawiki/extensions/TemplateDatamaster+1 -0
Restore original template search result ordermediawiki/extensions/TemplateWizardmaster+14 -3
Fix order template title → redirect → descriptionmediawiki/extensions/TemplateWizardmaster+1 -1
[POC] Retain result order when using an API as a generatormediawiki/coremaster+11 -3
Display redirects when searching for templatesmediawiki/extensions/TemplateWizardmaster+34 -3
Guarantee exact match when searching for a templatemediawiki/extensions/TemplateWizardmaster+156 -2
Change template search in TemplateWizard to use standard search APImediawiki/extensions/TemplateWizardmaster+143 -3
Remove unused "templateSearchImprovements" fieldmediawiki/extensions/TemplateWizardmaster+6 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Feb 16 2021, 4:42 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 16 2021, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde added a parent task: T271802: Better search - "wildcard word" rather than "title prefix" search, for template search dialogs (Template findability).Feb 16 2021, 4:43 PM
thiemowmde mentioned this in T274903: Change template search in VisualEditor to use standard search API.Feb 16 2021, 4:55 PM
thiemowmde updated the task description. (Show Details)
Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Feb 17 2021, 8:51 AM
Lena_WMDE updated the task description. (Show Details)Feb 17 2021, 2:12 PM
gerritbot added a comment.May 19 2021, 4:54 PM

Change 692930 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [WIP] Show redirects as part of description in template search

https://gerrit.wikimedia.org/r/692930

gerritbot added a project: Patch-For-Review.May 19 2021, 4:54 PM
gerritbot added a comment.May 20 2021, 1:06 PM

Change 693157 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Guarantee exact match when searching for a template

https://gerrit.wikimedia.org/r/693157

gerritbot added a comment.May 21 2021, 9:51 AM

Change 693379 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move exact matches to the top in template search

https://gerrit.wikimedia.org/r/693379

Lena_WMDE edited projects, added WMDE-TechWish-Sprint-2021-05-26; removed WMDE-TechWish.May 26 2021, 8:13 AM
Lena_WMDE set the point value for this task to 3.
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.May 26 2021, 8:26 AM
awight subscribed.EditedMay 27 2021, 11:36 AM

VE patches seem to be attached to the wrong task.

lilients_WMDE subscribed.May 28 2021, 2:11 PM
In T274907#7118992, @awight wrote:

VE patches seem to be attached to the wrong task.

I fixed that and moved them to T274903.

lilients_WMDE updated the task description. (Show Details)May 28 2021, 2:16 PM
lilients_WMDE claimed this task.May 31 2021, 8:52 AM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-05-26 board.
lilients_WMDE updated the task description. (Show Details)May 31 2021, 3:03 PM
gerritbot added a comment.May 31 2021, 3:21 PM

Change 697432 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/TemplateWizard@master] [WIP] Change template search in TemplateWizard to use standard search API

https://gerrit.wikimedia.org/r/697432

lilients_WMDE updated the task description. (Show Details)Jun 1 2021, 1:25 PM
lilients_WMDE updated the task description. (Show Details)Jun 1 2021, 1:27 PM
lilients_WMDE updated the task description. (Show Details)Jun 1 2021, 2:05 PM
lilients_WMDE updated the task description. (Show Details)Jun 1 2021, 2:46 PM
lilients_WMDE updated the task description. (Show Details)Jun 7 2021, 8:48 AM
gerritbot added a comment.Jun 7 2021, 10:45 AM

Change 698475 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] [WIP] Guarantee exact match when searching for a template

https://gerrit.wikimedia.org/r/698475

lilients_WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-05-26 board.Jun 7 2021, 1:48 PM
gerritbot added a comment.Jun 7 2021, 4:48 PM

Change 698571 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Display redirects when searching for templates

https://gerrit.wikimedia.org/r/698571

gerritbot added a comment.Jun 7 2021, 5:13 PM

Change 697432 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Change template search in TemplateWizard to use standard search API

https://gerrit.wikimedia.org/r/697432

gerritbot added a comment.Jun 8 2021, 10:36 AM

Change 698752 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Remove unused "templateSearchImprovements" field

https://gerrit.wikimedia.org/r/698752

Lena_WMDE mentioned this in T284553: Deploy template search improvements, back button+warning message, and delete button to small set of wikis.Jun 8 2021, 11:11 AM
gerritbot added a comment.Jun 8 2021, 11:15 AM

Change 698752 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Remove unused "templateSearchImprovements" field

https://gerrit.wikimedia.org/r/698752

gerritbot added a comment.Jun 9 2021, 9:09 AM

Change 698475 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Guarantee exact match when searching for a template

https://gerrit.wikimedia.org/r/698475

gerritbot added a comment.Jun 9 2021, 9:31 AM

Change 698571 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Display redirects when searching for templates

https://gerrit.wikimedia.org/r/698571

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 9 2021, 10:00 AM
lilients_WMDE removed lilients_WMDE as the assignee of this task.Jun 9 2021, 11:12 AM
lilients_WMDE updated the task description. (Show Details)
lilients_WMDE moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-05-26 board.
Lena_WMDE changed the point value for this task from 3 to 1.Jun 9 2021, 11:29 AM
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-06-09.

Needs to be backported.

WMDE-Fisch subscribed.Jun 9 2021, 1:40 PM
  • show redirects as part of description in template search 692930 in a separate patch

seems to be not working at the moment, he notice in the search results is missing. See:

TWizardRedirect.png (609×704 px, 27 KB)

thiemowmde added a comment.Jun 9 2021, 3:53 PM

I did a quick test: https://simple.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=templatedata&format=json&includeMissingTitles=1&lang=en&generator=search&redirects=1&gsrsearch=citeweb&gsrnamespace=10&gsrlimit=1&gsrprop=redirecttitle. It looks like the "redirecttitle" we need gets lost when the "search" API is used as a "generator". This might be a bug in core, or just something it can't do.

The redirects are there when using prefixsearch, but in another format: https://simple.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=templatedata&format=json&includeMissingTitles=1&lang=en&generator=prefixsearch&redirects=1&gpssearch=citeweb&gpsnamespace=10&gpslimit=1

One partial fix is to use the redirect information from the 2nd exact match query and retroactively add the information to the results of the 1st query. This will at least fix what we can see in the screenshot.

I will look into the "generator" code tomorrow.

thiemowmde added a comment.Jun 10 2021, 8:28 AM

I also noticed that the order is different from the order in VisualEditor. The reason is the same: When search is used as a generator, the result appears to be ordered by page ID. The original order by relevance is lost.

gerritbot added a comment.Jun 10 2021, 10:21 AM

Change 699160 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Fix order template title → redirect → description

https://gerrit.wikimedia.org/r/699160

gerritbot added a comment.Jun 10 2021, 12:52 PM

Change 699203 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateData@master] Fix TemplateData API not properly working with a generator

https://gerrit.wikimedia.org/r/699203

gerritbot added a comment.Jun 10 2021, 1:36 PM

Change 699211 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] [POC] Retain result order when using an API as a generator

https://gerrit.wikimedia.org/r/699211

thiemowmde added a comment.Jun 10 2021, 1:51 PM

I found where the order gets lost: In \ApiPageSet::initFromTitles() somewhere at line #945 is the actual database SELECT executed. It contains a WHERE with all the page titles listed. The titles are still in the correct order in the WHERE clause. But MySQL doesn't care about this. There is no ORDER BY. The results are ordered in whatever order MySQL feels like.

To fix this we either need to force the SELECT to retain the specific order (a proof of concept for this is in https://gerrit.wikimedia.org/r/699211), or restore the order after the SELECT was executed.

This really is a core bug. Not sure how to tag this.

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
thiemowmde claimed this task.Jun 14 2021, 7:06 AM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-06-09 board.
gerritbot added a comment.Jun 14 2021, 3:10 PM

Change 699767 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Restore original template search result order

https://gerrit.wikimedia.org/r/699767

gerritbot added a comment.Jun 14 2021, 3:11 PM

Change 699211 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/core@master] [POC] Retain result order when using an API as a generator

Reason:

Not needed, see Ic7eabcf.

https://gerrit.wikimedia.org/r/699211

thiemowmde moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 14 2021, 3:13 PM

Turned out to be easier than expected: The patch https://gerrit.wikimedia.org/r/699203 will not only make redirect information available. There is also an "index" field. We can use this to restore the original search result order, done via https://gerrit.wikimedia.org/r/699767.

thiemowmde added a subtask: T284890: TemplateWizard: Design fixups for template search.Jun 16 2021, 10:12 AM
thiemowmde mentioned this in T284890: TemplateWizard: Design fixups for template search.Jun 16 2021, 10:15 AM
gerritbot added a comment.Jun 17 2021, 7:16 AM

Change 699160 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Fix order template title → redirect → description

https://gerrit.wikimedia.org/r/699160

gerritbot added a comment.Jun 17 2021, 7:42 AM

Change 699203 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Fix TemplateData API not properly working with a generator

https://gerrit.wikimedia.org/r/699203

gerritbot added a comment.Jun 17 2021, 7:42 AM

Change 699767 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Restore original template search result order

https://gerrit.wikimedia.org/r/699767

WMDE-Fisch moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 17 2021, 8:33 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 22 2021, 8:38 AM
WMDE-Fisch closed this task as Resolved.Jun 29 2021, 1:07 PM
WMDE-Fisch closed subtask T284890: TemplateWizard: Design fixups for template search as Resolved.
Lena_WMDE mentioned this in T286990: Deploy template search improvements, back button+warning message, and delete button to all wikis (except enwiki).Jul 20 2021, 9:09 AM
thiemowmde mentioned this in T257738: Allow TemplateWizard to search template descriptions.Jan 17 2022, 2:42 PM
Aklapper added a parent task: T257738: Allow TemplateWizard to search template descriptions.Jan 17 2022, 6:47 PM
thiemowmde mentioned this in T257960: Allow TemplateData search to search template descriptions.Jan 20 2022, 10:07 AM
Lena_WMDE mentioned this in T303802: Deploy template search improvements to enwiki.Mar 15 2022, 10:22 AM
FrozenPlum mentioned this in T257773: Enabling Title Key breaks prefixsearch via Special:ApiSandbox.Oct 7 2023, 4:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL