Page MenuHomePhabricator
Create Task
Maniphest T283348

Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's TermInLangIdsResolverFactory
Closed, ResolvedPublic
Actions

Description

This includes refactoring things so that DatabaseTermInLangIdsResolver is only constructed in that factory and injected everywhere else, either by using the factory or by using the service.

IMPORTANT: This will load different databases based on the entity type on commons. That happens for example in entitytypes PREFETCHING_TERM_LOOKUP_CALLBACK. We might need something like a newForEntityType( string $type ) on the repo factory.

Details

SubjectRepoBranchLines +/-
Use DomainDb in terms servicesmediawiki/extensions/Wikibasemaster+292 -252
ConnectionManager: add optional $flags parammediawiki/coremaster+41 -14
ReplicationWaiter: add optional timeout parammediawiki/extensions/Wikibasemaster+35 -4
client: add RepoDomainDbFactory servicemediawiki/extensions/Wikibasemaster+62 -0
Add DomainDb::loadBalancer and DomainDb::domainmediawiki/extensions/Wikibasemaster+37 -4
Add RepoDomainDbFactory::newForEntityTypemediawiki/extensions/Wikibasemaster+63 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.May 21 2021, 12:29 PM
Michael removed a project: [DEPRECATED] wdwb-tech.May 21 2021, 3:34 PM
Michael moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 25 2021, 9:51 AM
Michael updated the task description. (Show Details)May 28 2021, 11:14 AM
Jakob_WMDE claimed this task.Jun 2 2021, 12:41 PM
Jakob_WMDE moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jun 2 2021, 2:52 PM

Change 697581 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Add RepoDomainDbFactory::newForEntityType

https://gerrit.wikimedia.org/r/697581

gerritbot added a project: Patch-For-Review.Jun 2 2021, 2:52 PM
gerritbot added a comment.Jun 2 2021, 3:16 PM

Change 697798 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] client: add RepoDomainDbFactory service

https://gerrit.wikimedia.org/r/697798

gerritbot added a comment.Jun 2 2021, 3:36 PM

Change 697801 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Add DomainDb::loadBalancer and DomainDb::domain

https://gerrit.wikimedia.org/r/697801

gerritbot added a comment.Jun 3 2021, 10:08 AM

Change 697581 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add RepoDomainDbFactory::newForEntityType

https://gerrit.wikimedia.org/r/697581

gerritbot added a comment.Jun 3 2021, 10:08 AM

Change 697798 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: add RepoDomainDbFactory service

https://gerrit.wikimedia.org/r/697798

gerritbot added a comment.Jun 3 2021, 10:08 AM

Change 697801 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add DomainDb::loadBalancer and DomainDb::domain

https://gerrit.wikimedia.org/r/697801

gerritbot added a comment.Jun 3 2021, 11:25 AM

Change 697939 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/core@master] ConnectionManager: add optional $flags param

https://gerrit.wikimedia.org/r/697939

gerritbot added a comment.Jun 3 2021, 12:45 PM

Change 697949 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] ReplicationWaiter: add optional timeout param

https://gerrit.wikimedia.org/r/697949

gerritbot added a comment.Jun 3 2021, 3:14 PM

Change 697949 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ReplicationWaiter: add optional timeout param

https://gerrit.wikimedia.org/r/697949

gerritbot added a comment.Jun 3 2021, 4:24 PM

Change 698001 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Use DomainDb in terms services

https://gerrit.wikimedia.org/r/698001

Jakob_WMDE moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 7 2021, 1:07 PM
gerritbot added a comment.Jun 7 2021, 4:10 PM

Change 697939 merged by jenkins-bot:

[mediawiki/core@master] ConnectionManager: add optional $flags param

https://gerrit.wikimedia.org/r/697939

gerritbot added a comment.Jun 7 2021, 4:14 PM

Change 698001 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use DomainDb in terms services

https://gerrit.wikimedia.org/r/698001

Michael mentioned this in T283349: Replace ILBFactory and ILoadBalancer with injecting new Db-Service in Lib's DatabaseTermInLangIdsAcquirer and ReplicaMasterAwareRecordIdsAcquirer.Jun 8 2021, 10:56 AM
Michael closed this task as Resolved.Jun 11 2021, 7:48 PM
Michael removed a project: Patch-For-Review.

There is no good reason for this idling unresolved in the "Done" column. It is done.

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits