Page MenuHomePhabricator

Watchlist Expiry: Implement UI for VisualEditor [Large]
Closed, ResolvedPublic

Description

As a Watchlist Expiry user, I want the ability to temporarily watch pages with VE, so that I can use the feature via a common editor process.

Resources:

Background: We have currently focused on implementing the watchlist expiry feature for source editing (see T248494). We will now implement this functionality for VisualEditor. Like source editing, the user has seen the drop-down. Note that this work is dependent upon T248514 being completed first.

Acceptance Criteria:

  • In VisualEditor, add the following:
    • A drop-down to the right of label (inactive by default, before box checked)
      • The dropdown has an accessibility label available to screen reader software: "Watchlist time period:" (but no visible label)
  • When user checks the box to "Watch this page," the drop-down should become active
  • The user should be able to select watch period via drop-down
    • The drop-down has the following options:
      • Permanently (as default)
      • for 1 week
      • for 1 month
      • for 3 months
      • for 6 months
  • If the page has already been watched, the behavior should be as follows:
    • Drop-down should have days left as pre-selected option at top
    • The selection should be written as follows: "X days left" (for example, "10 days left" or "20 days left").
  • If the page has already been watched with a selected temporary time period, and the user clicks "Publish" without changing the time period selection, no changes to the watch period should be made.
  • The watch period should be saved or updated, if the user makes a new time period selection.
  • The watch star should reflect the new watch state and expiry.

Visual Example:

Screenshot 2020-02-06 at 11.13.13 PM.png (662×1 px, 126 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ifried renamed this task from Watchlist Expiry: Support for VisualEditor to Watchlist Expiry: Implement UI for VisualEditor.Apr 28 2020, 9:28 PM
ARamirez_WMF renamed this task from Watchlist Expiry: Implement UI for VisualEditor to Watchlist Expiry: Implement UI for VisualEditor [Large].Apr 28 2020, 11:39 PM

This would be a large amount of work for the team, and it is beyond scope for this project. We have other work to do (both related to Watchlist Expiry and other wishes), so we cannot implement Watchlist Expiry support for VE at this time. Meanwhile, the user will have multiple other ways to watch temporarily (via star, legacy source editor, and action=watch) upon release of the feature. However, if we hear strong and persistent interest in such work, we may re-evaluate this idea at a later date. For now, I'm closing this ticket, so we are clear about the current scope of the project. Thanks!

Upon thinking about this further, there's a chance another team may be able to take this on in the future, so I'll leave this ticket open & remove the Community-Tech tag. Thanks!

@ifried If editing a temporarily watched page with VE, if "Watch this page" is checked when saving, what is the expected behaviour?

I am assuming it should remain temporarily watched with the same expiry.

Given the space we reserve for the character counter (which isn't always shown), there is not room for all these messages in English. I imagine it could be worse in other languages, so any design will have to allow for these controls on multiple lines:

image.png (61×480 px, 6 KB)

German:

image.png (79×467 px, 7 KB)

Change 685517 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Support watchist expiry

https://gerrit.wikimedia.org/r/685517

Change 685517 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Support watchlist expiry

https://gerrit.wikimedia.org/r/685517

matmarex edited projects, added Editing QA; removed Patch-For-Review.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
Ryasmeen subscribed.

Everything looks good except the drop down for Watchlist time period stays enabled even when the "Watch this page" checkbox is un-checked. Also, I am not seeing any new label "Watchlist time period:" to the right of watchlist checkbox.

Change 705973 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Toggle the watchlist-expiry dropdown's disabled state

https://gerrit.wikimedia.org/r/705973

Everything looks good except the drop down for Watchlist time period stays enabled even when the "Watch this page" checkbox is un-checked.

Will be fixed by the patch above.

Also, I am not seeing any new label "Watchlist time period:" to the right of watchlist checkbox.

I think this is expected – the normal wikitext editor interface doesn't display one, either. I'll update the acceptance criteria.


I also noticed another issue while testing my patch for the above – after choosing to watch the page temporarily and saving the edit, the watch star on Vector is always displayed filled-in, although it should be half-filled-in. I'll submit a fix for this too.

Change 705976 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Set watch star to half-filled when temp. watched by any interface

https://gerrit.wikimedia.org/r/705976

Change 705976 merged by jenkins-bot:

[mediawiki/core@master] Set watch star to half-filled when temp. watched by any interface

https://gerrit.wikimedia.org/r/705976

Change 722399 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/core@REL1_37] Set watch star to half-filled when temp. watched by any interface

https://gerrit.wikimedia.org/r/722399

Change 722399 merged by jenkins-bot:

[mediawiki/core@REL1_37] Set watch star to half-filled when temp. watched by any interface

https://gerrit.wikimedia.org/r/722399

Change 705973 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Toggle the watchlist-expiry dropdown's disabled state

https://gerrit.wikimedia.org/r/705973

Change 722463 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@REL1_37] Toggle the watchlist-expiry dropdown's disabled state

https://gerrit.wikimedia.org/r/722463

Change 722463 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@REL1_37] Toggle the watchlist-expiry dropdown's disabled state

https://gerrit.wikimedia.org/r/722463