Maniphest T283340

Replace LBFactory with injecting new Db-Service in Client's EntityUsageTableBuilder
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 21 2021, 10:26 AM

Tags

Referenced Files

None

Subscribers

Description

Mostly a fairly standard usage with the exception of the \Wikimedia\Rdbms\ILBFactory::getLocalDomainID call below:

$this->lbFactory->waitForReplication( [
	'domain' => $this->lbFactory->getLocalDomainID(),
] );

$loadBalancer = $this->lbFactory->getMainLB();
$db = $loadBalancer->getConnection( DB_MASTER );

Details

	Subject	Repo	Branch	Lines +/-
	Replace ILBFactory with ClientDomainDb	mediawiki/extensions/Wikibase	master	+22 -19
	Typehint files to be modified	mediawiki/extensions/Wikibase	master	+35 -60

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T281453 Abstract database connections between Client and Repository
		Resolved		Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
		Resolved		ItamarWMDE	T283340 Replace LBFactory with injecting new Db-Service in Client's EntityUsageTableBuilder

Event Timeline

Michael created this task.May 21 2021, 10:26 AM

Michael mentioned this in T283245: Create database connection service abstraction.

Michael removed a project: [DEPRECATED] wdwb-tech.May 21 2021, 3:35 PM

Michael moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 25 2021, 9:52 AM

Michael moved this task from Stalled/Waiting to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 8 2021, 11:00 AM

ItamarWMDE claimed this task.Jun 9 2021, 1:28 PM

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 699042 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Typehint files to be modified

https://gerrit.wikimedia.org/r/699042

Change 699043 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with ClientDomainDb

https://gerrit.wikimedia.org/r/699043

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 9 2021, 4:31 PM

Change 699042 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Typehint files to be modified

https://gerrit.wikimedia.org/r/699042

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM

Change 699043 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with ClientDomainDb

https://gerrit.wikimedia.org/r/699043

ItamarWMDE closed this task as Resolved.Jun 14 2021, 10:21 AM

ItamarWMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2021, 11:10 AM