Maniphest T283937

Replace ILBFactory with injecting new Db-Service in Repo's DispatchChangeDeletionNotificationJob
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	May 28 2021, 1:42 PM

Tags

Referenced Files

None

Subscribers

Description

This class uses ILBFactory only for a single call and should be very quick to replace:

$dbr = $this->loadBalancerFactory
			->getMainLB()
			->getConnectionRef( DB_REPLICA );

Details

	Subject	Repo	Branch	Lines +/-
	Replace ILBFactory with RepoDomainDb	mediawiki/extensions/Wikibase	master	+11 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T281453 Abstract database connections between Client and Repository
		Resolved		Addshore	T283246 Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used
		Resolved		ItamarWMDE	T283937 Replace ILBFactory with injecting new Db-Service in Repo's DispatchChangeDeletionNotificationJob

Event Timeline

Michael created this task.May 28 2021, 1:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2021, 1:42 PM

Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 8 2021, 11:03 AM

ItamarWMDE claimed this task.Jun 8 2021, 3:44 PM

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 698985 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with RepoDomainDb

https://gerrit.wikimedia.org/r/698985

gerritbot added a project: Patch-For-Review.Jun 9 2021, 1:26 PM

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 9 2021, 1:28 PM

Change 698985 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace ILBFactory with RepoDomainDb

https://gerrit.wikimedia.org/r/698985

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2021, 6:10 PM

Looks like this is completed / merged, moving it to test verification.

• toan moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 10 2021, 7:52 AM

Ladsgroup closed this task as Resolved.Jun 11 2021, 9:29 AM

Ladsgroup moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

valhallasw mentioned this in T284587: ReleaseTaggerBot skipping some Tasks/Patches?.Jun 12 2021, 8:03 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 12 2021, 8:11 PM