Page MenuHomePhabricator

Virtual keyboard appears after each suggestion on iPad Air 2020
Closed, ResolvedPublic

Description

When trying out the Add a link feature on my iPad Air, the virtual keyboard keeped appearing after each reviewed suggestion, making the experience quite a bit annoying.

Details
  • Screencast
  • Device: iPad Air 2020
  • Browser: Safari
  • User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

That sounds a lot like T281771: Prevent contenteditabe like experiences (cursor placement; menu selection for cutting text) in AddLinkArticleTarget (cc @mewoph), the patch we ended up with there only adjusted the mobile toolbar dialog but it should probably also apply to the desktop one.

mewoph moved this task from Backlog to May 24 – May 28 on the Add-Link board.
mewoph edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
mewoph moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.

iPadOS has desktop user agent so desktop site will be loaded by default. When the same changes from mobile are applied, a few odd issues came up:

IMG_1551.PNG (1×2 px, 512 KB)

  1. The font size of the article text is increased to 24px (from 14px). The font sizes on the annotation views are inconsistent. Oddly the computed style on the paragraph node has the same calculation (0.875 * 1em).
  2. When navigating between annotations, the focus state remains on the previous button that was clicked.
kostajh triaged this task as Medium priority.May 25 2021, 1:07 PM

Change 694587 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Prevent virtual keyboard from showing up when desktop site is loaded on tablet

https://gerrit.wikimedia.org/r/694587

Change 694587 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Prevent virtual keyboard from showing up when desktop site is loaded on tablet

https://gerrit.wikimedia.org/r/694587

Etonkovidova added a subscriber: Etonkovidova.

Checked on testwiki wmf.15 on iPad (8th generation) (iOS14.6) - the issue with the keyboard is fixed.