Page MenuHomePhabricator

Reduce duplication between jQuery/OOUI and Vue versions of the display
Open, MediumPublic6 Estimated Story Points

Description

In preparation for T274599: Allow uncollapsing grouped results we should clean up existing code to make sure we have as little duplication as possible. That task should only need to add the core functionality once, with only the rendering logic implemented twice for the two different displays.

T286141: Make watchlistUtils non-static covers making watchlistUtils into a non-static class WatchlistUtils, which we can then put some more logic in, but there are other things that don't have to wait for that

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Medium priority.Jul 6 2021, 11:58 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 set the point value for this task to 6.

Change 703421 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Remove MultiSiteWrapper.markAllSitesSeen confirmation parameter

https://gerrit.wikimedia.org/r/703421

Change 703421 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Remove MultiSiteWrapper.markAllSitesSeen() confirmation parameter

https://gerrit.wikimedia.org/r/703421

Change 704377 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Move flags logic into WatchlistUtils instead of duplicating it

https://gerrit.wikimedia.org/r/704377

Change 704377 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Move flags logic into WatchlistUtils instead of duplicating it

https://gerrit.wikimedia.org/r/704377

Change 708423 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Move tags display management to WatchlistUtils

https://gerrit.wikimedia.org/r/708423

Change 708423 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Move tags display management to WatchlistUtils

https://gerrit.wikimedia.org/r/708423

Change 710390 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Deduplicate timestamp title handling

https://gerrit.wikimedia.org/r/710390

Change 710562 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Deduplicate comment normalization handling

https://gerrit.wikimedia.org/r/710562

Change 710390 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Deduplicate timestamp title handling

https://gerrit.wikimedia.org/r/710390

Change 710562 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Deduplicate comment normalization handling

https://gerrit.wikimedia.org/r/710562