Page MenuHomePhabricator
Create Task
Maniphest T286403

Consistently supply type hints
Closed, ResolvedPublic
Actions

Description

Often pywikibot supplies type hints, but often it doesn't. This is a tracking ticket for consistently supplying type hints throughout our library.

When finished I'll likely look into integrating mypy into our tests to prevent regression.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

atagar created this task.Jul 10 2021, 9:45 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJul 10 2021, 9:45 PM
atagar triaged this task as Low priority.Jul 10 2021, 10:22 PM
gerritbot added a comment.Jul 10 2021, 10:23 PM

Change 703916 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] bot_choice.py type hints

https://gerrit.wikimedia.org/r/703916

gerritbot added a project: Patch-For-Review.Jul 10 2021, 10:23 PM
gerritbot added a comment.Jul 14 2021, 9:13 PM

Change 704629 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [bugfix] OutputProxyOption's 'out' could return None

https://gerrit.wikimedia.org/r/704629

gerritbot added a comment.Jul 14 2021, 10:19 PM

Change 704637 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [bugfix] ContextOption result() method returns None

https://gerrit.wikimedia.org/r/704637

gerritbot added a comment.Jul 15 2021, 10:49 PM

Change 704872 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] backports.py type hints

https://gerrit.wikimedia.org/r/704872

gerritbot added a comment.Jul 16 2021, 2:25 AM

Change 704885 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] bot.py type hints

https://gerrit.wikimedia.org/r/704885

gerritbot added a comment.Jul 16 2021, 2:46 AM

Change 703916 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] bot_choice.py type hints

https://gerrit.wikimedia.org/r/703916

gerritbot added a comment.Jul 16 2021, 5:44 AM

Change 704872 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] backports.py type hints

https://gerrit.wikimedia.org/r/704872

gerritbot added a comment.Jul 17 2021, 9:13 AM

Change 704637 merged by jenkins-bot:

[pywikibot/core@master] [cleanup] Explicitly return None from ContextOption.result()

https://gerrit.wikimedia.org/r/704637

gerritbot added a comment.Jul 17 2021, 9:17 AM

Change 704629 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] OutputProxyOption's 'out' could return None

https://gerrit.wikimedia.org/r/704629

gerritbot added a comment.Jul 17 2021, 9:24 AM

Change 705041 had a related patch set uploaded (by JJMC89; author: JJMC89):

[pywikibot/core@master] [IMPR] add type hints

https://gerrit.wikimedia.org/r/705041

gerritbot added a comment.Jul 17 2021, 5:36 PM

Change 705041 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] add type hints

https://gerrit.wikimedia.org/r/705041

gerritbot added a comment.Jul 17 2021, 10:50 PM

Change 705164 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] cosmetic_changes.py type hints

https://gerrit.wikimedia.org/r/705164

gerritbot added a comment.Jul 18 2021, 12:44 AM

Change 705168 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] daemonize.py type hints

https://gerrit.wikimedia.org/r/705168

gerritbot added a comment.Jul 18 2021, 5:41 AM

Change 705168 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] daemonize.py type hints

https://gerrit.wikimedia.org/r/705168

Xqt mentioned this in T286867: Drop support for Python 3.5.0 - 3.5.2.Jul 18 2021, 3:19 PM
gerritbot added a comment.Jul 20 2021, 4:11 AM

Change 705164 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] cosmetic_changes.py type hints

https://gerrit.wikimedia.org/r/705164

gerritbot added a comment.Jul 29 2021, 11:55 PM

Change 708872 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] date.py type hints

https://gerrit.wikimedia.org/r/708872

gerritbot added a comment.Jul 30 2021, 4:53 AM

Change 708872 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] date.py type hints

https://gerrit.wikimedia.org/r/708872

gerritbot added a comment.Jul 31 2021, 11:47 PM

Change 709236 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] diff.py type hints

https://gerrit.wikimedia.org/r/709236

gerritbot added a comment.Aug 1 2021, 11:18 PM

Change 709251 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] echo.py type hints

https://gerrit.wikimedia.org/r/709251

gerritbot added a comment.Aug 1 2021, 11:46 PM

Change 709252 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] editor.py type hints

https://gerrit.wikimedia.org/r/709252

gerritbot added a comment.Aug 1 2021, 11:57 PM

Change 709253 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] exceptions.py type hints

https://gerrit.wikimedia.org/r/709253

gerritbot added a comment.Aug 3 2021, 4:57 AM

Change 709590 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] family.py type hints

https://gerrit.wikimedia.org/r/709590

gerritbot added a comment.Aug 3 2021, 3:32 PM

Change 704885 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] bot.py type hints

https://gerrit.wikimedia.org/r/704885

gerritbot added a comment.Aug 3 2021, 9:38 PM

Change 709832 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] flow.py type hints

https://gerrit.wikimedia.org/r/709832

gerritbot added a comment.Aug 4 2021, 10:04 PM

Change 710116 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] i18n.py type hints

https://gerrit.wikimedia.org/r/710116

gerritbot added a comment.Aug 6 2021, 12:05 AM

Change 710382 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] __init__.py type hints

https://gerrit.wikimedia.org/r/710382

gerritbot added a comment.Aug 6 2021, 9:18 PM

Change 710612 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] interwiki_graph.py type hints

https://gerrit.wikimedia.org/r/710612

gerritbot added a comment.Aug 6 2021, 10:39 PM

Change 710615 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] logentries.py type hints

https://gerrit.wikimedia.org/r/710615

gerritbot added a comment.Aug 7 2021, 10:04 PM

Change 710673 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] logging.py type hints

https://gerrit.wikimedia.org/r/710673

gerritbot added a comment.Aug 7 2021, 11:05 PM

Change 710675 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] login.py type hints

https://gerrit.wikimedia.org/r/710675

gerritbot added a comment.Aug 16 2021, 2:15 AM

Change 709251 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] echo.py type hints

https://gerrit.wikimedia.org/r/709251

gerritbot added a comment.Aug 16 2021, 6:27 AM

Change 710675 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] login.py type hints

https://gerrit.wikimedia.org/r/710675

gerritbot added a comment.Aug 16 2021, 12:16 PM

Change 709253 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] exceptions.py type hints

https://gerrit.wikimedia.org/r/709253

gerritbot added a comment.Aug 17 2021, 12:31 PM

Change 710612 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] interwiki_graph.py type hints

https://gerrit.wikimedia.org/r/710612

gerritbot added a comment.Aug 20 2021, 9:07 AM

Change 710673 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] logging.py type hints

https://gerrit.wikimedia.org/r/710673

gerritbot added a comment.Aug 21 2021, 5:46 AM

Change 709252 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] editor.py type hints

https://gerrit.wikimedia.org/r/709252

gerritbot added a comment.Aug 22 2021, 11:30 PM

Change 714210 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] pagegenerators.py type hints

https://gerrit.wikimedia.org/r/714210

gerritbot added a comment.Aug 24 2021, 6:36 AM

Change 714455 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [IMPR] proofreadpage.py type hints

https://gerrit.wikimedia.org/r/714455

gerritbot added a comment.Sep 15 2021, 1:46 PM

Change 709832 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] flow.py type hints

https://gerrit.wikimedia.org/r/709832

gerritbot added a comment.Sep 15 2021, 1:46 PM

Change 709236 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] diff.py type hints

https://gerrit.wikimedia.org/r/709236

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 714455 abandoned by Damian:

[pywikibot/core@master] [IMPR] proofreadpage.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/714455

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 710382 abandoned by Damian:

[pywikibot/core@master] [IMPR] __init__.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/710382

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 710615 abandoned by Damian:

[pywikibot/core@master] [IMPR] logentries.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/710615

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 714210 abandoned by Damian:

[pywikibot/core@master] [IMPR] pagegenerators.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/714210

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 710116 abandoned by Damian:

[pywikibot/core@master] [IMPR] i18n.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/710116

gerritbot added a comment.Sep 15 2021, 9:14 PM

Change 709590 abandoned by Damian:

[pywikibot/core@master] [IMPR] family.py type hints

Reason:

Left pywikibot (for details see blog.atagar.com)

https://gerrit.wikimedia.org/r/709590

gerritbot added a comment.Sep 16 2021, 4:06 PM

Change 714455 restored by Xqt:

[pywikibot/core@master] [IMPR] proofreadpage.py type hints

https://gerrit.wikimedia.org/r/714455

gerritbot added a comment.Sep 16 2021, 7:40 PM

Change 714455 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] proofreadpage.py type hints

https://gerrit.wikimedia.org/r/714455

gerritbot added a comment.Sep 21 2021, 2:04 PM

Change 710382 restored by Xqt:

[pywikibot/core@master] [IMPR] __init__.py type hints

https://gerrit.wikimedia.org/r/710382

gerritbot added a comment.Sep 21 2021, 2:17 PM

Change 710615 restored by Xqt:

[pywikibot/core@master] [IMPR] logentries.py type hints

https://gerrit.wikimedia.org/r/710615

gerritbot added a comment.Sep 21 2021, 2:28 PM

Change 710615 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] logentries.py type hints

https://gerrit.wikimedia.org/r/710615

gerritbot added a comment.Sep 22 2021, 11:36 AM

Change 710382 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] __init__.py type hints

https://gerrit.wikimedia.org/r/710382

gerritbot added a comment.Sep 25 2021, 11:39 AM

Change 714210 restored by Xqt:

[pywikibot/core@master] [IMPR] pagegenerators.py type hints

https://gerrit.wikimedia.org/r/714210

gerritbot added a comment.Sep 25 2021, 12:31 PM

Change 714210 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] pagegenerators.py type hints

https://gerrit.wikimedia.org/r/714210

gerritbot added a comment.Oct 8 2021, 11:34 AM

Change 710116 restored by Xqt:

[pywikibot/core@master] [IMPR] i18n.py type hints

https://gerrit.wikimedia.org/r/710116

gerritbot added a comment.Oct 8 2021, 12:26 PM

Change 710116 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] i18n.py type hints

https://gerrit.wikimedia.org/r/710116

Xqt removed a project: Patch-For-Review.Nov 4 2021, 9:42 AM
Xqt removed atagar as the assignee of this task.Apr 28 2022, 7:23 AM
Xqt lowered the priority of this task from Low to Lowest.
Xqt closed this task as Resolved.Apr 3 2023, 1:36 PM
Xqt claimed this task.
Xqt subscribed.

Nice to have but currently no benefit. Close it as solved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL