Release mediawiki-codesniffer v37.0.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jul 13 2021, 1:05 PM

Description

T278653: Release mediawiki-codesniffer v36.0.0 | NoneYet

Given we generally do about one of these every three months, it's coming up to time. We don't have an official regular release process (yet, see T266890).

* build: Update php-parallel-lint/php-parallel-lint (Umherirrender)
* Allow configuring prefixes in PrefixedGlobalFunctionsSniff (DannyS712)
* Minor clean up to LowerCamelFunctionsNameSniff (DannyS712)
* AssertCountSniff: allow manual `count` on both sides (DannyS712)
* RedundantVarNameSniff: also check static properties (DannyS712)
* PrefixedGlobalFunctionsSniff: drop `ef` from default prefixes (DannyS712)
* UnsortedUseStatementsSniff: add early returns (DannyS712)
* FunctionCommentSniff: also skip {@inheritDoc} (DannyS712)
* DocumentationTypeTrait: complain about `type` as a type (DannyS712)
* Add Gerrit report format (Gergő Tisza)
* Add fix reporting to Gerrit robot comment reporter (Gergő Tisza)

Details

	Subject	Repo	Branch	Lines +/-
	Bump mediawiki-codesniffer from 36.0.0 to 37.0.0	labs/libraryupgrader/config	master	+1 -1
	Release v37.0.0	mediawiki/tools/codesniffer	master	+25 -1

Customize query in gerrit

Related Objects

Mentioned In: rLLIC9ab9c2ffcda4: Bump mediawiki-codesniffer from 36.0.0 to 37.0.0
T278653: Release mediawiki-codesniffer v36.0.0
Mentioned Here: T266890: Establish a regular release process for codesniffer
T220719: Standardize return type hint spacing
T265228: Add a sniff for `@internal` on private methods
T266193: Add a sniff for empty lines between use statements
T271267: False positive MediaWiki.Commenting.PropertyDocumentation.SpacingAfter when visibility is not on same line as property name
T278348: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {}
T281910: Analyze if MediaWiki.PHPUnit.AssertionOrder could handle more complex cases
T278653: Release mediawiki-codesniffer v36.0.0

Event Timeline

Jdforrester-WMF created this task.Jul 13 2021, 1:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 1:05 PM

Jdforrester-WMF mentioned this in T278653: Release mediawiki-codesniffer v36.0.0.Jul 13 2021, 1:05 PM

The autofix for T220719: Standardize return type hint spacing will result in autofix changes to a whole bunch of files (every phpunit test file already includes void typehints enforced by a different sniff, so those will all be changed, so its likely that all extensions will have at least some files autofixed and thus the patches will require manual review and +2 instead of libup merging automatically). On the one hand, it may make sense to wait until that patch is merged to include it in this release, but on the other hand it may make sense to have that separately because it'll require manual reviewing. Not sure

There are also some pending patches that I would hope can get reviewed before the next release, including those for