Page MenuHomePhabricator

Mobile small nag RML doesn't depend on frb-rml-enabled/frb-rml-disabled
Closed, ResolvedPublic

Assigned To
Authored By
Pcoombe
Jul 28 2021, 6:43 PM
Referenced Files
F34569801: image.png
Jul 29 2021, 9:01 PM
F34569795: image.png
Jul 29 2021, 9:01 PM
F34569793: image.png
Jul 29 2021, 9:01 PM
F34569799: image.png
Jul 29 2021, 9:01 PM

Description

e.g. in France RML should currently be disabled but the "Maybe later" button still shows up in the nag https://en.m.wikipedia.org/wiki/Wikipedia?banner=B2122_0714_en6C_m_p2_sm_template&country=FR

Event Timeline

Hey @Pcoombe please add me as a subscriber to all bugs reported related to banners, it's helpful for me to know what's going on and also will help our team reduce duplicate bugs as we grow

@jbolorinos-ctr Can you double check this fix looks fine? https://en.m.wikipedia.org/wiki/NASA?banner=pcoombe_T287626

Expected behaviour:

  • nag and main banner RML displayed when country=US
  • nag and main banner RML *not* displayed when country=ES

Screenshot of fix applied country=US
Main

image.png (250×741 px, 16 KB)

Nag
image.png (227×842 px, 29 KB)

Screenshot of fix applied country=ES
Main

image.png (226×1 px, 23 KB)

Nag
image.png (82×442 px, 3 KB)

Pcoombe claimed this task.