Internal error when trying to a load page on beta-cluster
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Bas_dehaan
	Jul 30 2021, 8:56 PM

Description

Error

mwversion: 1.37.0-alpha (0f8fd3c)
reqId: YQRl4SDkDtOJKw9uS8U4ZwAAAAU

[YQRl4SDkDtOJKw9uS8U4ZwAAAAU] /wiki/Wikipedia:Te_beoordelen_pagina%27s/Toegevoegd_20210730 TypeError: Argument 1 passed to Wikimedia\Parsoid\Wt2Html\XMLSerializer::serialize() must implement interface Wikimedia\Parsoid\DOM\Compat\Node, instance of DOMElement given, called in /srv/mediawiki/php-master/vendor/wikimedia/parsoid/src/Utils/DOMCompat.php on line 433

Backtrace:

from /srv/mediawiki/php-master/vendor/wikimedia/parsoid/src/Wt2Html/XMLSerializer.php(261)
#0 /srv/mediawiki/php-master/vendor/wikimedia/parsoid/src/Utils/DOMCompat.php(433): Wikimedia\Parsoid\Wt2Html\XMLSerializer::serialize(DOMElement, array)
#1 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/CommentFormatter.php(275): Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML(DOMElement)
#2 [internal function]: MediaWiki\Extension\DiscussionTools\CommentFormatter::MediaWiki\Extension\DiscussionTools\{closure}(array)
#3 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/CommentFormatter.php(277): preg_replace_callback(string, Closure, string)
#4 /srv/mediawiki/php-master/extensions/DiscussionTools/includes/Hooks/PageHooks.php(125): MediaWiki\Extension\DiscussionTools\CommentFormatter::postprocessTopicSubscription(string, Language, MediaWiki\Extension\DiscussionTools\SubscriptionStore, User)
#5 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\DiscussionTools\Hooks\PageHooks->onOutputPageBeforeHTML(OutputPage, string)
#6 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(2669): MediaWiki\HookContainer\HookContainer->run(string, array)
#7 /srv/mediawiki/php-master/includes/OutputPage.php(2017): MediaWiki\HookContainer\HookRunner->onOutputPageBeforeHTML(OutputPage, string)
#8 /srv/mediawiki/php-master/includes/OutputPage.php(2029): OutputPage->addParserOutputText(ParserOutput, array)
#9 /srv/mediawiki/php-master/includes/page/Article.php(798): OutputPage->addParserOutput(ParserOutput, array)
#10 /srv/mediawiki/php-master/includes/page/Article.php(652): Article->doOutputFromParserCache(ParserOutput, OutputPage, array)
#11 /srv/mediawiki/php-master/includes/page/Article.php(559): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#12 /srv/mediawiki/php-master/includes/actions/ViewAction.php(74): Article->view()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(538): ViewAction->show()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
#16 /srv/mediawiki/php-master/includes/MediaWiki.php(559): MediaWiki->main()
#17 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}

Impact

When logged-in, viewing the page will result in an internal error, also trying to edit the page with the visual editor will result in an error. Trying to edit the page with the source editor, or viewing the page without logging-in return no issues.

Details

Request URL: https://nl.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Te_beoordelen_pagina%27s/Toegevoegd_20210730

Related Objects

Mentioned In: T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given

Event Timeline

Bas_dehaan created this task.Jul 30 2021, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2021, 8:56 PM

Should be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/708618 (which hasn't been merged yet).

(in particular the tweak to postprocessTopicSubscription in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/708618/9/includes/CommentFormatter.php which is implicated in that backtrace.)

Metaverse subscribed.Jul 30 2021, 9:34 PM

Zabe subscribed.Jul 30 2021, 9:57 PM

Krinkle closed this task as a duplicate of T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given.Jul 30 2021, 10:07 PM

cscott mentioned this in T287611: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMCompat::getOuterHTML() must be an instance of Wikimedia\Parsoid\DOM\Compat\Element, instance of DOMElement given.Jul 30 2021, 11:03 PM

Tested the Request URL while logged in and it seems to be fixed now.

Internal error when trying to a load page on beta-clusterClosed, DuplicatePublicPRODUCTION ERRORActions