Page MenuHomePhabricator

Remove manual disables of "vars-on-top" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer
Closed, ResolvedPublic

Description

eslint-config-wikimedia version 0.20.0 included a commit that disabled the vars-on-top rule by default[1][2]. Repos that use that version or newer no longer need to manually disable the rule, and such disables can be removed.

[1] tagging of 0.20.0 including changelog entry "Allow var blocks to be split and moved" https://github.com/wikimedia/eslint-config-wikimedia/commit/4ff99ae786e66a1efce0b5f6b090af6303fceee3
[2] the commit for that entry which removes the vars-on-top entry https://github.com/wikimedia/eslint-config-wikimedia/commit/b90a3665c9ee0c024a8d76677d65ba7e766c030d

See also T286838: Remove manual disables of "one-var" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer

Note: A bunch of repos don't disable it entirely, but rather convert it to a warning - since this was used to make the tests pass (because by default warnings don't result in failures) I consider setting the rule to a warning to qualify as a disabling and will remove those too.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/skins/WikimediaApiPortalmaster+1 -2
mediawiki/libs/LangConvmaster+0 -1
mediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+0 -1
mediawiki/extensions/MultiMapsmaster+0 -1
mediawiki/extensions/SideBarMenumaster+0 -1
mediawiki/extensions/SemanticSiftermaster+0 -1
mediawiki/extensions/WikibaseLexememaster+0 -1
mediawiki/extensions/FlexiSkinmaster+0 -1
mediawiki/extensions/BlueSpiceFoundationmaster+0 -1
mediawiki/extensions/TwoColConflictmaster+1 -2
mediawiki/extensions/WikEdDiffmaster+0 -1
mediawiki/extensions/GWToolsetmaster+1 -2
mediawiki/extensions/Tabbermaster+0 -1
mediawiki/extensions/ScrollableTablesmaster+1 -2
mediawiki/extensions/SaveSpinnermaster+0 -1
mediawiki/extensions/JSBreadCrumbsmaster+1 -2
mediawiki/extensions/HoverGallerymaster+1 -2
mediawiki/extensions/HeaderTabsmaster+0 -1
mediawiki/extensions/DisqusTagmaster+0 -1
mediawiki/extensions/DonationInterfacemaster+0 -1
mediawiki/extensions/VoteNYmaster+0 -1
mediawiki/extensions/TextScrollermaster+0 -1
mediawiki/extensions/Draftsmaster+0 -1
mediawiki/extensions/WikiToLDAPmaster+0 -1
mediawiki/extensions/CirrusSearchmaster+1 -2
mediawiki/extensions/NSFileRepomaster+0 -1
mediawiki/extensions/PageFormsmaster+0 -1
mediawiki/extensions/OfflineImportLexiconmaster+0 -1
mediawiki/extensions/OnlineStatusmaster+0 -1
mediawiki/extensions/MsUploadmaster+0 -1
mediawiki/extensions/MaintenanceShellmaster+0 -1
mediawiki/extensions/OpenIDmaster+0 -1
mediawiki/extensions/PagePopupsmaster+0 -1
mediawiki/extensions/PhpTagsMapsmaster+0 -1
mediawiki/extensions/PanScrollmaster+0 -1
mediawiki/extensions/Cargomaster+0 -1
mediawiki/extensions/SemanticDrilldownmaster+0 -1
mediawiki/extensions/SocialLoginmaster+0 -1
mediawiki/extensions/SmiteSpammaster+0 -1
mediawiki/extensions/Surveymaster+0 -1
mediawiki/extensions/Sparkmaster+0 -1
mediawiki/extensions/SemanticRatingmaster+0 -1
mediawiki/extensions/VikiSemanticTitlemaster+1 -2
mediawiki/extensions/WikiLexicalDatamaster+0 -1
mediawiki/extensions/Acrolinxmaster+1 -2
mediawiki/extensions/Tabsmaster+0 -1
mediawiki/extensions/AdvancedSearchmaster+0 -1
mediawiki/extensions/Collectionmaster+0 -1
mediawiki/extensions/CheckUsermaster+0 -1
mediawiki/extensions/SVGEditmaster+0 -1
mediawiki/extensions/TitleIconmaster+1 -2
mediawiki/extensions/InlineCategorizermaster+0 -1
mediawiki/extensions/LanguageToolmaster+0 -1
mediawiki/extensions/LanguageSelectormaster+1 -2
mediawiki/extensions/CreatePagemaster+0 -1
mediawiki/extensions/LinkSuggestmaster+0 -1
mediawiki/extensions/LinkFiltermaster+0 -1
mediawiki/extensions/Commentsmaster+0 -1
mediawiki/extensions/FanBoxesmaster+0 -1
mediawiki/extensions/AjaxShowEditorsmaster+0 -1
mediawiki/extensions/CodeReviewmaster+1 -2
mediawiki/extensions/PictureGamemaster+0 -1
mediawiki/extensions/CreateAPagemaster+0 -1
mediawiki/extensions/SpamRegexmaster+0 -1
mediawiki/extensions/SocialProfilemaster+0 -1
mediawiki/extensions/QuizGamemaster+0 -1
mediawiki/extensions/PollNYmaster+0 -1
mediawiki/extensions/ArticleFeedbackv5master+0 -1
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rEMMA51eccc408b58: ESLint: remove redundant disable of vars-on-top rule
rESTB62de53176701: ESLint: remove redundant disable of vars-on-top rule
rESSPf74dbf925688: ESLint: remove redundant disable of vars-on-top rule
rMLLC55a3d0dd22a5: ESLint: remove redundant disable of vars-on-top rule
rEBVJ1161b7e920a0: ESLint: remove redundant disable of vars-on-top rule
rESCCa2ac0bfa8cf6: ESLint: remove redundant disable of vars-on-top rule
rMSWA170ebf191f6b: ESLint: remove redundant disable of vars-on-top rule
rEJSBd8a85d71d859: ESLint: remove redundant disable of vars-on-top rule
rEWTL39d1d37f42bd: ESLint: remove redundant disable of vars-on-top rule
rEOIL20cc6b00ca4d: ESLint: remove redundant disable of vars-on-top rule
rELNTdad6f4d38e6f: ESLint: remove redundant disable of vars-on-top rule
rELSRbdd0ad42c95b: ESLint: remove redundant disable of vars-on-top rule
rEPANf38aeea8b701: ESLint: remove redundant disable of vars-on-top rule
rEPPU8439b11a6c9b: ESLint: remove redundant disable of vars-on-top rule
rEAKL527b17da16fe: ESLint: remove redundant disable of vars-on-top rule
rELISa753cbe6311f: ESLint: remove redundant disable of vars-on-top rule
rEPGA7d066fd48d98: ESLint: remove redundant disable of vars-on-top rule
rEASHc64f9109ac75: ESLint: remove redundant disable of vars-on-top rule
rESPRe827f98b7ad8: ESLint: remove redundant disable of vars-on-top rule
rECPGb0f81c74c33d: ESLint: remove redundant disable of vars-on-top rule
Mentioned Here
T286838: Remove manual disables of "one-var" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 709129 merged by jenkins-bot:

[mediawiki/extensions/FanBoxes@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709129

Change 709127 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709127

Change 709134 merged by jenkins-bot:

[mediawiki/extensions/LinkFilter@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709134

Change 709135 merged by jenkins-bot:

[mediawiki/extensions/LinkSuggest@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709135

Change 709128 merged by jenkins-bot:

[mediawiki/extensions/CreatePage@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709128

Change 709132 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709132

Change 709133 merged by jenkins-bot:

[mediawiki/extensions/LanguageTool@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709133

Change 709131 merged by jenkins-bot:

[mediawiki/extensions/InlineCategorizer@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709131

Change 709169 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709169

Change 709166 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709166

Change 709171 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709171

Change 709162 merged by jenkins-bot:

[mediawiki/extensions/TitleIcon@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709162

Change 709160 merged by jenkins-bot:

[mediawiki/extensions/SVGEdit@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709160

Change 709168 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709168

Change 709161 merged by jenkins-bot:

[mediawiki/extensions/Tabs@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709161

Change 709165 merged by jenkins-bot:

[mediawiki/extensions/Acrolinx@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709165

Change 709164 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709164

Change 709163 merged by jenkins-bot:

[mediawiki/extensions/VikiSemanticTitle@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709163

Change 709151 merged by jenkins-bot:

[mediawiki/extensions/SemanticRating@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709151

Change 709158 merged by jenkins-bot:

[mediawiki/extensions/Spark@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709158

Change 709159 merged by jenkins-bot:

[mediawiki/extensions/Survey@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709159

Change 709154 merged by jenkins-bot:

[mediawiki/extensions/SmiteSpam@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709154

Change 709155 merged by jenkins-bot:

[mediawiki/extensions/SocialLogin@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709155

Change 709150 merged by jenkins-bot:

[mediawiki/extensions/SemanticDrilldown@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709150

Change 709145 merged by jenkins-bot:

[mediawiki/extensions/PanScroll@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709145

Change 709146 merged by jenkins-bot:

[mediawiki/extensions/PhpTagsMaps@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709146

Change 709144 merged by jenkins-bot:

[mediawiki/extensions/PagePopups@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709144

Change 709143 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709143

Change 709142 merged by jenkins-bot:

[mediawiki/extensions/OpenID@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709142

Change 709136 merged by jenkins-bot:

[mediawiki/extensions/MaintenanceShell@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709136

Change 709137 merged by jenkins-bot:

[mediawiki/extensions/MsUpload@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709137

Change 709141 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709141

Change 709139 merged by jenkins-bot:

[mediawiki/extensions/NSFileRepo@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709139

Change 709140 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709140

Change 709173 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/DisqusTag@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709173

Change 709174 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/DonationInterface@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709174

Change 709175 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Drafts@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709175

Change 709176 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GWToolset@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709176

Change 709177 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/HeaderTabs@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709177

Change 709178 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/HoverGallery@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709178

Change 709179 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/JSBreadCrumbs@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709179

Change 709180 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/SaveSpinner@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709180

Change 709181 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/ScrollableTables@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709181

Change 709182 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Tabber@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709182

Change 709183 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/TextScroller@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709183

Change 709184 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/TwoColConflict@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709184

Change 709185 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/VoteNY@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709185

Change 709186 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikEdDiff@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709186

Change 709187 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikibaseLexeme@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709187

Change 709188 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709188

Change 709189 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/libs/LangConv@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709189

Change 709190 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/WikimediaApiPortal@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709190

Change 709126 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709126

Change 709188 merged by Jack Phoenix:

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709188

Change 709175 merged by jenkins-bot:

[mediawiki/extensions/Drafts@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709175

Change 709183 merged by jenkins-bot:

[mediawiki/extensions/TextScroller@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709183

Change 709185 merged by jenkins-bot:

[mediawiki/extensions/VoteNY@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709185

Change 709174 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709174

Change 709173 merged by jenkins-bot:

[mediawiki/extensions/DisqusTag@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709173

Change 709176 merged by jenkins-bot:

[mediawiki/extensions/GWToolset@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709176

Change 709177 merged by jenkins-bot:

[mediawiki/extensions/HeaderTabs@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709177

Change 709178 merged by jenkins-bot:

[mediawiki/extensions/HoverGallery@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709178

Change 709179 merged by jenkins-bot:

[mediawiki/extensions/JSBreadCrumbs@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709179

Change 709180 merged by jenkins-bot:

[mediawiki/extensions/SaveSpinner@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709180

Change 709181 merged by jenkins-bot:

[mediawiki/extensions/ScrollableTables@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709181

Change 709182 merged by jenkins-bot:

[mediawiki/extensions/Tabber@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709182

Change 709190 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709190

Change 709184 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709184

Change 709186 merged by jenkins-bot:

[mediawiki/extensions/WikEdDiff@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709186

Change 709187 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709187

Change 709005 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFoundation@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709005

Change 709130 merged by Jack Phoenix:

[mediawiki/extensions/FlexiSkin@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709130

Change 709138 merged by Jack Phoenix:

[mediawiki/extensions/MultiMaps@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709138

Change 709152 merged by Jack Phoenix:

[mediawiki/extensions/SemanticSifter@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709152

Change 709153 merged by Jack Phoenix:

[mediawiki/extensions/SideBarMenu@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709153

Change 709167 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709167

Change 709189 merged by jenkins-bot:

[mediawiki/libs/LangConv@master] ESLint: remove redundant disable of vars-on-top rule

https://gerrit.wikimedia.org/r/709189

DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Don't see any more hits in codesearch