Page MenuHomePhabricator

Remove manual disables of "one-var" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer
Closed, ResolvedPublic

Description

eslint-config-wikimedia version 0.20.0 included a commit that disabled the one-var rule by default[1][2]. Repos that use that version or newer no longer need to manually disable the rule, and such disables can be removed.

[1] tagging of 0.20.0 including changelog entry "Allow var blocks to be split and moved" https://github.com/wikimedia/eslint-config-wikimedia/commit/4ff99ae786e66a1efce0b5f6b090af6303fceee3
[2] the commit for that entry which removes the one-var entry https://github.com/wikimedia/eslint-config-wikimedia/commit/b90a3665c9ee0c024a8d76677d65ba7e766c030d

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+1 -1
mediawiki/extensions/QuickSurveysmaster+1 -2
mediawiki/skins/MinervaNeuemaster+0 -1
mediawiki/extensions/NearbyPagesmaster+1 -2
mediawiki/extensions/MediaSearchmaster+1 -2
mediawiki/extensions/CheckUsermaster+1 -1
mediawiki/extensions/AJAXPollmaster+1 -1
mediawiki/extensions/Collectionmaster+0 -1
mediawiki/extensions/Cargomaster+0 -1
mediawiki/extensions/NSFileRepomaster+0 -1
mediawiki/extensions/WikibaseLexememaster+0 -1
mediawiki/skins/WikimediaApiPortalmaster+0 -1
mediawiki/extensions/Acrolinxmaster+0 -1
mediawiki/extensions/OnlineStatusmaster+0 -1
mediawiki/skins/Vectormaster+0 -1
mediawiki/extensions/PageFormsmaster+0 -1
mediawiki/extensions/CreatePagemaster+0 -1
mediawiki/extensions/HeaderTabsmaster+0 -1
mediawiki/extensions/HoverGallerymaster+0 -1
mediawiki/extensions/InlineCategorizermaster+0 -1
mediawiki/extensions/JSBreadCrumbsmaster+0 -1
mediawiki/extensions/CommentStreamsmaster+0 -1
mediawiki/extensions/MultiMapsmaster+0 -1
mediawiki/extensions/SemanticDrilldownmaster+0 -1
mediawiki/extensions/SemanticSiftermaster+0 -1
mediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+0 -1
mediawiki/extensions/BlueSpiceFoundationmaster+0 -1
mediawiki/extensions/FlexiSkinmaster+0 -1
mediawiki/extensions/SideBarMenumaster+0 -1
mediawiki/extensions/WikiToLDAPmaster+0 -1
mediawiki/extensions/SaveSpinnermaster+0 -1
mediawiki/extensions/OfflineImportLexiconmaster+0 -1
mediawiki/extensions/PhpTagsMapsmaster+0 -1
mediawiki/extensions/SemanticRatingmaster+0 -1
mediawiki/extensions/SocialLoginmaster+0 -1
mediawiki/extensions/PanScrollmaster+0 -1
mediawiki/extensions/SmiteSpammaster+0 -1
mediawiki/extensions/ScrollableTablesmaster+0 -1
mediawiki/extensions/Sparkmaster+0 -1
mediawiki/extensions/LanguageSelectormaster+0 -1
mediawiki/extensions/Tabsmaster+0 -1
mediawiki/extensions/Tabbermaster+0 -1
mediawiki/extensions/WikiLexicalDatamaster+0 -1
mediawiki/extensions/SVGEditmaster+0 -1
mediawiki/extensions/WikEdDiffmaster+0 -1
mediawiki/extensions/Surveymaster+0 -1
mediawiki/extensions/CodeReviewmaster+0 -1
mediawiki/extensions/PollNYmaster+0 -1
mediawiki/extensions/TextScrollermaster+0 -1
mediawiki/extensions/VoteNYmaster+0 -1
mediawiki/extensions/AjaxShowEditorsmaster+0 -1
mediawiki/extensions/ArticleFeedbackv5master+0 -1
mediawiki/extensions/Draftsmaster+0 -1
mediawiki/extensions/PictureGamemaster+0 -1
mediawiki/extensions/QuizGamemaster+0 -1
mediawiki/extensions/SocialProfilemaster+0 -1
mediawiki/extensions/LinkSuggestmaster+0 -1
mediawiki/extensions/CreateAPagemaster+0 -1
mediawiki/extensions/FanBoxesmaster+0 -1
mediawiki/extensions/TwoColConflictmaster+1 -2
mediawiki/extensions/AdvancedSearchmaster+0 -1
mediawiki/extensions/MsUploadmaster+0 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 705095 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705095

Having uploaded all of the patches I found for repos that disabled (or set to warn) the rule is their .eslintrc.json file and also use 0.20.0 of the config library, rather than adding a bunch of reviewers to each patch individually, flooding inboxes, I figured it would be easier to ask for reviews here - pinging @Jdforrester-WMF @thiemowmde @Umherirrender who have reviewed similar repetitive patches in the past - is one of you willing to take a look at these? All of the patches do the same thing

Change 705066 merged by jenkins-bot:

[mediawiki/extensions/MsUpload@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705066

Change 704821 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704821

Change 704824 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704824

Change 705058 merged by Jack Phoenix:

[mediawiki/extensions/FanBoxes@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705058

Change 705055 merged by Jack Phoenix:

[mediawiki/extensions/CreateAPage@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705055

Change 705065 merged by jenkins-bot:

[mediawiki/extensions/LinkSuggest@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705065

Change 705085 merged by Jack Phoenix:

[mediawiki/extensions/SocialProfile@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705085

Change 705076 merged by Jack Phoenix:

[mediawiki/extensions/QuizGame@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705076

Change 705074 merged by Jack Phoenix:

[mediawiki/extensions/PictureGame@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705074

Change 705057 merged by jenkins-bot:

[mediawiki/extensions/Drafts@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705057

Change 705050 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705050

Change 705049 merged by jenkins-bot:

[mediawiki/extensions/AjaxShowEditors@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705049

Change 704822 merged by jenkins-bot:

[mediawiki/extensions/CodeReview@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704822

Change 705092 merged by jenkins-bot:

[mediawiki/extensions/VoteNY@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705092

Change 705091 merged by jenkins-bot:

[mediawiki/extensions/TextScroller@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705091

Change 705075 merged by jenkins-bot:

[mediawiki/extensions/PollNY@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705075

Change 705087 merged by jenkins-bot:

[mediawiki/extensions/Survey@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705087

Change 705093 merged by jenkins-bot:

[mediawiki/extensions/WikEdDiff@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705093

Change 705088 merged by jenkins-bot:

[mediawiki/extensions/SVGEdit@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705088

Change 705094 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705094

Change 705089 merged by jenkins-bot:

[mediawiki/extensions/Tabber@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705089

Change 705090 merged by jenkins-bot:

[mediawiki/extensions/Tabs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705090

Change 705064 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705064

Change 705086 merged by jenkins-bot:

[mediawiki/extensions/Spark@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705086

Change 705078 merged by jenkins-bot:

[mediawiki/extensions/ScrollableTables@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705078

Change 705083 merged by jenkins-bot:

[mediawiki/extensions/SmiteSpam@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705083

Change 705072 merged by jenkins-bot:

[mediawiki/extensions/PanScroll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705072

Change 705084 merged by jenkins-bot:

[mediawiki/extensions/SocialLogin@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705084

Change 705080 merged by jenkins-bot:

[mediawiki/extensions/SemanticRating@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705080

Change 705073 merged by jenkins-bot:

[mediawiki/extensions/PhpTagsMaps@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705073

Change 705069 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705069

Change 705077 merged by jenkins-bot:

[mediawiki/extensions/SaveSpinner@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705077

Change 705095 merged by Jack Phoenix:

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705095

Change 705082 merged by Jack Phoenix:

[mediawiki/extensions/SideBarMenu@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705082

Change 705067 merged by Jack Phoenix:

[mediawiki/extensions/MultiMaps@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705067

Change 705059 merged by Jack Phoenix:

[mediawiki/extensions/FlexiSkin@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705059

Change 705052 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFoundation@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705052

Change 705051 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705051

Change 705081 merged by Jack Phoenix:

[mediawiki/extensions/SemanticSifter@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705081

Change 705079 merged by jenkins-bot:

[mediawiki/extensions/SemanticDrilldown@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705079

Change 705071 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705071

Change 705054 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705054

Change 705063 merged by jenkins-bot:

[mediawiki/extensions/JSBreadCrumbs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705063

Change 705062 merged by jenkins-bot:

[mediawiki/extensions/InlineCategorizer@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705062

Change 705061 merged by jenkins-bot:

[mediawiki/extensions/HoverGallery@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705061

Change 705060 merged by jenkins-bot:

[mediawiki/extensions/HeaderTabs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705060

Change 705056 merged by jenkins-bot:

[mediawiki/extensions/CreatePage@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705056

Change 705046 merged by jenkins-bot:

[mediawiki/skins/Vector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705046

Change 704825 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704825

Change 705068 merged by jenkins-bot:

[mediawiki/extensions/NSFileRepo@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705068

Change 705070 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705070

Change 704823 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704823

Change 705048 merged by jenkins-bot:

[mediawiki/extensions/Acrolinx@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705048

Change 705047 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705047

Change 705053 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705053

Looks like a job for LibUp to cleanup automatically

Change 708996 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/AJAXPoll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708996

Change 708997 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CheckUser@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708997

Change 708998 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MediaSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708998

Change 708999 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MobileFrontend@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708999

Change 709000 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/NearbyPages@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709000

Change 709001 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/QuickSurveys@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709001

Change 709002 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/MinervaNeue@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709002

Change 708996 merged by jenkins-bot:

[mediawiki/extensions/AJAXPoll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708996

Change 708997 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708997

Change 708998 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708998

Change 708999 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708999

Change 709000 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709000

Change 709001 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709001

Change 709002 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709002

DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Don't see any more hits in codesearch