Page MenuHomePhabricator
Create Task
Maniphest T286838

Remove manual disables of "one-var" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer
Closed, ResolvedPublic
Actions

Description

eslint-config-wikimedia version 0.20.0 included a commit that disabled the one-var rule by default[1][2]. Repos that use that version or newer no longer need to manually disable the rule, and such disables can be removed.

[1] tagging of 0.20.0 including changelog entry "Allow var blocks to be split and moved" https://github.com/wikimedia/eslint-config-wikimedia/commit/4ff99ae786e66a1efce0b5f6b090af6303fceee3
[2] the commit for that entry which removes the one-var entry https://github.com/wikimedia/eslint-config-wikimedia/commit/b90a3665c9ee0c024a8d76677d65ba7e766c030d

Details

SubjectRepoBranchLines +/-
ESLint: remove redundant disable of one-var rulemediawiki/extensions/MobileFrontendmaster+1 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/QuickSurveysmaster+1 -2
ESLint: remove redundant disable of one-var rulemediawiki/skins/MinervaNeuemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/NearbyPagesmaster+1 -2
ESLint: remove redundant disable of one-var rulemediawiki/extensions/MediaSearchmaster+1 -2
ESLint: remove redundant disable of one-var rulemediawiki/extensions/CheckUsermaster+1 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/AJAXPollmaster+1 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Collectionmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Cargomaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/NSFileRepomaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/WikibaseLexememaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/skins/WikimediaApiPortalmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Acrolinxmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/OnlineStatusmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/skins/Vectormaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/PageFormsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/CreatePagemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/HeaderTabsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/HoverGallerymaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/InlineCategorizermaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/JSBreadCrumbsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/CommentStreamsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/MultiMapsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SemanticDrilldownmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SemanticSiftermaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/BlueSpiceFoundationmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/FlexiSkinmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SideBarMenumaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/WikiToLDAPmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SaveSpinnermaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/OfflineImportLexiconmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/PhpTagsMapsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SemanticRatingmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SocialLoginmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/PanScrollmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SmiteSpammaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/ScrollableTablesmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Sparkmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/LanguageSelectormaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Tabsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Tabbermaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/WikiLexicalDatamaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SVGEditmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/WikEdDiffmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Surveymaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/CodeReviewmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/PollNYmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/TextScrollermaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/VoteNYmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/AjaxShowEditorsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/ArticleFeedbackv5master+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/Draftsmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/PictureGamemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/QuizGamemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/SocialProfilemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/LinkSuggestmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/CreateAPagemaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/FanBoxesmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/TwoColConflictmaster+1 -2
ESLint: remove redundant disable of one-var rulemediawiki/extensions/AdvancedSearchmaster+0 -1
ESLint: remove redundant disable of one-var rulemediawiki/extensions/MsUploadmaster+0 -1
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 17 2021, 2:05 AM

Change 705095 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705095

DannyS712 added subscribers: thiemowmde, Umherirrender, Jdforrester-WMF.Jul 17 2021, 2:07 AM

Having uploaded all of the patches I found for repos that disabled (or set to warn) the rule is their .eslintrc.json file and also use 0.20.0 of the config library, rather than adding a bunch of reviewers to each patch individually, flooding inboxes, I figured it would be easier to ask for reviews here - pinging @Jdforrester-WMF @thiemowmde @Umherirrender who have reviewed similar repetitive patches in the past - is one of you willing to take a look at these? All of the patches do the same thing

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jul 17 2021, 2:16 AM
gerritbot added a comment.Jul 17 2021, 3:08 AM

Change 705066 merged by jenkins-bot:

[mediawiki/extensions/MsUpload@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705066

gerritbot added a comment.Jul 17 2021, 12:04 PM

Change 704821 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704821

gerritbot added a comment.Jul 17 2021, 12:09 PM

Change 704824 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704824

DannyS712 mentioned this in rESCC4f5da1cd50c8: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 12:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 17 2021, 1:00 PM
gerritbot added a comment.Jul 17 2021, 3:36 PM

Change 705058 merged by Jack Phoenix:

[mediawiki/extensions/FanBoxes@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705058

gerritbot added a comment.Jul 17 2021, 3:38 PM

Change 705055 merged by Jack Phoenix:

[mediawiki/extensions/CreateAPage@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705055

DannyS712 mentioned this in rECPGcb4ed28a7fce: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 3:39 PM
gerritbot added a comment.Jul 17 2021, 3:39 PM

Change 705065 merged by jenkins-bot:

[mediawiki/extensions/LinkSuggest@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705065

gerritbot added a comment.Jul 17 2021, 3:40 PM

Change 705085 merged by Jack Phoenix:

[mediawiki/extensions/SocialProfile@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705085

gerritbot added a comment.Jul 17 2021, 3:41 PM

Change 705076 merged by Jack Phoenix:

[mediawiki/extensions/QuizGame@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705076

gerritbot added a comment.Jul 17 2021, 3:41 PM

Change 705074 merged by Jack Phoenix:

[mediawiki/extensions/PictureGame@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705074

DannyS712 mentioned this in rESPRdea4877a38bf: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 3:45 PM
gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705057 merged by jenkins-bot:

[mediawiki/extensions/Drafts@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705057

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705050 merged by jenkins-bot:

[mediawiki/extensions/ArticleFeedbackv5@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705050

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705049 merged by jenkins-bot:

[mediawiki/extensions/AjaxShowEditors@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705049

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 704822 merged by jenkins-bot:

[mediawiki/extensions/CodeReview@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704822

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705092 merged by jenkins-bot:

[mediawiki/extensions/VoteNY@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705092

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705091 merged by jenkins-bot:

[mediawiki/extensions/TextScroller@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705091

gerritbot added a comment.Jul 17 2021, 3:47 PM

Change 705075 merged by jenkins-bot:

[mediawiki/extensions/PollNY@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705075

DannyS712 mentioned this in rEASHf1dc4084570c: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 3:47 PM
gerritbot added a comment.Jul 17 2021, 4:27 PM

Change 705087 merged by jenkins-bot:

[mediawiki/extensions/Survey@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705087

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705093 merged by jenkins-bot:

[mediawiki/extensions/WikEdDiff@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705093

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705088 merged by jenkins-bot:

[mediawiki/extensions/SVGEdit@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705088

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705094 merged by jenkins-bot:

[mediawiki/extensions/WikiLexicalData@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705094

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705089 merged by jenkins-bot:

[mediawiki/extensions/Tabber@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705089

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705090 merged by jenkins-bot:

[mediawiki/extensions/Tabs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705090

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705064 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705064

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705086 merged by jenkins-bot:

[mediawiki/extensions/Spark@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705086

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705078 merged by jenkins-bot:

[mediawiki/extensions/ScrollableTables@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705078

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705083 merged by jenkins-bot:

[mediawiki/extensions/SmiteSpam@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705083

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705072 merged by jenkins-bot:

[mediawiki/extensions/PanScroll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705072

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705084 merged by jenkins-bot:

[mediawiki/extensions/SocialLogin@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705084

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705080 merged by jenkins-bot:

[mediawiki/extensions/SemanticRating@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705080

gerritbot added a comment.Jul 17 2021, 4:30 PM

Change 705073 merged by jenkins-bot:

[mediawiki/extensions/PhpTagsMaps@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705073

gerritbot added a comment.Jul 17 2021, 4:32 PM

Change 705069 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705069

gerritbot added a comment.Jul 17 2021, 4:32 PM

Change 705077 merged by jenkins-bot:

[mediawiki/extensions/SaveSpinner@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705077

gerritbot added a comment.Jul 17 2021, 4:32 PM

Change 705095 merged by Jack Phoenix:

[mediawiki/extensions/WikiToLDAP@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705095

gerritbot added a comment.Jul 17 2021, 4:32 PM

Change 705082 merged by Jack Phoenix:

[mediawiki/extensions/SideBarMenu@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705082

gerritbot added a comment.Jul 17 2021, 4:32 PM

Change 705067 merged by Jack Phoenix:

[mediawiki/extensions/MultiMaps@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705067

DannyS712 mentioned this in rEWTL030c38a71ba1: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 4:33 PM
gerritbot added a comment.Jul 17 2021, 4:33 PM

Change 705059 merged by Jack Phoenix:

[mediawiki/extensions/FlexiSkin@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705059

gerritbot added a comment.Jul 17 2021, 4:33 PM

Change 705052 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFoundation@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705052

DannyS712 mentioned this in rEBVJ8a6574e40fb8: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 4:33 PM
gerritbot added a comment.Jul 17 2021, 4:33 PM

Change 705051 merged by Jack Phoenix:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705051

gerritbot added a comment.Jul 17 2021, 4:33 PM

Change 705081 merged by Jack Phoenix:

[mediawiki/extensions/SemanticSifter@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705081

gerritbot added a comment.Jul 17 2021, 4:37 PM

Change 705079 merged by jenkins-bot:

[mediawiki/extensions/SemanticDrilldown@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705079

DannyS712 mentioned this in rEOILf9fde4b1e3d9: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 4:41 PM
gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705071 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705071

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705054 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705054

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705063 merged by jenkins-bot:

[mediawiki/extensions/JSBreadCrumbs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705063

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705062 merged by jenkins-bot:

[mediawiki/extensions/InlineCategorizer@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705062

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705061 merged by jenkins-bot:

[mediawiki/extensions/HoverGallery@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705061

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705060 merged by jenkins-bot:

[mediawiki/extensions/HeaderTabs@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705060

gerritbot added a comment.Jul 17 2021, 4:44 PM

Change 705056 merged by jenkins-bot:

[mediawiki/extensions/CreatePage@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705056

DannyS712 mentioned this in rECOS80b0eca4d98f: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 4:45 PM
DannyS712 mentioned this in rEJSB5ba9fe2d9d9e: ESLint: remove redundant disable of one-var rule.
gerritbot added a comment.Jul 17 2021, 4:53 PM

Change 705046 merged by jenkins-bot:

[mediawiki/skins/Vector@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705046

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 704825 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704825

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 705068 merged by jenkins-bot:

[mediawiki/extensions/NSFileRepo@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705068

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 705070 merged by jenkins-bot:

[mediawiki/extensions/OnlineStatus@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705070

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 704823 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/704823

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 705048 merged by jenkins-bot:

[mediawiki/extensions/Acrolinx@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705048

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 705047 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705047

gerritbot added a comment.Jul 17 2021, 4:57 PM

Change 705053 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/705053

DannyS712 mentioned this in rEAKLea58edf6d7b9: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 4:57 PM
DannyS712 mentioned this in rMSWA3a98b92264cb: ESLint: remove redundant disable of one-var rule.
DannyS712 mentioned this in rEPGA995f4418acf9: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 5:18 PM
DannyS712 mentioned this in rELSR4f8d8d7a1d56: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 5:51 PM
DannyS712 mentioned this in rESSP240823c4bc3b: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 5:54 PM
DannyS712 mentioned this in rELISd53cd3fb1a75: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 8:27 PM
DannyS712 mentioned this in rESTB36f6ef76940e: ESLint: remove redundant disable of one-var rule.
DannyS712 mentioned this in rEMMA936c2a32861a: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 8:39 PM
DannyS712 mentioned this in rEPAN6691551ab088: ESLint: remove redundant disable of one-var rule.Jul 17 2021, 8:51 PM
Umherirrender added a comment.Jul 20 2021, 7:02 PM

Looks like a job for LibUp to cleanup automatically

gerritbot added a comment.Jul 30 2021, 10:21 PM

Change 708996 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/AJAXPoll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708996

gerritbot added a comment.Jul 30 2021, 10:22 PM

Change 708997 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CheckUser@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708997

gerritbot added a comment.Jul 30 2021, 10:23 PM

Change 708998 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MediaSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708998

gerritbot added a comment.Jul 30 2021, 10:23 PM

Change 708999 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MobileFrontend@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708999

gerritbot added a comment.Jul 30 2021, 10:24 PM

Change 709000 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/NearbyPages@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709000

gerritbot added a comment.Jul 30 2021, 10:25 PM

Change 709001 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/QuickSurveys@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709001

gerritbot added a comment.Jul 30 2021, 10:25 PM

Change 709002 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/MinervaNeue@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709002

gerritbot added a comment.Jul 30 2021, 10:52 PM

Change 708996 merged by jenkins-bot:

[mediawiki/extensions/AJAXPoll@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708996

DannyS712 mentioned this in T287796: Remove manual disables of "vars-on-top" eslint rules for packages using eslint-config-wikimedia 0.20.0 or newer.Jul 30 2021, 10:54 PM
gerritbot added a comment.Jul 30 2021, 11:06 PM

Change 708997 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708997

gerritbot added a comment.Jul 30 2021, 11:17 PM

Change 708998 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708998

gerritbot added a comment.Jul 30 2021, 11:17 PM

Change 708999 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/708999

gerritbot added a comment.Jul 30 2021, 11:17 PM

Change 709000 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709000

gerritbot added a comment.Jul 30 2021, 11:17 PM

Change 709001 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709001

gerritbot added a comment.Jul 30 2021, 11:17 PM

Change 709002 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] ESLint: remove redundant disable of one-var rule

https://gerrit.wikimedia.org/r/709002

DannyS712 mentioned this in rEMED81a8bebc07e6: ESLint: remove redundant disable of one-var rule.Jul 30 2021, 11:17 PM
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.17; 2021-08-02); removed MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 31 2021, 12:00 AM
DannyS712 closed this task as Resolved.Aug 20 2021, 12:54 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Don't see any more hits in codesearch

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL