Page MenuHomePhabricator
Create Task
Maniphest T288385

Add objects to represent data for entry rows
Closed, ResolvedPublic20 Estimated Story Points
Actions

Description

Base class, plus subclasses for edits and log entries, to start with
Will be used to add uncollapsing grouped changes T274599: Allow uncollapsing grouped results and showing proper log entries T260220: Use proper messages for log entries

See basic roadmap at T274599#7244997

Details

SubjectRepoBranchLines +/-
GlobalWatchlistEntryLog: fix documented property name for log idmediawiki/extensions/GlobalWatchlistmaster+1 -1
GlobalWatchlistEntryLog: fix storing log idmediawiki/extensions/GlobalWatchlistmaster+1 -1
GlobalWatchlistEntryLog: fix storing log idmediawiki/extensions/GlobalWatchlistwmf/1.37.0-wmf.20+1 -1
Clean up documentation output for Entry(Base|Edits|Log)mediawiki/extensions/GlobalWatchlistmaster+5 -2
Add objects to represent data for entry rowsmediawiki/extensions/GlobalWatchlistmaster+211 -34
WatchlistUtils: merge rawToSummary end cleanupmediawiki/extensions/GlobalWatchlistmaster+110 -108
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenFeatureNoneT274599 Allow uncollapsing grouped results
 OpenNoneT260220 Use proper messages for log entries
 ResolvedDannyS712T288385 Add objects to represent data for entry rows

Event Timeline

DannyS712 created this task.Aug 6 2021, 11:53 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 6 2021, 11:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Medium priority.Aug 6 2021, 11:54 PM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 20.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added parent tasks: T274599: Allow uncollapsing grouped results, T260220: Use proper messages for log entries.
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Aug 12 2021, 9:42 AM

Change 711715 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] WatchlistUtils: merge rawToSummary end cleanup

https://gerrit.wikimedia.org/r/711715

gerritbot added a project: Patch-For-Review.Aug 12 2021, 9:42 AM
DannyS712 added a comment.Aug 12 2021, 8:20 PM

Properties currently set on the entries objects that we don't need to save:

  • tags (replaced with tagsDisplay)
  • comment (replaced with commentDisplay)
  • bot and minor (replaced with flags, newPage is still used to check if a diff link is shown)
gerritbot added a comment.Aug 16 2021, 8:47 PM

Change 711715 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] WatchlistUtils: merge rawToSummary end cleanup

https://gerrit.wikimedia.org/r/711715

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 16 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 16 2021, 9:12 PM
gerritbot added a comment.Aug 16 2021, 11:08 PM

Change 713347 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Add objects to represent data for entry rows

https://gerrit.wikimedia.org/r/713347

gerritbot added a project: Patch-For-Review.Aug 16 2021, 11:08 PM
gerritbot added a comment.Aug 20 2021, 3:51 PM

Change 713347 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Add objects to represent data for entry rows

https://gerrit.wikimedia.org/r/713347

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.20; 2021-08-23); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 20 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2021, 4:10 PM
DannyS712 closed this task as Resolved.Aug 20 2021, 4:12 PM
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 7.

Turned out to be a lot easier than expected to set up the initial objects, work will continue on part tasks

DannyS712 reopened this task as Open.Aug 25 2021, 12:00 AM

The documentation at https://doc.wikimedia.org/GlobalWatchlist/master/js/js/ is all weird:
The EntryBase class is a global https://doc.wikimedia.org/GlobalWatchlist/master/js/js/global.html#GlobalWatchlistEntryBase and missing the constructor documentation
The EntryEdits and EntryLog classes don't have the inherited properties, https://doc.wikimedia.org/GlobalWatchlist/master/js/js/GlobalWatchlistEntryEdits.html and https://doc.wikimedia.org/GlobalWatchlist/master/js/js/GlobalWatchlistEntryLog.html

gerritbot added a comment.Aug 25 2021, 12:01 AM

Change 714667 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Clean up documentation output for Entry(Base|Edits|Log)

https://gerrit.wikimedia.org/r/714667

gerritbot added a project: Patch-For-Review.Aug 25 2021, 12:01 AM
DannyS712 moved this task from Done to In progress on the MediaWiki-extensions-GlobalWatchlist board.Aug 25 2021, 12:04 AM
gerritbot added a comment.Aug 25 2021, 7:40 AM

Change 714669 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] GlobalWatchlistEntryLog: fix storing log id

https://gerrit.wikimedia.org/r/714669

gerritbot added a comment.Aug 25 2021, 9:43 PM

Change 714667 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Clean up documentation output for Entry(Base|Edits|Log)

https://gerrit.wikimedia.org/r/714667

gerritbot added a comment.Aug 25 2021, 9:45 PM

Change 714669 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] GlobalWatchlistEntryLog: fix storing log id

https://gerrit.wikimedia.org/r/714669

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 25 2021, 10:00 PM
gerritbot added a comment.Aug 25 2021, 11:08 PM

Change 714847 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@wmf/1.37.0-wmf.20] GlobalWatchlistEntryLog: fix storing log id

https://gerrit.wikimedia.org/r/714847

gerritbot added a comment.Aug 25 2021, 11:14 PM

Change 714848 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] GlobalWatchlistEntryLog: fix documented property name for log id

https://gerrit.wikimedia.org/r/714848

gerritbot added a comment.Aug 25 2021, 11:15 PM

Change 714847 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@wmf/1.37.0-wmf.20] GlobalWatchlistEntryLog: fix storing log id

https://gerrit.wikimedia.org/r/714847

Stashbot added a comment.Aug 25 2021, 11:19 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-25T23:19:54Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/GlobalWatchlist/modules/EntryLog.js: 230aec3fe7f3d0e325882a5fc926e9f3e4e86717: GlobalWatchlistEntryLog: fix storing log id (T288385) (duration: 01m 07s)

gerritbot added a comment.Aug 25 2021, 11:23 PM

Change 714848 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] GlobalWatchlistEntryLog: fix documented property name for log id

https://gerrit.wikimedia.org/r/714848

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.20; 2021-08-23); removed MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 12:00 AM
Pppery removed a project: Patch-For-Review.Apr 9 2023, 7:25 PM
Pppery subscribed.

All relevant patches (after the reopening) were merged. Can this be closed as resolved?

Pppery closed this task as Resolved.Apr 17 2023, 9:59 PM

No response, closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL