Page MenuHomePhabricator
Create Task
Maniphest T288614

Cover BacklinksCache with tests
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/709743 is refactoring BacklinksCache a bit, but the test coverage of this class is 0. We need to write some tests for it before that patch can be merged.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Test new methods in BacklinkCachemediawiki/coremaster+28 -0
Test BacklinkCachemediawiki/coremaster+147 -0
Customize query in gerrit

Event Timeline

• Pchelolo created this task.Aug 11 2021, 12:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 12:07 PM
• Pchelolo moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.Aug 11 2021, 12:14 PM
gerritbot added a comment.Aug 17 2021, 5:33 PM

Change 713498 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] [WIP] Test BacklinkCacheTest

https://gerrit.wikimedia.org/r/713498

gerritbot added a project: Patch-For-Review.Aug 17 2021, 5:33 PM
tchin moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Aug 17 2021, 6:57 PM
Krinkle edited projects, added MediaWiki-General; removed MediaWiki-libs-BagOStuff.Aug 17 2021, 7:17 PM
gerritbot added a comment.Aug 19 2021, 5:51 PM

Change 713498 merged by jenkins-bot:

[mediawiki/core@master] Test BacklinkCache

https://gerrit.wikimedia.org/r/713498

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 19 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 6:10 PM
gerritbot added a comment.Aug 20 2021, 2:01 PM

Change 714054 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] [WIP] Test new methods in BacklinkCache

https://gerrit.wikimedia.org/r/714054

gerritbot added a project: Patch-For-Review.Aug 20 2021, 2:01 PM
tchin moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Aug 24 2021, 6:39 PM
tchin moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Aug 30 2021, 4:45 PM
gerritbot added a comment.Aug 30 2021, 4:51 PM

Change 714054 merged by jenkins-bot:

[mediawiki/core@master] Test new methods in BacklinkCache

https://gerrit.wikimedia.org/r/714054

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 30 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 30 2021, 5:10 PM
tchin closed this task as Resolved.Aug 31 2021, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits