Page MenuHomePhabricator

Prepare codebase to be able to disconnect old sidebar
Closed, ResolvedPublic0 Estimated Story Points

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+116 -134
mediawiki/extensions/Citoidmaster+0 -4
mediawiki/extensions/VisualEditormaster+51 -62
mediawiki/extensions/VisualEditormaster+44 -44
mediawiki/extensions/VisualEditormaster+66 -52
mediawiki/extensions/VisualEditormaster+7 -4
mediawiki/extensions/VisualEditormaster+29 -35
mediawiki/extensions/VisualEditormaster+5 -3
mediawiki/extensions/VisualEditormaster+2 -1
mediawiki/extensions/Citoidmaster+5 -2
mediawiki/extensions/VisualEditormaster+9 -20
mediawiki/extensions/VisualEditormaster+2 -2
mediawiki/extensions/VisualEditormaster+5 -5
mediawiki/extensions/VisualEditormaster+13 -22
mediawiki/extensions/VisualEditormaster+47 -21
mediawiki/extensions/VisualEditormaster+0 -4
Show related patches Customize query in gerrit

Event Timeline

thiemowmde set the point value for this task to 0.Aug 13 2021, 2:40 PM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-08-04 board.

Change 712972 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Stop re-creating template parameter pages over and over again

https://gerrit.wikimedia.org/r/712972

Change 712973 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move filterParameter event closer to where it's emitted

https://gerrit.wikimedia.org/r/712973

This task should be linked with another for actually removing the old sidebar.

Change 713258 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused properties from template part widget classes

https://gerrit.wikimedia.org/r/713258

Change 713258 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused properties from template part widget classes

https://gerrit.wikimedia.org/r/713258

Change 712972 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Stop re-creating template parameter pages over and over again

https://gerrit.wikimedia.org/r/712972

Change 711148 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused code from ve.ui.MWTransclusionOutlinePartWidget

https://gerrit.wikimedia.org/r/711148

Change 713831 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove dependency from new sidebar to the BookletLayout

https://gerrit.wikimedia.org/r/713831

Change 712973 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Move filterParameter event closer to where it's emitted

Reason:

Replaced with Ifcf2cad.

https://gerrit.wikimedia.org/r/712973

Change 711148 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused code from ve.ui.MWTransclusionOutlinePartWidget

https://gerrit.wikimedia.org/r/711148

Change 713872 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Use page ID string instead of object reference

https://gerrit.wikimedia.org/r/713872

Change 713873 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Call focusPart() only once in MWTemplateDialog.onReplacePart()

https://gerrit.wikimedia.org/r/713873

Change 703438 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Better method names in MWTransclusionModel class

https://gerrit.wikimedia.org/r/703438

Change 712117 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Citoid@master] Temporary compatibility in a test to allow changing VisualEditor

https://gerrit.wikimedia.org/r/712117

Change 710223 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Streamline and harden template paramter search widget behavior

https://gerrit.wikimedia.org/r/710223

Change 710223 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Streamline and harden template paramter search widget behavior

https://gerrit.wikimedia.org/r/710223

Change 713872 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use page ID string instead of object reference

https://gerrit.wikimedia.org/r/713872

Change 714016 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix null error in ve.ui.MWTemplateDialog

https://gerrit.wikimedia.org/r/714016

Change 714016 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix null error in ve.ui.MWTemplateDialog

https://gerrit.wikimedia.org/r/714016

Change 713873 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Call focusPart() only once in MWTemplateDialog.onReplacePart()

https://gerrit.wikimedia.org/r/713873

Change 712117 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Temporary compatibility in a test to allow changing VisualEditor

https://gerrit.wikimedia.org/r/712117

Change 703438 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Better method names in MWTransclusionModel class

https://gerrit.wikimedia.org/r/703438

Change 714069 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Toggle parameter search without extra event

https://gerrit.wikimedia.org/r/714069

Change 713831 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dependency from new sidebar to the BookletLayout

https://gerrit.wikimedia.org/r/713831

Change 714810 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move lots of code from \u2026TemplateWidget to \u2026SelectWidget

https://gerrit.wikimedia.org/r/714810

Change 715047 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Move small code snippets into \u2026OutlineParameterSelectWidget

https://gerrit.wikimedia.org/r/715047

Change 714069 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Toggle parameter search without extra event

Reason:

Already done as part of I319896a.

https://gerrit.wikimedia.org/r/714069

Change 715047 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move small code snippets into \u2026OutlineParameterSelectWidget

https://gerrit.wikimedia.org/r/715047

Change 715247 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Citoid@master] Remove temporary compatibility hack with VisualEditor

https://gerrit.wikimedia.org/r/715247

Change 715265 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] More complete top-level part selection support in new sidebar

https://gerrit.wikimedia.org/r/715265

Change 715265 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] More complete top-level part selection support in new sidebar

https://gerrit.wikimedia.org/r/715265

Change 715247 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Remove temporary compatibility hack with VisualEditor

https://gerrit.wikimedia.org/r/715247