Remove ResourceLoader loaderScripts feature from extension.json schema
Closed, ResolvedPublic
Actions

Description

Noticed while looking for something else that some options can still be specified even though they are ignored. Instead, they should be removed from the schema:

The position option should be removed from ResourceLoaderFileModule, ResourceLoaderWikiModule, and ResourceLoaderImageModule - T184257: Removed unused 'position' statements from module registrations in extensions and skins, T109837: Remove top/bottom queue distinction
The loaderScripts option should be removed from ResourceLoaderFileModule - T65240: ResourceLoader: Remove support for 'startupScripts' and 'loaderScripts' feature

Details

Subject	Repo	Branch	Lines +/-
ExtensionProcessor: Remove `loaderScripts` from extension.json schemas	mediawiki/core	REL1_35	+8 -18
ExtensionProcessor: Remove `loaderScripts` from extension.json schemas	mediawiki/core	REL1_36	+8 -18
ExtensionProcessor: Remove `loaderScripts` from extension.json schemas	mediawiki/core	REL1_31	+8 -18
ExtensionProcessor: Remove `loaderScripts` from extension.json schemas	mediawiki/core	master	+8 -18

Customize query in gerrit

Related Objects

Mentioned Here: T65240: ResourceLoader: Remove support for 'startupScripts' and 'loaderScripts' feature
T109837: Remove top/bottom queue distinction
T184257: Removed unused 'position' statements from module registrations in extensions and skins

Event Timeline

DannyS712 created this task.Aug 18 2021, 5:50 AM

Restricted Application added projects: Performance-Team, User-DannyS712. · View Herald TranscriptAug 18 2021, 5:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 713512 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove unsupported ResourceLoader features from extension schema

https://gerrit.wikimedia.org/r/713512

gerritbot added a project: Patch-For-Review.Aug 18 2021, 5:50 AM

DannyS712 claimed this task.Aug 20 2021, 12:50 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

Krinkle renamed this task from Remove unsupported ResourceLoader features from extension schema to Remove ResourceLoader loaderScripts feature from extension.json schema.Aug 20 2021, 4:12 AM

Krinkle closed this task as Resolved.

Krinkle edited projects, added MediaWiki-Configuration, Performance-Team (Radar); removed Performance-Team, MediaWiki-ResourceLoader.

Change 713512 merged by jenkins-bot:

[mediawiki/core@master] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713512

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 20 2021, 5:00 AM

Change 713857 had a related patch set uploaded (by Legoktm; author: DannyS712):

[mediawiki/core@REL1_36] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713857

Change 713858 had a related patch set uploaded (by Legoktm; author: DannyS712):

[mediawiki/core@REL1_35] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713858

Change 713859 had a related patch set uploaded (by Legoktm; author: DannyS712):

[mediawiki/core@REL1_31] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713859

Change 713859 merged by jenkins-bot:

[mediawiki/core@REL1_31] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713859

Change 713858 merged by jenkins-bot:

[mediawiki/core@REL1_35] ExtensionProcessor: Remove `loaderScripts` from extension.json schemas

https://gerrit.wikimedia.org/r/713858

Change 713857 merged by jenkins-bot: