Page MenuHomePhabricator
Create Task
Maniphest T290193

$wgShellboxUrls doesn't work for BoxedCommand
Closed, ResolvedPublic
Actions

Description

The ShellboxClient is created in CommandFactory::createBoxed() where it doesn't have access to pass in a service name to change which URL should be used.

Patch incoming...

Details

SubjectRepoBranchLines +/-
Use the 'score' Shellbox if configuredmediawiki/extensions/Scorewmf/1.37.0-wmf.21+2 -1
shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommandmediawiki/corewmf/1.37.0-wmf.21+6 -3
shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommandmediawiki/coremaster+6 -3
Use the 'score' Shellbox if configuredmediawiki/extensions/Scoremaster+2 -1
Customize query in gerrit

Event Timeline

Legoktm created this task.Sep 1 2021, 6:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2021, 6:41 PM
gerritbot added a comment.Sep 1 2021, 6:46 PM

Change 716009 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand

https://gerrit.wikimedia.org/r/716009

gerritbot added a project: Patch-For-Review.Sep 1 2021, 6:46 PM

Change 716010 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Score@master] Use the 'score' Shellbox if configured

https://gerrit.wikimedia.org/r/716010

gerritbot added a comment.Sep 2 2021, 12:03 AM

Change 716009 merged by jenkins-bot:

[mediawiki/core@master] shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand

https://gerrit.wikimedia.org/r/716009

gerritbot added a comment.Sep 2 2021, 12:07 AM

Change 716010 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Use the 'score' Shellbox if configured

https://gerrit.wikimedia.org/r/716010

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 12:10 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 2 2021, 1:00 AM
gerritbot added a comment.Sep 2 2021, 5:54 PM

Change 716103 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.37.0-wmf.21] shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand

https://gerrit.wikimedia.org/r/716103

gerritbot added a project: Patch-For-Review.Sep 2 2021, 5:54 PM

Change 716104 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Score@wmf/1.37.0-wmf.21] Use the 'score' Shellbox if configured

https://gerrit.wikimedia.org/r/716104

Legoktm closed this task as Resolved.Sep 2 2021, 6:00 PM

I'll backport this after today's train finishes

gerritbot added a comment.Sep 9 2021, 12:35 AM

Change 716103 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.21] shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand

https://gerrit.wikimedia.org/r/716103

gerritbot added a comment.Sep 9 2021, 12:37 AM

Change 716104 merged by jenkins-bot:

[mediawiki/extensions/Score@wmf/1.37.0-wmf.21] Use the 'score' Shellbox if configured

https://gerrit.wikimedia.org/r/716104

Stashbot added a comment.Sep 9 2021, 12:45 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-09T00:45:10Z] <legoktm@deploy1002> sync-file aborted: shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand (T290193 (duration: 00m 07s)

Stashbot added a comment.Sep 9 2021, 12:46 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-09T00:46:15Z] <legoktm@deploy1002> Synchronized php-1.37.0-wmf.21/includes/shell/CommandFactory.php: shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand (T290193) (duration: 00m 58s)

Stashbot added a comment.Sep 9 2021, 12:48 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-09T00:48:21Z] <legoktm@deploy1002> Synchronized php-1.37.0-wmf.21/extensions/Score/includes/Score.php: Use the 'score' Shellbox if configured (T290193) (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30); removed MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 9 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2021, 1:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits