The PGN standard defines numeric annotation glyphs (NAGs) as a way to represent common annotation symbols in ASCII. The program does not support NAGs and does not handle them as valid PGN. The extension should recognize the glyphs and translate them to their unicode equivalent for display to the reader.
See 3rd game on https://en.wikipedia.beta.wmflabs.org/wiki/User:קיפודנחש1/ChessBrowser_test_cases
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Parse Numeric Annotation Glyphs (NAGs) | mediawiki/extensions/ChessBrowser | master | +97 -5 |
Change 719450 had a related patch set uploaded (by Wugapodes; author: Wugapodes):
[mediawiki/extensions/ChessBrowser@master] Parse Numeric Annotation Glyphs (NAGs)
Change 719450 merged by jenkins-bot:
[mediawiki/extensions/ChessBrowser@master] Parse Numeric Annotation Glyphs (NAGs)
Oh I see now why this wasn't closed. Hmm, I'll need to look into the example further, but I'm not sure the problem is NAGs, or at least not them specifically. I think there's some interaction between them and all the comments and variations that's causing some problems. I'll look into the example and create a subtask when I figure out what the issue is
i think you should obtain a simpler PGN with NAGs and test it with it.
the game on my user page was copied from one of the test cases in the extension's repo, but i do not know that it's valid.
you can try to load this "test" into some "sanctioned" parser and see if it can digest this pgn.
peace
I think I managed to isolate the problems in the test PGN and can confirm the issues @TheDJ pointed out in T284034. Additionally there were also some errors in the PGN that I identified using lichess.org and fixed, but all the other parts with NAGs render fine so I'm going to close this as resolved.