Page MenuHomePhabricator

GerritBot doesn't unescape unicode characters
Open, Needs TriagePublicBUG REPORT


List of steps to reproduce (step by step, including full links if applicable):

  • Include a non-ascii unicode character in a commit summary

What happens?:
The character remains in \u escaping (probably from JSON)

What should have happened instead?:
The character should be unescaped and displayed as normal.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

" is ASCII, yet Gerritbot escaped it as well in T288741#7357099 (presumably because it’s a string delimiter). I’m pretty sure escaping " and escaping non-ASCII characters have the same root cause.

I just noticed this issue in T235901#7451499; I feel like this probably worked at some point in the past, otherwise I would’ve noticed it sooner. (Though this task suggests the bug has been present since mid-September, so evidently I already managed to miss it for a month. Maybe I’m talking rubbish and it’s actually old.)