Page MenuHomePhabricator

WDQS editor: Harmonise auto-complete samples and standard formatting tab sizes
Closed, ResolvedPublic

Description

Steps to replicate the issue (include links if applicable):

  • open the [[ URL | Wikidata Query Service UI ]]
  • start typing out a query
  • use the autocomplete feature

What happens?:
It is indented with 4 spaces:

SELECT ?item ?itemLabel WHERE {
    SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}

However, when you edit normally, the tab size is 2 spaces.

What should have happened instead?:
The samples should use the same tab size as the editor default. So it should look like this:

SELECT ?item ?itemLabel WHERE {
  SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
}

Event Timeline

Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.

Change 866567 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikidata/query/gui@master] Improve indentation of query hint

https://gerrit.wikimedia.org/r/866567

Change 866567 merged by jenkins-bot:

[wikidata/query/gui@master] Improve indentation of query hint

https://gerrit.wikimedia.org/r/866567

Change 867208 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: WDQSGuiBuilder):

[wikidata/query/gui-deploy@production] Merging from 47475f17d3bf88403aa1d7a91ed6642277ce5cc9

https://gerrit.wikimedia.org/r/867208

Change 867208 merged by Lucas Werkmeister (WMDE):

[wikidata/query/gui-deploy@production] Merging from 47475f17d3bf88403aa1d7a91ed6642277ce5cc9

https://gerrit.wikimedia.org/r/867208

This looks all good to me :)
Thanks Lucas!