Page MenuHomePhabricator

Create proofs of concept for avoiding Meta/OAuth as first login prompt
Closed, ResolvedPublic

Description

In T273512 we identified a problem whereby users are sent to Meta/OAuth when clicking a library link which requires a login.

The scope of this task is to explore potential workflow solutions to this problem and create a proof of concept for testing.

Event Timeline

Samwalton9-WMF created this task.
Samwalton9-WMF moved this task from Ready for Dev to Kanban on the The-Wikipedia-Library board.
jsn.sherman moved this task from In Progress to Ready on the The-Wikipedia-Library (Kanban) board.
jsn.sherman subscribed.

I had to set this aside to work on another task.
I had just begun playing with interrupting the login process with a form presentation, but hadn't even begun working on actually storing the preference outside the authenticated session, which is necessary since this is a form you might see before login:
https://github.com/WikipediaLibrary/TWLight/tree/jason-T292509

After the engineering meeting, we found we still need to clarify the workflow, so moving this back to the Ready column.

I've created some artifacts to clarify intended behaviour:

Here's the high level view of why we're tackling this problem.

image.png (1×1 px, 242 KB)

In terms of the more practical steps to be implemented, when a user clicks a link which requires a login in the Library Card for any reason, instead of automatically logging them in they should be sent to this page:

Frame 1 (2).png (945×1 px, 157 KB)

This shouldn't interrupt normal login workflows for the site - users who navigate directly to the homepage and click the login button should still be logged in as they are now.

@jsn.sherman @Scardenasmolinar does this help answer the questions we had in the engineering meeting? Any outstanding concerns or questions?

When I try to navigate directly to https://platform-almanhal-com.wikipedialibrary.idm.oclc.org/ I'm sent to the homepage with the message as expected, but when I log in I'm simply placed on my_library, rather than my intended destination.\

Reading back above I think I didn't make the intended behaviour clear - namely that after logging in at the homepage you should arrive at your originally intended destination, not always being sent to My Library.

This should be relatively straightforward to handle; we'll just need to preserve the url from next paremeter so that it gets added to the homepage login button.

Looks to be working well!