Page MenuHomePhabricator
Create Task
Maniphest T292693

Android on screen keyboard messes with new sidebar interaction
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce

  • Use an Android phone to edit a page with a template on beta cluster
  • Make sure the dialog is in narrow mode
  • a) Open the sidebar
  • a) Click into the parameter search in the sidebar
  • b) Click into an input field on the content side
  • b) Click on the button to open the sidebar

What happens?:

  • a) The search input field gets focus
  • a) On screen keyboard opens
  • b) The sidebar opens
  • (Assumed) Screen re-draws
  • Keyboard closes
  • You'll get thrown back to the content side

What should have happened instead?:

  • Stay on the sidebar

Software version:
Android 10 / Chromium 90 & FF 92

Details

SubjectRepoBranchLines +/-
Don't reset narrow screen mode when it's already activemediawiki/extensions/VisualEditormaster+7 -0
Only trigger sidebar recalculation when width changesmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Event Timeline

WMDE-Fisch created this task.Oct 7 2021, 8:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2021, 8:21 AM
WMDE-Fisch updated the task description. (Show Details)Oct 7 2021, 8:21 AM
lilients_WMDE renamed this task from Android on screen keyboard messes with new sidbar interaction to Android on screen keyboard messes with new sidebar interaction .Oct 7 2021, 9:02 AM
WMDE-Fisch claimed this task.Oct 7 2021, 9:18 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-29 board.
gerritbot added a comment.Oct 7 2021, 12:15 PM

Change 727320 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Only trigger sidebar recalculation when width changes

https://gerrit.wikimedia.org/r/727320

gerritbot added a project: Patch-For-Review.Oct 7 2021, 12:15 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 7 2021, 12:15 PM
WMDE-Fisch set the point value for this task to 3.
gerritbot added a comment.Oct 7 2021, 6:46 PM

Change 727462 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Don't reset narrow screen mode when it's already active

https://gerrit.wikimedia.org/r/727462

thiemowmde subscribed.Oct 7 2021, 6:49 PM

I can reproduce it on my desktop machine.

  • Switch to the mobile skin.
  • Edit a template.
  • Make the window so small that the dialog collapses and shows only one side.
  • Go to the sidebar.
  • Click a search field.
  • Now move your mouse to the bottom of the window and change the window's height. The sidebar closes.

The same happens when you change the window's width, e.g. make it a little bit smaller. This should not make a difference the same way as changing the height should not make a difference.

gerritbot added a comment.Oct 8 2021, 7:58 AM

Change 727320 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Only trigger sidebar recalculation when width changes

Reason:

Fixing autoExpand really seems to be the better option. :-)

https://gerrit.wikimedia.org/r/727320

WMDE-Fisch moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 8 2021, 7:59 AM
gerritbot added a comment.Oct 8 2021, 8:17 AM

Change 727462 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't reset narrow screen mode when it's already active

https://gerrit.wikimedia.org/r/727462

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 8 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2021, 9:10 AM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Oct 8 2021, 2:18 PM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-29 board.Oct 12 2021, 8:33 AM
Lena_WMDE closed this task as Resolved.Oct 13 2021, 10:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits