[wbstack api] MediawikiInit fails if no response
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• toan
	Oct 12 2021, 10:04 AM

Description

If the MediawikiInit job fails, for example with no response from the MW api, it just fails horribly without a retry

[2021-10-12 09:35:40][Tv7n38NerRao3Jwj7P7tkKMb4P9Xetvi] Processing: App\Jobs\MediawikiInit
[2021-10-12 09:35:42][Tv7n38NerRao3Jwj7P7tkKMb4P9Xetvi] Failed:     App\Jobs\MediawikiInit
[2021-10-12 09:35:42] production.ERROR: array_key_exists() expects parameter 2 to be array, null given {"exception":"[object] (ErrorException(code: 0): array_key_exists() expects parameter 2 to be array, null given at /var/www/html/app/Jobs/MediawikiInit.php:60)
[stacktrace]
#0 [internal function]: Illuminate\\Foundation\\Bootstrap\\HandleExceptions->handleError(2, 'array_key_exist...', '/var/www/html/a...', 60, Array)
#1 /var/www/html/app/Jobs/MediawikiInit.php(60): array_key_exists('wbstackInit', NULL)
#2 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): App\\Jobs\\MediawikiInit->handle()
#3 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php(40): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
#4 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\\Container\\Util::unwrapIfClosure(Object(Closure))
#5 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(37): Illuminate\\Container\\BoundMethod::callBoundMethod(Object(Illuminate\\Foundation\\Application), Array, Object(Closure))
#6 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(653): Illuminate\\Container\\BoundMethod::call(Object(Illuminate\\Foundation\\Application), Array, Array, NULL)
#7 /var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(128): Illuminate\\Container\\Container->call(Array)
#8 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Bus\\Dispatcher->Illuminate\\Bus\\{closure}(Object(App\\Jobs\\MediawikiInit))
#9 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(App\\Jobs\\MediawikiInit))
#10 /var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(132): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#11 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(120): Illuminate\\Bus\\Dispatcher->dispatchNow(Object(App\\Jobs\\MediawikiInit), false)
#12 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Queue\\CallQueuedHandler->Illuminate\\Queue\\{closure}(Object(App\\Jobs\\MediawikiInit))
#13 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(App\\Jobs\\MediawikiInit))
#14 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(122): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#15 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(70): Illuminate\\Queue\\CallQueuedHandler->dispatchThroughMiddleware(Object(Illuminate\\Queue\\Jobs\\RedisJob), Object(App\\Jobs\\MediawikiInit))
#16 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Jobs/Job.php(98): Illuminate\\Queue\\CallQueuedHandler->call(Object(Illuminate\\Queue\\Jobs\\RedisJob), Array)
#17 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(428): Illuminate\\Queue\\Jobs\\Job->fire()
#18 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(378): Illuminate\\Queue\\Worker->process('redis', Object(Illuminate\\Queue\\Jobs\\RedisJob), Object(Illuminate\\Queue\\WorkerOptions))
#19 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(172): Illuminate\\Queue\\Worker->runJob(Object(Illuminate\\Queue\\Jobs\\RedisJob), 'redis', Object(Illuminate\\Queue\\WorkerOptions))
#20 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(117): Illuminate\\Queue\\Worker->daemon('redis', 'default', Object(Illuminate\\Queue\\WorkerOptions))
#21 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(101): Illuminate\\Queue\\Console\\WorkCommand->runWorker('redis', 'default')
#22 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Illuminate\\Queue\\Console\\WorkCommand->handle()
#23 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php(40): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
#24 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\\Container\\Util::unwrapIfClosure(Object(Closure))
#25 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(37): Illuminate\\Container\\BoundMethod::callBoundMethod(Object(Illuminate\\Foundation\\Application), Array, Object(Closure))
#26 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(653): Illuminate\\Container\\BoundMethod::call(Object(Illuminate\\Foundation\\Application), Array, Array, NULL)
#27 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(136): Illuminate\\Container\\Container->call(Array)
#28 /var/www/html/vendor/symfony/console/Command/Command.php(299): Illuminate\\Console\\Command->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Illuminate\\Console\\OutputStyle))
#29 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(121): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Illuminate\\Console\\OutputStyle))
#30 /var/www/html/vendor/symfony/console/Application.php(978): Illuminate\\Console\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#31 /var/www/html/vendor/symfony/console/Application.php(295): Symfony\\Component\\Console\\Application->doRunCommand(Object(Illuminate\\Queue\\Console\\WorkCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#32 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#33 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Application.php(94): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#34 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(129): Illuminate\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#35 /var/www/html/artisan(37): Illuminate\\Foundation\\Console\\Kernel->handle(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#36 {main}
"}

Check that it's an array and handle the error

On failure the exception from the Mediawiki side should be returned to the API and not result in a stacktrace

Event Timeline

• toan created this task.Oct 12 2021, 10:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2021, 10:04 AM

• toan updated the task description. (Show Details)Oct 12 2021, 10:23 AM

Ideally this should retry

• toan updated the task description. (Show Details)Nov 4 2021, 3:39 PM

Addshore moved this task from Backlog (incoming) to Ready to Pick Up on the Wikibase Cloud board.Nov 5 2021, 1:38 PM

Addshore triaged this task as Low priority.Nov 5 2021, 1:52 PM

Addshore updated the task description. (Show Details)Nov 5 2021, 2:27 PM

Addshore set the point value for this task to 1.Nov 5 2021, 2:30 PM

• toan claimed this task.Nov 5 2021, 2:38 PM

• toan moved this task from Ready to Pick Up to Doing on the Wikibase Cloud board.

https://github.com/wbstack/api/pull/243

• toan moved this task from Doing to Review on the Wikibase Cloud board.Nov 5 2021, 3:28 PM

Addshore claimed this task.Nov 8 2021, 9:03 AM

Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 8 2021, 9:03 AM

Merged.
This is an interesting one, where I feel like we should move this to a "pending release" column on our board, so it can be collected with other things.
Right now though we don't have that column.

Addshore removed Addshore as the assignee of this task.Nov 8 2021, 9:36 AM

Addshore moved this task from Review to To Release on the Wikibase Cloud board.

Addshore removed a project: User-Addshore.

Addshore renamed this task from MediawikiInit fails if no response to [wbstack api] MediawikiInit fails if no response.Nov 8 2021, 8:01 PM

• Samantha_Alipio_WMDE edited projects, added Wikibase Federated Properties Deployment (Iteration Zero); removed Wikibase Cloud.Nov 17 2021, 1:47 PM

• Samantha_Alipio_WMDE moved this task from Sprint Backlog to To Release on the Wikibase Federated Properties Deployment (Iteration Zero) board.

• Samantha_Alipio_WMDE edited projects, added Wikibase Federated Properties Deployment (Sprint 1); removed Wikibase Federated Properties Deployment (Iteration Zero).Nov 24 2021, 4:10 PM

• Samantha_Alipio_WMDE moved this task from Sprint Backlog to To Release on the Wikibase Federated Properties Deployment (Sprint 1) board.

Addshore moved this task from To Release to Done on the Wikibase Federated Properties Deployment (Sprint 1) board.Dec 3 2021, 4:37 PM

Tarrow closed this task as Resolved.Dec 7 2021, 12:38 PM

Tarrow claimed this task.