Page MenuHomePhabricator

Special pages content is moved when the sidebar is collapsed but the tabs are not
Closed, DeclinedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

irudia.png (896×1 px, 79 KB)

The content is moved left, taking the full width, but the upper tab is still in its position (not actually, the tab is to the right of the due position).

What should have happened instead?: Or everything moves, or nothing moves.

Event Timeline

It may be a subpart, if both where moving in the same way. But may the decission be that taking the full width is not what we need. Or another solution (like just riding apart from the "Special" or "Category" tab there and moving elsewhere. The behaviour here is important, as they are the only pages where full width is achieved if the sidebar is collapsed.

Jdlrobson triaged this task as Medium priority.Oct 15 2021, 10:32 PM
Jdlrobson subscribed.

This doesn't appear to be working as expected.

There's a rule:

.skin-vector-disable-max-width .mw-content-container {
    max-width: none;
}

but it should also apply to: .mw-article-toolbar-container

Change 744842 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [Documentation] Document decision in T293441 in code

https://gerrit.wikimedia.org/r/744842

Change 744842 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Documentation] Document decision in T293441 in code

https://gerrit.wikimedia.org/r/744842

@Theklan this is expected. Please see this explanation.

Most special pages do not have a max-width. If you would like this special page, or other special pages, to have a max-width (so they will look and behave like article pages) please file a task for that. You can see the config here.

I imagine that my response will upset you, and I apologize in advance.

Yes @alexhollender, that explains why the design is not going to be consistent. I'm not going to argue about the importance of consistency. The issue wasn't about the fixed or full width, but about the tabs in the upside not moving with the design. If the sidebar is collapsed, the content is moved to full-width but the tabs are fixed. And, besides of design consistency, this is the error I was reporting.

@Theklan as the project progresses the layout will continue to change. We may end up with something like this:

Anyways, I don't see the purpose of us discussing this since you will continue to tell me that I am wrong and don't know what I am doing.

The tab solution seems pretty good in this mockup, and solves the problem presented here, indeed.