Page MenuHomePhabricator

No result given when searching using "offset" option in Special:IndexPages
Closed, ResolvedPublic

Details

Reference
bz27678

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz27678.
bzimport added a subscriber: Unknown Object (MLST).

It doesn't work when offset >= limit, otherwise it works.

In addition, some pages do not appear in the results. For example, this page contains the text BNF but doesn't appear in the search: http://fr.wikisource.org/wiki/Livre:Barchou_de_Penho%C3%ABn_-_Histoire_de_la_conqu%C3%AAte_de_l%E2%80%99Inde_par_l%E2%80%99Angleterre,_tome_1.djvu

beau wrote:

Patch for Special:IndexPages

It seems to me that version in trunk did not perform search at all.

I fixed following issues:

  • Disable offset in reallyDoQuery if search was performed. So it won't be applied twice.
  • List of pages is stored in $this->searchList instead of $searchList, so it will be used in getQueryInfo method.
  • When no matching indexes were found the page says so, instead of displaying all indexes.
  • When search button was clicked twice, user was redirected to main page.
  • When search button was clicked twice, the previous page limit was lost.
  • isCacheable returns false, due to search capabilities.

Attached:

beau wrote:

Applied by John Du Hart in r95347.